s390/cio: use while (i--) pattern to clean up

Use more natural while (i--) pattern to clean up allocated resources.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Link: https://lore.kernel.org/r/20240222134501.236871-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
index 6eb8bcd948dc45db60c0c4d22bb2c3de2805172d..b72f672a7720a61885c3540231fe0da56b00ef7b 100644 (file)
--- a/drivers/s390/cio/ccwgroup.c
+++ b/drivers/s390/cio/ccwgroup.c
@@ -240,7 +240,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev)
                rc = sysfs_create_link(&gdev->cdev[i]->dev.kobj,
                                       &gdev->dev.kobj, "group_device");
                if (rc) {
-                       for (--i; i >= 0; i--)
+                       while (i--)
                                sysfs_remove_link(&gdev->cdev[i]->dev.kobj,
                                                  "group_device");
                        return rc;
@@ -251,7 +251,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev)
                rc = sysfs_create_link(&gdev->dev.kobj,
                                       &gdev->cdev[i]->dev.kobj, str);
                if (rc) {
-                       for (--i; i >= 0; i--) {
+                       while (i--) {
                                sprintf(str, "cdev%d", i);
                                sysfs_remove_link(&gdev->dev.kobj, str);
                        }

diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c
index 722ad623c729f87f93825340bca46318bb7b2230..44ea76f9e1decf7b51338da1363643fd9bdd6475 100644 (file)
--- a/drivers/s390/cio/chsc.c
+++ b/drivers/s390/cio/chsc.c
@@ -844,7 +844,7 @@ chsc_add_cmg_attr(struct channel_subsystem *css)
        }
        return ret;
 cleanup:
-       for (--i; i >= 0; i--) {
+       while (i--) {
                if (!css->chps[i])
                        continue;
                chp_remove_cmg_attr(css->chps[i]);