param: Use talloc_pooled_object

Reduce memory fragmentation a bit and obsolete NULL checks

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Aug 21 14:45:58 CEST 2015 on sn-devel-104

diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index c62e0dee91166c83350ed770592841cae5224104..a0700a96f02d61c0b161f28b256ad64b23f9f124 100644 (file)
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -824,20 +824,14 @@ void set_param_opt(TALLOC_CTX *mem_ctx,
                opt = opt->next;
        }
 
-       new_opt = talloc(mem_ctx, struct parmlist_entry);
+       new_opt = talloc_pooled_object(
+               mem_ctx, struct parmlist_entry,
+               2, strlen(opt_name) + 1 + strlen(opt_value) + 1);
        if (new_opt == NULL) {
                smb_panic("OOM");
        }
-
        new_opt->key = talloc_strdup(new_opt, opt_name);
-       if (new_opt->key == NULL) {
-               smb_panic("talloc_strdup failed");
-       }
-
        new_opt->value = talloc_strdup(new_opt, opt_value);
-       if (new_opt->value == NULL) {
-               smb_panic("talloc_strdup failed");
-       }
 
        new_opt->list = NULL;
        new_opt->priority = priority;