ctdb-database: Fix signed/unsigned comparison by casting
authorMartin Schwenke <martin@meltin.net>
Mon, 24 Jun 2019 06:44:37 +0000 (16:44 +1000)
committerAmitay Isaacs <amitay@samba.org>
Fri, 5 Jul 2019 05:03:24 +0000 (05:03 +0000)
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/database/database_conf.c

index 6bdb372bf033dd41a125afbf7d9ec02709a1445d..4c7cb2d9ffe55f8cf0f378e3e92e0a34e61dd6f2 100644 (file)
@@ -96,7 +96,7 @@ static bool database_conf_validate_lock_debug_script(const char *key,
                       "%s/%s",
                       path_etcdir(),
                       basename(script));
-       if (ret >= sizeof(script_path)) {
+       if (ret < 0 || (size_t)ret >= sizeof(script_path)) {
                D_ERR("lock debug script path too long\n");
                return false;
        }