s3:rpc_transport_np: add comment about bad usage in a destructor
authorStefan Metzmacher <metze@samba.org>
Thu, 25 Mar 2010 13:10:25 +0000 (14:10 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 29 Mar 2010 16:11:15 +0000 (18:11 +0200)
metze

source3/rpc_client/rpc_transport_np.c

index 5b6a2d6ae04a53ad064c0b13dc31f3dbc0418b7d..96a8988e6429c7ad2baca8f9f469b2a7f4a63148 100644 (file)
@@ -34,7 +34,8 @@ static int rpc_transport_np_state_destructor(struct rpc_transport_np_state *s)
                DEBUG(10, ("socket was closed, no need to send close request.\n"));
                return 0;
        }
-       
+
+       /* TODO: do not use a sync call with a destructor!!! */
        if (!NT_STATUS_IS_OK(cli_close(s->cli, s->fnum))) {
                DEBUG(1, ("rpc_transport_np_state_destructor: cli_close "
                          "failed on pipe %s. Error was %s\n", s->pipe_name,