Don't discard result of checking grouptype
authorRoel van Meer <roel@1afa.com>
Fri, 22 Aug 2014 13:11:04 +0000 (15:11 +0200)
committerJeremy Allison <jra@samba.org>
Sat, 23 Aug 2014 00:48:52 +0000 (02:48 +0200)
The pdb_samba_dsdb_getgrfilter() function first determines the security type
of a group and sets map->sid_name_use accordingly. A little later, this
variable is set again, undoing the previous work.

https://bugzilla.samba.org/show_bug.cgi?id=10777

Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Aug 23 02:48:52 CEST 2014 on sn-devel-104

source3/passdb/pdb_samba_dsdb.c

index b04e7b230a791f09d75cda238229066ea33e0120..87320e8708b9857eec6aed8f8b0410ba5f92ca7d 100644 (file)
@@ -944,8 +944,6 @@ static NTSTATUS pdb_samba_dsdb_getgrfilter(struct pdb_methods *m, GROUP_MAP *map
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
 
-               map->sid_name_use = SID_NAME_DOM_GRP;
-
                ZERO_STRUCT(id_map);
                id_map.sid = sid;
                id_maps[0] = &id_map;