PY3: detect talloc_utils (for version of python running the build)
authorNoel Power <noel.power@suse.com>
Fri, 3 Aug 2018 15:51:59 +0000 (16:51 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 16 Sep 2018 04:16:20 +0000 (06:16 +0200)
It seems all combinations have potential to fail here :/ however for
the moment making the assumption
  *  if python2 driving the build you are building against libpython2 (with the option of having python3 as 'extra-python'
  *  if python3 driving the build you are building against libpython3 (with the option of having python3 as 'extra-python' NOTE: this isn't inforced it probably should be !!!! In a system with python2 and python3 installed it seems waf needs PYTHON env variable to decide which libpython to build against. It's also an option that configure should use that too (to figure out which talloc_util to use or build)

However.... right now I just want the thing to build

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/talloc/wscript

index 4a17650c052079ddc26a13ad0b9216cb93dfec12..a5841b46e4e9cc1f38c180f0488a1437afaf4f61 100644 (file)
@@ -77,10 +77,10 @@ def configure(conf):
             using_system_pytalloc_util = False
         else:
             using_system_pytalloc_util = True
-            if not conf.CHECK_BUNDLED_SYSTEM_PKG('pytalloc-util', minversion=VERSION,
+            name = 'pytalloc-util' + conf.all_envs['default']['PYTHON_SO_ABI_FLAG']
+            if not conf.CHECK_BUNDLED_SYSTEM_PKG(name, minversion=VERSION,
                                                  implied_deps='talloc replace'):
                 using_system_pytalloc_util = False
-
             # We need to get a pytalloc-util for all the python versions
             # we are building for
             if conf.env['EXTRA_PYTHON']: