s4:dsdb: Remove trailing whitespace
authorJo Sutton <josutton@catalyst.net.nz>
Thu, 11 Jan 2024 02:05:07 +0000 (15:05 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 8 Feb 2024 02:48:45 +0000 (02:48 +0000)
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/cracknames.c

index 52f5e4164208d0953b9fadd0aa36611f0d5030cf..2660ddb75602a95acf9c79131f0b41fbc4d3a060 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
 
    crachnames implementation for the drsuapi pipe
@@ -43,23 +43,23 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                                   struct smb_krb5_context *smb_krb5_context,
                                   uint32_t format_flags, enum drsuapi_DsNameFormat format_offered,
                                   enum drsuapi_DsNameFormat format_desired,
-                                  struct ldb_dn *name_dn, const char *name, 
-                                  const char *domain_filter, const char *result_filter, 
+                                  struct ldb_dn *name_dn, const char *name,
+                                  const char *domain_filter, const char *result_filter,
                                   struct drsuapi_DsNameInfo1 *info1, int scope, struct ldb_dn *search_dn);
 static WERROR DsCrackNameOneSyntactical(TALLOC_CTX *mem_ctx,
                                        enum drsuapi_DsNameFormat format_offered,
                                        enum drsuapi_DsNameFormat format_desired,
-                                       struct ldb_dn *name_dn, const char *name, 
+                                       struct ldb_dn *name_dn, const char *name,
                                        struct drsuapi_DsNameInfo1 *info1);
 
-static WERROR dns_domain_from_principal(TALLOC_CTX *mem_ctx, struct smb_krb5_context *smb_krb5_context, 
-                                       const char *name, 
-                                       struct drsuapi_DsNameInfo1 *info1) 
+static WERROR dns_domain_from_principal(TALLOC_CTX *mem_ctx, struct smb_krb5_context *smb_krb5_context,
+                                       const char *name,
+                                       struct drsuapi_DsNameInfo1 *info1)
 {
        krb5_error_code ret;
        krb5_principal principal;
        /* perhaps it's a principal with a realm, so return the right 'domain only' response */
-       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name, 
+       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name,
                                    KRB5_PRINCIPAL_PARSE_REQUIRE_REALM, &principal);
        if (ret) {
                info1->status = DRSUAPI_DS_NAME_STATUS_NOT_FOUND;
@@ -96,7 +96,7 @@ static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(struct ldb_context *ldb_ct
        char *service_dn_str;
 
        const char *directory_attrs[] = {
-               "sPNMappings", 
+               "sPNMappings",
                NULL
        };
 
@@ -142,7 +142,7 @@ static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(struct ldb_context *ldb_ct
 
        for (i = 0; i < spnmappings->num_values; i++) {
                char *mapping, *p, *str;
-               mapping = talloc_strdup(tmp_ctx, 
+               mapping = talloc_strdup(tmp_ctx,
                                        (const char *)spnmappings->values[i].data);
                if (!mapping) {
                        DEBUG(1, ("LDB_lookup_spn_alias: ldb_search: dn: %s did not have an sPNMapping\n", service_dn_str));
@@ -154,7 +154,7 @@ static enum drsuapi_DsNameStatus LDB_lookup_spn_alias(struct ldb_context *ldb_ct
 
                p = strchr(mapping, '=');
                if (!p) {
-                       DEBUG(1, ("ldb_search: dn: %s sPNMapping malformed: %s\n", 
+                       DEBUG(1, ("ldb_search: dn: %s sPNMapping malformed: %s\n",
                                  service_dn_str, mapping));
                        talloc_free(tmp_ctx);
                        return DRSUAPI_DS_NAME_STATUS_NOT_FOUND;
@@ -202,11 +202,11 @@ static WERROR DsCrackNameSPNAlias(struct ldb_context *sam_ctx, TALLOC_CTX *mem_c
        enum drsuapi_DsNameStatus namestatus;
 
        /* parse principal */
-       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, 
+       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context,
                                    name, KRB5_PRINCIPAL_PARSE_NO_REALM, &principal);
        if (ret) {
                DEBUG(2, ("Could not parse principal: %s: %s\n",
-                         name, smb_get_krb5_error_message(smb_krb5_context->krb5_context, 
+                         name, smb_get_krb5_error_message(smb_krb5_context->krb5_context,
                                                           ret, mem_ctx)));
                return WERR_NOT_ENOUGH_MEMORY;
        }
@@ -297,7 +297,7 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                return WERR_OK;
        }
 
-       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name, 
+       ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name,
                                    KRB5_PRINCIPAL_PARSE_REQUIRE_REALM, &principal);
        if (ret) {
                info1->status = DRSUAPI_DS_NAME_STATUS_NOT_FOUND;
@@ -339,7 +339,7 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                break;
        case 0:
                krb5_free_principal(smb_krb5_context->krb5_context, principal);
-               return dns_domain_from_principal(mem_ctx, smb_krb5_context, 
+               return dns_domain_from_principal(mem_ctx, smb_krb5_context,
                                                 name, info1);
        default:
                info1->status = DRSUAPI_DS_NAME_STATUS_NOT_UNIQUE;
@@ -353,7 +353,7 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
         * match this filter, so we specify
         * KRB5_PRINCIPAL_UNPARSE_DISPLAY
         */
-       ret = krb5_unparse_name_flags(smb_krb5_context->krb5_context, principal, 
+       ret = krb5_unparse_name_flags(smb_krb5_context->krb5_context, principal,
                                      KRB5_PRINCIPAL_UNPARSE_NO_REALM |
                                      KRB5_PRINCIPAL_UNPARSE_DISPLAY,
                                      &unparsed_name_short);
@@ -380,10 +380,10 @@ static WERROR DsCrackNameUPN(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                free(unparsed_name_short);
                return WERR_NOT_ENOUGH_MEMORY;
        }
-       status = DsCrackNameOneFilter(sam_ctx, mem_ctx, 
-                                     smb_krb5_context, 
-                                     format_flags, format_offered, format_desired, 
-                                     NULL, unparsed_name_short, domain_filter, result_filter, 
+       status = DsCrackNameOneFilter(sam_ctx, mem_ctx,
+                                     smb_krb5_context,
+                                     format_flags, format_offered, format_desired,
+                                     NULL, unparsed_name_short, domain_filter, result_filter,
                                      info1, LDB_SCOPE_SUBTREE, NULL);
        free(unparsed_name_short);
 
@@ -629,7 +629,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                        return WERR_NOT_ENOUGH_MEMORY;
                }
 
-               domain_filter = talloc_asprintf(mem_ctx, 
+               domain_filter = talloc_asprintf(mem_ctx,
                                                "(&(objectClass=crossRef)(netbiosName=%s)(systemFlags:%s:=%u))",
                                                domain_encoded,
                                                LDB_OID_COMPARATOR_AND,
@@ -713,7 +713,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                        info1->status = DRSUAPI_DS_NAME_STATUS_NOT_FOUND;
                        return WERR_OK;
                }
-               ldap_sid = ldap_encode_ndr_dom_sid(mem_ctx, 
+               ldap_sid = ldap_encode_ndr_dom_sid(mem_ctx,
                                                   sid);
                if (!ldap_sid) {
                        return WERR_NOT_ENOUGH_MEMORY;
@@ -728,8 +728,8 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                char *unparsed_name;
                const char *unparsed_name_encoded = NULL;
 
-               ret = smb_krb5_init_context(mem_ctx, 
-                                           (struct loadparm_context *)ldb_get_opaque(sam_ctx, "loadparm"), 
+               ret = smb_krb5_init_context(mem_ctx,
+                                           (struct loadparm_context *)ldb_get_opaque(sam_ctx, "loadparm"),
                                            &smb_krb5_context);
 
                if (ret) {
@@ -783,8 +783,8 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                const char *unparsed_name_short_encoded = NULL;
                bool principal_is_host = false;
 
-               ret = smb_krb5_init_context(mem_ctx, 
-                                           (struct loadparm_context *)ldb_get_opaque(sam_ctx, "loadparm"), 
+               ret = smb_krb5_init_context(mem_ctx,
+                                           (struct loadparm_context *)ldb_get_opaque(sam_ctx, "loadparm"),
                                            &smb_krb5_context);
 
                if (ret) {
@@ -801,7 +801,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                } else if (ret == 0) {
                        krb5_free_principal(smb_krb5_context->krb5_context, principal);
                }
-               ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name, 
+               ret = krb5_parse_name_flags(smb_krb5_context->krb5_context, name,
                                            KRB5_PRINCIPAL_PARSE_NO_REALM, &principal);
                if (ret) {
                        return dns_domain_from_principal(mem_ctx, smb_krb5_context,
@@ -810,7 +810,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
 
                domain_filter = NULL;
 
-               ret = krb5_unparse_name_flags(smb_krb5_context->krb5_context, principal, 
+               ret = krb5_unparse_name_flags(smb_krb5_context->krb5_context, principal,
                                              KRB5_PRINCIPAL_UNPARSE_NO_REALM, &unparsed_name_short);
                if (ret) {
                        krb5_free_principal(smb_krb5_context->krb5_context, principal);
@@ -866,7 +866,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                                return WERR_NOT_ENOUGH_MEMORY;
                        }
 
-                       result_filter = talloc_asprintf(mem_ctx, "(|(&(servicePrincipalName=%s)(objectClass=user))(&(cn=%s)(objectClass=computer)))", 
+                       result_filter = talloc_asprintf(mem_ctx, "(|(&(servicePrincipalName=%s)(objectClass=user))(&(cn=%s)(objectClass=computer)))",
                                                        unparsed_name_short_encoded,
                                                        computer_name_encoded);
                } else {
@@ -890,11 +890,11 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
                                                 name_dn, name, info1);
        }
 
-       return DsCrackNameOneFilter(sam_ctx, mem_ctx, 
-                                   smb_krb5_context, 
-                                   format_flags, format_offered, format_desired, 
-                                   name_dn, name, 
-                                   domain_filter, result_filter, 
+       return DsCrackNameOneFilter(sam_ctx, mem_ctx,
+                                   smb_krb5_context,
+                                   format_flags, format_offered, format_desired,
+                                   name_dn, name,
+                                   domain_filter, result_filter,
                                    info1, scope, search_dn);
 }
 
@@ -905,7 +905,7 @@ WERROR DsCrackNameOneName(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx,
 static WERROR DsCrackNameOneSyntactical(TALLOC_CTX *mem_ctx,
                                        enum drsuapi_DsNameFormat format_offered,
                                        enum drsuapi_DsNameFormat format_desired,
-                                       struct ldb_dn *name_dn, const char *name, 
+                                       struct ldb_dn *name_dn, const char *name,
                                        struct drsuapi_DsNameInfo1 *info1)
 {
        char *cracked;
@@ -915,7 +915,7 @@ static WERROR DsCrackNameOneSyntactical(TALLOC_CTX *mem_ctx,
        }
 
        switch (format_desired) {
-       case DRSUAPI_DS_NAME_FORMAT_CANONICAL: 
+       case DRSUAPI_DS_NAME_FORMAT_CANONICAL:
                cracked = ldb_dn_canonical_string(mem_ctx, name_dn);
                break;
        case DRSUAPI_DS_NAME_FORMAT_CANONICAL_EX:
@@ -931,7 +931,7 @@ static WERROR DsCrackNameOneSyntactical(TALLOC_CTX *mem_ctx,
                return WERR_NOT_ENOUGH_MEMORY;
        }
 
-       return WERR_OK; 
+       return WERR_OK;
 }
 
 /* Given a filter for the domain, and one for the result, perform the
@@ -945,8 +945,8 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                                   struct smb_krb5_context *smb_krb5_context,
                                   uint32_t format_flags, enum drsuapi_DsNameFormat format_offered,
                                   enum drsuapi_DsNameFormat format_desired,
-                                  struct ldb_dn *name_dn, const char *name, 
-                                  const char *domain_filter, const char *result_filter, 
+                                  struct ldb_dn *name_dn, const char *name,
+                                  const char *domain_filter, const char *result_filter,
                                   struct drsuapi_DsNameInfo1 *info1,
                                   int scope, struct ldb_dn *search_dn)
 {
@@ -1002,11 +1002,11 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                domain_attrs = _domain_attrs_nt4;
                result_attrs = _result_attrs_nt4;
                break;
-       case DRSUAPI_DS_NAME_FORMAT_GUID:               
+       case DRSUAPI_DS_NAME_FORMAT_GUID:
                domain_attrs = _domain_attrs_guid;
                result_attrs = _result_attrs_guid;
                break;
-       case DRSUAPI_DS_NAME_FORMAT_DISPLAY:            
+       case DRSUAPI_DS_NAME_FORMAT_DISPLAY:
                domain_attrs = _domain_attrs_display;
                result_attrs = _result_attrs_display;
                break;
@@ -1134,14 +1134,14 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                break;
        case 0:
                switch (format_offered) {
-               case DRSUAPI_DS_NAME_FORMAT_SERVICE_PRINCIPAL: 
-                       return DsCrackNameSPNAlias(sam_ctx, mem_ctx, 
-                                                  smb_krb5_context, 
+               case DRSUAPI_DS_NAME_FORMAT_SERVICE_PRINCIPAL:
+                       return DsCrackNameSPNAlias(sam_ctx, mem_ctx,
+                                                  smb_krb5_context,
                                                   format_flags, format_offered, format_desired,
                                                   name, info1);
 
                case DRSUAPI_DS_NAME_FORMAT_USER_PRINCIPAL:
-                       return DsCrackNameUPN(sam_ctx, mem_ctx, smb_krb5_context, 
+                       return DsCrackNameUPN(sam_ctx, mem_ctx, smb_krb5_context,
                                              format_flags, format_offered, format_desired,
                                              name, info1);
                default:
@@ -1211,8 +1211,8 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
        }
        case DRSUAPI_DS_NAME_FORMAT_CANONICAL_EX: {
                /* Not in the virtual ldb attribute */
-               return DsCrackNameOneSyntactical(mem_ctx, 
-                                                DRSUAPI_DS_NAME_FORMAT_FQDN_1779, 
+               return DsCrackNameOneSyntactical(mem_ctx,
+                                                DRSUAPI_DS_NAME_FORMAT_FQDN_1779,
                                                 DRSUAPI_DS_NAME_FORMAT_CANONICAL_EX,
                                                 result->dn, name, info1);
        }
@@ -1274,7 +1274,7 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                                                             NULL,
                                                             LDB_SCOPE_BASE,
                                                             attrs,
-                                                            "(&(objectSid=%s)(objectClass=domain))", 
+                                                            "(&(objectSid=%s)(objectClass=domain))",
                                                             ldap_encode_ndr_dom_sid(mem_ctx, dom_sid));
 
                                if (ldb_ret != LDB_SUCCESS) {
@@ -1342,7 +1342,7 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
                info1->result_name      = ldb_msg_find_attr_as_string(result, "displayName", NULL);
                if (!info1->result_name) {
                        info1->result_name      = ldb_msg_find_attr_as_string(result, "sAMAccountName", NULL);
-               } 
+               }
                if (!info1->result_name) {
                        info1->status = DRSUAPI_DS_NAME_STATUS_NOT_FOUND;
                } else {
@@ -1408,17 +1408,17 @@ static WERROR DsCrackNameOneFilter(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
  * return the user and domain DNs.  This is used in the KDC to then
  * return the Keys and evaluate policy */
 
-NTSTATUS crack_user_principal_name(struct ldb_context *sam_ctx, 
-                                  TALLOC_CTX *mem_ctx, 
-                                  const char *user_principal_name, 
+NTSTATUS crack_user_principal_name(struct ldb_context *sam_ctx,
+                                  TALLOC_CTX *mem_ctx,
+                                  const char *user_principal_name,
                                   struct ldb_dn **user_dn,
-                                  struct ldb_dn **domain_dn) 
+                                  struct ldb_dn **domain_dn)
 {
        WERROR werr;
        struct drsuapi_DsNameInfo1 info1;
        werr = DsCrackNameOneName(sam_ctx, mem_ctx, 0,
                                  DRSUAPI_DS_NAME_FORMAT_USER_PRINCIPAL,
-                                 DRSUAPI_DS_NAME_FORMAT_FQDN_1779, 
+                                 DRSUAPI_DS_NAME_FORMAT_FQDN_1779,
                                  user_principal_name,
                                  &info1);
        if (!W_ERROR_IS_OK(werr)) {
@@ -1441,8 +1441,8 @@ NTSTATUS crack_user_principal_name(struct ldb_context *sam_ctx,
        if (domain_dn) {
                werr = DsCrackNameOneName(sam_ctx, mem_ctx, 0,
                                          DRSUAPI_DS_NAME_FORMAT_CANONICAL,
-                                         DRSUAPI_DS_NAME_FORMAT_FQDN_1779, 
-                                         talloc_asprintf(mem_ctx, "%s/", 
+                                         DRSUAPI_DS_NAME_FORMAT_FQDN_1779,
+                                         talloc_asprintf(mem_ctx, "%s/",
                                                          info1.dns_domain_name),
                                          &info1);
                if (!W_ERROR_IS_OK(werr)) {
@@ -1470,17 +1470,17 @@ NTSTATUS crack_user_principal_name(struct ldb_context *sam_ctx,
  * return the user and domain DNs.  This is used in the KDC to then
  * return the Keys and evaluate policy */
 
-NTSTATUS crack_service_principal_name(struct ldb_context *sam_ctx, 
-                                     TALLOC_CTX *mem_ctx, 
-                                     const char *service_principal_name, 
+NTSTATUS crack_service_principal_name(struct ldb_context *sam_ctx,
+                                     TALLOC_CTX *mem_ctx,
+                                     const char *service_principal_name,
                                      struct ldb_dn **user_dn,
-                                     struct ldb_dn **domain_dn) 
+                                     struct ldb_dn **domain_dn)
 {
        WERROR werr;
        struct drsuapi_DsNameInfo1 info1;
        werr = DsCrackNameOneName(sam_ctx, mem_ctx, 0,
                                  DRSUAPI_DS_NAME_FORMAT_SERVICE_PRINCIPAL,
-                                 DRSUAPI_DS_NAME_FORMAT_FQDN_1779, 
+                                 DRSUAPI_DS_NAME_FORMAT_FQDN_1779,
                                  service_principal_name,
                                  &info1);
        if (!W_ERROR_IS_OK(werr)) {
@@ -1503,8 +1503,8 @@ NTSTATUS crack_service_principal_name(struct ldb_context *sam_ctx,
        if (domain_dn) {
                werr = DsCrackNameOneName(sam_ctx, mem_ctx, 0,
                                          DRSUAPI_DS_NAME_FORMAT_CANONICAL,
-                                         DRSUAPI_DS_NAME_FORMAT_FQDN_1779, 
-                                         talloc_asprintf(mem_ctx, "%s/", 
+                                         DRSUAPI_DS_NAME_FORMAT_FQDN_1779,
+                                         talloc_asprintf(mem_ctx, "%s/",
                                                          info1.dns_domain_name),
                                          &info1);
                if (!W_ERROR_IS_OK(werr)) {
@@ -1528,10 +1528,10 @@ NTSTATUS crack_service_principal_name(struct ldb_context *sam_ctx,
        return NT_STATUS_OK;
 }
 
-NTSTATUS crack_name_to_nt4_name(TALLOC_CTX *mem_ctx, 
+NTSTATUS crack_name_to_nt4_name(TALLOC_CTX *mem_ctx,
                                struct ldb_context *ldb,
                                enum drsuapi_DsNameFormat format_offered,
-                               const char *name, 
+                               const char *name,
                                const char **nt4_domain, const char **nt4_account)
 {
        WERROR werr;
@@ -1546,7 +1546,7 @@ NTSTATUS crack_name_to_nt4_name(TALLOC_CTX *mem_ctx,
        }
 
        werr = DsCrackNameOneName(ldb, mem_ctx, 0,
-                                 format_offered, 
+                                 format_offered,
                                  DRSUAPI_DS_NAME_FORMAT_NT4_ACCOUNT,
                                  name,
                                  &info1);