Fix a segfault in base64_encode_data_blob

We did not allocate enough memory for the \0 and a = at the end

diff --git a/source/lib/util_str.c b/source/lib/util_str.c
index 6310e2464d06e2209b4a6b9338b7351d5669e61b..6678c0c24de71e08079c7efd9f9e06dbfb5864bf 100644 (file)
--- a/source/lib/util_str.c
+++ b/source/lib/util_str.c
@@ -2345,7 +2345,9 @@ char *base64_encode_data_blob(TALLOC_CTX *mem_ctx, DATA_BLOB data)
 
        out_cnt = 0;
        len = data.length;
-       output_len = data.length * 2;
+       output_len = data.length * 2 + 4; /* Account for closing bytes. 4 is
+                                          * random but should be enough for
+                                          * the = and \0 */
        result = TALLOC_ARRAY(mem_ctx, char, output_len); /* get us plenty of space */
        SMB_ASSERT(result != NULL);