s3/selftest: add some FIXMEs

this needs some rework. Sourced shell code cannot take arguments, at least no
portable shell. This generates errors on the buildfarm sind quite a while.

diff --git a/source3/selftest/tests.sh b/source3/selftest/tests.sh
index 4233cfbb141a3a7e465dd4339ec192bdc27b25d6..e53981c89ede7cbf085a4a44c2225c31dbc67241 100755 (executable)
--- a/source3/selftest/tests.sh
+++ b/source3/selftest/tests.sh
@@ -1,4 +1,5 @@
 #!/bin/bash
+###   ^^^FIXME -> sh ... breaks testing on *BSD etc. ... see FIXME's below
 # This script generates a list of testsuites that should be run as part of 
 # the Samba 3 test suite.
 
@@ -96,6 +97,7 @@ export LOCAL_PATH
        shift $#
        testitprefix="smbtorture_s3.plain."
        testitenv="dc"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
        . $SCRIPTDIR/test_smbtorture_s3.sh //\$SERVER_IP/tmp \$USERNAME \$PASSWORD "" "" "-l \$LOCAL_PATH"
 )
 
@@ -103,6 +105,7 @@ export LOCAL_PATH
        shift $#
        testitprefix="smbtorture_s3.crypt."
        testitenv="dc"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
        . $SCRIPTDIR/test_smbtorture_s3.sh //\$SERVER_IP/tmp \$USERNAME \$PASSWORD "" "-e" "-l \$LOCAL_PATH"
 )
 
@@ -110,6 +113,7 @@ export LOCAL_PATH
        shift $#
        testitprefix="wbinfo_s3."
        testitenv="dc:local"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
        . $SCRIPTDIR/test_wbinfo_s3.sh \$DOMAIN \$SERVER \$USERNAME \$PASSWORD
 )
 
@@ -117,6 +121,7 @@ export LOCAL_PATH
        shift $#
        testitprefix="wbinfo_s3."
        testitenv="dc:local"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
        . $SCRIPTDIR/test_wbinfo_s3.sh \$DOMAIN \$SERVER \$DOMAIN\\\\\$USERNAME \$PASSWORD
 )
 
@@ -124,6 +129,7 @@ export LOCAL_PATH
        shift $#
        testitprefix="wbinfo_s3."
        testitenv="member:local"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
        . $SCRIPTDIR/test_wbinfo_s3.sh \$DOMAIN \$SERVER \$DOMAIN\\\\\$USERNAME \$PASSWORD
 )
 
@@ -186,6 +192,7 @@ plantest "blackbox.testparm_s3" dc:local LOCAL_PATH="$LOCAL_PATH" BINDIR="$BINDI
        if [ -n "$SMBTORTURE4" -a -n "$SMBTORTURE4VERSION" ];then
                echo "Using SMBTORTURE4: $SMBTORTURE4BINARY"
                echo "Version: $SMBTORTURE4VERSION"
+#FIXME: shell sourcing with ARGS is just supported by bash but bash isn't everywhere.
                . $SCRIPTDIR/test_posix_s3.sh //\$SERVER_IP/tmp \$USERNAME \$PASSWORD "" ""
        else
                echo "Skip Tests with Samba4's smbtorture"