idmap_autorid: fix failure in reverse lookup if ID is from domain range index #0
authorAbhidnya Joshi <achirmul@in.ibm.com>
Fri, 25 Oct 2013 05:06:01 +0000 (07:06 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 6 May 2014 09:35:35 +0000 (11:35 +0200)
Domain range index #0 is not included in the database record.
So in this special case we only have the SID, not SID#IDX...

Signed-off-by: Abhidnya Joshi <achirmul@in.ibm.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit ebc9ff616fefbf10b31e4e097f28fa17a1abc2f8)

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10547

source3/winbindd/idmap_autorid.c

index 391a31405f4ee472d3c593e95f2da65563503c99..57d952e94ae7fbb1d886f743e2bfe968c742f644 100644 (file)
@@ -379,7 +379,7 @@ static NTSTATUS idmap_autorid_id_to_sid(struct autorid_global_config *cfg,
                map->status = ID_UNKNOWN;
                return NT_STATUS_OK;
        }
-       if (q != NULL)
+       if ((q != NULL) && (*q != '\0'))
                if (sscanf(q+1, "%"SCNu32, &domain_range_index) != 1) {
                        DEBUG(10, ("Domain range index not found, "
                                   "ignoring mapping request\n"));