fs/9p: remove unnecessary and overrestrictive check
authorEric Van Hensbergen <ericvh@kernel.org>
Wed, 19 Jul 2023 16:22:30 +0000 (16:22 +0000)
committerEric Van Hensbergen <ericvh@kernel.org>
Thu, 20 Jul 2023 16:15:14 +0000 (16:15 +0000)
This eliminates a check for shared that was overrestrictive and
prevented read-only mmaps when writeback caches weren't enabled.

Cc: stable@vger.kernel.org
Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes")
Reported-by: Robert Schwebel <r.schwebel@pengutronix.de>
Closes: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de
Reviewed-by: Dominique Martinet <asmadeus@codewreck.org>
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
fs/9p/vfs_file.c

index 2996fb00387fa7f068b50c66d7d9601e67e0b9c2..9b61b480a9b00dc8d8a8fef62dbf0d85e56daac7 100644 (file)
@@ -505,9 +505,7 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)
        p9_debug(P9_DEBUG_MMAP, "filp :%p\n", filp);
 
        if (!(v9ses->cache & CACHE_WRITEBACK)) {
-               p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");
-               if (vma->vm_flags & VM_MAYSHARE)
-                       return -ENODEV;
+               p9_debug(P9_DEBUG_CACHE, "(read-only mmap mode)");
                invalidate_inode_pages2(filp->f_mapping);
                return generic_file_readonly_mmap(filp, vma);
        }