libcli/auth: clang: Fix 'Value stored to 'status' is never read'
authorNoel Power <noel.power@suse.com>
Wed, 14 Aug 2019 13:31:07 +0000 (14:31 +0100)
committerGary Lockyer <gary@samba.org>
Tue, 27 Aug 2019 23:04:37 +0000 (23:04 +0000)
Fixes:

libcli/auth/netlogon_creds_cli.c:2622:2: warning: Value stored to 'status' is never read <--[clang]
        status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds,
        ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
libcli/auth/netlogon_creds_cli.c

index 50a5f50a57d9d53f5cd381ccba73ae6000ee2501..c5a100c3c0ee0a7472b35009aa2cb2716cc0e8ea 100644 (file)
@@ -2622,7 +2622,7 @@ static void netlogon_creds_cli_LogonSamLogon_done(struct tevent_req *subreq)
        status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds,
                                                            state->validation_level,
                                                            state->validation);
-       if (tevent_req_nterror(req, result)) {
+       if (tevent_req_nterror(req, status)) {
                netlogon_creds_cli_LogonSamLogon_cleanup(req, result);
                return;
        }