s3: libsmb: Add a missing return statement in the timeout case.

Obvious fix (needs a malicious server to recreate).

Found by Robert Morris <rtm@lcs.mit.edu>

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15426

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Aug 23 09:29:51 UTC 2023 on atb-devel-224

diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c
index 04c82e825752bacaba82458c0704b18e6e51ac9a..d7dbf97f8fb877e62a8d1865cf041c8d9e9253ee 100644 (file)
--- a/source3/libsmb/clidfs.c
+++ b/source3/libsmb/clidfs.c
@@ -202,6 +202,7 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
                         c->timeout,
                         smbXcli_conn_remote_name(c->conn));
                cli_shutdown(c);
+               return status;
        } else if (!NT_STATUS_IS_OK(status)) {
                d_printf("Protocol negotiation to server %s (for a protocol between %s and %s) failed: %s\n",
                         smbXcli_conn_remote_name(c->conn),