s4-torture: remove obsolete comment in libsmbclient torture suite.
authorGünther Deschner <gd@samba.org>
Sat, 28 Oct 2017 09:10:07 +0000 (11:10 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Mon, 30 Oct 2017 20:09:14 +0000 (21:09 +0100)
Since smbc_setX calls now handle string allocation using malloc
themselves (since commit 2d41b1ab78639abe4ae030ff482573f464564dd7) we
indeed no longer need to provide malloced strings (the extra malloc
already got removed earlier).

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 30 21:09:14 CET 2017 on sn-devel-144

source4/torture/libsmbclient/libsmbclient.c

index 16ad35182cddda48e0123c2b23dc6083ff68f543..a56a5de55d7517fac0ca2955a2a44314b57f8ce7 100644 (file)
@@ -36,8 +36,6 @@ bool torture_libsmbclient_init_context(struct torture_context *tctx,
        smbc_setDebug(ctx, DEBUGLEVEL);
        smbc_setOptionDebugToStderr(ctx, 1);
 
-       /* yes, libsmbclient API frees the username when freeing the context, so
-        * have to pass malloced data here */
        smbc_setUser(ctx,
                     cli_credentials_get_username(popt_get_cmdline_credentials()));