wifi: iwlwifi: mvm: Set THERMAL_TRIP_FLAG_RW_TEMP directly
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 12 Feb 2024 18:38:07 +0000 (19:38 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 27 Feb 2024 11:04:01 +0000 (12:04 +0100)
It is now possible to flag trip points with THERMAL_TRIP_FLAG_RW_TEMP
to allow their temperature to be set from user space via sysfs instead
of using a nonzero writable trips mask during thermal zone registration,
so make the iwlwifi code do that.

No intentional functional impact.

Note that this change is requisite for dropping the mask argument from
thermal_zone_device_register_with_trips() going forward.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/net/wireless/intel/iwlwifi/mvm/tt.c

index d2a00cbcbc428ac75e6d0320e062384ae4ba0b77..2353177f2dfab60dba30fc6fb03fb0c773a74258 100644 (file)
@@ -667,9 +667,6 @@ static  struct thermal_zone_device_ops tzone_ops = {
        .set_trip_temp = iwl_mvm_tzone_set_trip_temp,
 };
 
-/* make all trips writable */
-#define IWL_WRITABLE_TRIPS_MSK (BIT(IWL_MAX_DTS_TRIPS) - 1)
-
 static void iwl_mvm_thermal_zone_register(struct iwl_mvm *mvm)
 {
        int i, ret;
@@ -692,11 +689,12 @@ static void iwl_mvm_thermal_zone_register(struct iwl_mvm *mvm)
        for (i = 0 ; i < IWL_MAX_DTS_TRIPS; i++) {
                mvm->tz_device.trips[i].temperature = THERMAL_TEMP_INVALID;
                mvm->tz_device.trips[i].type = THERMAL_TRIP_PASSIVE;
+               mvm->tz_device.trips[i].flags = THERMAL_TRIP_FLAG_RW_TEMP;
        }
        mvm->tz_device.tzone = thermal_zone_device_register_with_trips(name,
                                                        mvm->tz_device.trips,
                                                        IWL_MAX_DTS_TRIPS,
-                                                       IWL_WRITABLE_TRIPS_MSK,
+                                                       0,
                                                        mvm, &tzone_ops,
                                                        NULL, 0, 0);
        if (IS_ERR(mvm->tz_device.tzone)) {