Initialize some magic fields

Initialize magic fields where Coverity otherwise detects that the
magic value would be used uninitialized.  (The "uses" are always
harmless copying.)

diff --git a/src/kdc/do_as_req.c b/src/kdc/do_as_req.c
index 712ccb794680b86bc2f49fe542c66b7738809a7a..611c69c2d150223f2b688a6646248f7c7dc6bfd8 100644 (file)
--- a/src/kdc/do_as_req.c
+++ b/src/kdc/do_as_req.c
@@ -841,6 +841,8 @@ prepare_error_as(struct kdc_request_state *rstate, krb5_kdc_req *request,
     kdc_realm_t *kdc_active_realm = rstate->realm_data;
     size_t count;
 
+    errpkt.magic = KV5M_ERROR;
+
     if (e_data_in != NULL) {
         /* Add a PA-FX-COOKIE to e_data_in.  e_data is a shallow copy
          * containing aliases. */

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index 547a41441767bdb9a8d2360e9f26827c632fa779..81f92098e8be0d38ea6ede087288ed138ea0e142 100644 (file)
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -909,6 +909,7 @@ prepare_error_tgs (struct kdc_request_state *state,
     krb5_data *scratch, *e_data_asn1 = NULL, *fast_edata = NULL;
     kdc_realm_t *kdc_active_realm = state->realm_data;
 
+    errpkt.magic = KV5M_ERROR;
     errpkt.ctime = request->nonce;
     errpkt.cusec = 0;
 

diff --git a/src/lib/gssapi/krb5/k5sealv3.c b/src/lib/gssapi/krb5/k5sealv3.c
index 1a5c14c2713bae6a9ba171bf1d00443858d2061e..0038a8ecb4a7dd9719e2a59b2b27129e1f0037f4 100644 (file)
--- a/src/lib/gssapi/krb5/k5sealv3.c
+++ b/src/lib/gssapi/krb5/k5sealv3.c
@@ -301,7 +301,7 @@ gss_krb5int_unseal_token_v3(krb5_context *contextptr,
                             int *conf_state, gss_qop_t *qop_state, int toktype)
 {
     krb5_context context = *contextptr;
-    krb5_data plain;
+    krb5_data plain = empty_data();
     uint64_t seqnum;
     size_t ec, rrc;
     int key_usage;