unittest: Remove test_sambafs_srv_pipe
authorVolker Lendecke <vl@samba.org>
Thu, 17 Jun 2021 06:31:32 +0000 (08:31 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 10 Dec 2021 14:02:30 +0000 (14:02 +0000)
is_known_pipename() will be removed soon

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
selftest/tests.py
testsuite/unittests/test_sambafs_srv_pipe.c [deleted file]
testsuite/unittests/wscript

index e92d8f54ede14560f455e12e8a7b259f7a415fe6..1da18820c9d01218d72ee50f046effc931cdbe5d 100644 (file)
@@ -381,8 +381,6 @@ if with_pam:
 
 plantestsuite("samba.unittests.krb5samba", "none",
               [os.path.join(bindir(), "default/testsuite/unittests/test_krb5samba")])
-plantestsuite("samba.unittests.sambafs_srv_pipe", "none",
-              [os.path.join(bindir(), "default/testsuite/unittests/test_sambafs_srv_pipe")])
 plantestsuite("samba.unittests.lib_util_modules", "none",
               [os.path.join(bindir(), "default/testsuite/unittests/test_lib_util_modules")])
 plantestsuite("samba.unittests.background_send",
diff --git a/testsuite/unittests/test_sambafs_srv_pipe.c b/testsuite/unittests/test_sambafs_srv_pipe.c
deleted file mode 100644 (file)
index 75797c9..0000000
+++ /dev/null
@@ -1,110 +0,0 @@
-#include <errno.h>
-#include <stdarg.h>
-#include <stddef.h>
-#include <setjmp.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <sys/stat.h>
-#include <cmocka.h>
-
-#include "include/config.h"
-#include "librpc/gen_ndr/ndr_samr.h"
-#include "librpc/gen_ndr/ndr_samr_scompat.h"
-#include "source3/rpc_server/srv_pipe.h"
-#include "librpc/rpc/rpc_common.h"
-#include "librpc/rpc/dcesrv_core.h"
-#include "talloc.h"
-
-struct test_state {
-       TALLOC_CTX *mem_ctx;
-       struct loadparm_context *lp_ctx;
-       struct dcesrv_context *dce_ctx;
-};
-
-static struct dcesrv_context_callbacks srv_callbacks = {
-       .log.successful_authz = NULL,
-};
-
-static int setup_samr(void **state)
-{
-       TALLOC_CTX *mem_ctx;
-       struct test_state *s;
-       const struct dcesrv_endpoint_server *ep_server;
-       NTSTATUS status;
-
-       mem_ctx = talloc_new(NULL);
-       assert_non_null(mem_ctx);
-
-       s = talloc_zero(mem_ctx, struct test_state);
-       assert_non_null(s);
-
-       s->mem_ctx = mem_ctx;
-
-       ep_server = samr_get_ep_server();
-       assert_non_null(ep_server);
-
-       status = dcerpc_register_ep_server(ep_server);
-       assert_true(NT_STATUS_IS_OK(status));
-
-       status = dcesrv_init_context(s, NULL, &srv_callbacks, &s->dce_ctx);
-       assert_true(NT_STATUS_IS_OK(status));
-
-       status = dcesrv_init_ep_server(s->dce_ctx, "samr");
-       assert_true(NT_STATUS_IS_OK(status));
-
-       *state = s;
-
-       return 0;
-}
-
-static int teardown_samr(void **state)
-{
-       struct test_state *s = talloc_get_type_abort(*state,
-                       struct test_state);
-
-       unsetenv("UNITTEST_DUMMY_MODULE_LOADED");
-
-       dcesrv_shutdown_ep_server(s->dce_ctx, "samr");
-
-       talloc_free(s->mem_ctx);
-
-       return 0;
-}
-
-static void test_is_known_pipename(void **state)
-{
-       struct test_state *s = talloc_get_type_abort(*state,
-                       struct test_state);
-       struct dcesrv_endpoint *ep;
-       char dummy_module_path[4096] = {0};
-       const char *module_env;
-       NTSTATUS status;
-
-       status = is_known_pipename(s->dce_ctx, "samr", &ep);
-       assert_true(NT_STATUS_IS_OK(status));
-
-       status = is_known_pipename(s->dce_ctx, "SAMR", &ep);
-       assert_true(NT_STATUS_IS_OK(status));
-
-       snprintf(dummy_module_path,
-                sizeof(dummy_module_path),
-                "%s/bin/modules/rpc/test_dummy_module.so",
-                SRCDIR);
-
-       status = is_known_pipename(s->dce_ctx, dummy_module_path, &ep);
-       assert_false(NT_STATUS_IS_OK(status));
-
-       module_env = getenv("UNITTEST_DUMMY_MODULE_LOADED");
-       assert_null(module_env);
-}
-
-int main(void) {
-       const struct CMUnitTest tests[] = {
-               cmocka_unit_test_setup_teardown(test_is_known_pipename,
-                                               setup_samr,
-                                               teardown_samr),
-       };
-
-       cmocka_set_message_output(CM_OUTPUT_SUBUNIT);
-       return cmocka_run_group_tests(tests, NULL, NULL);
-}
index f0cda5bcdc1868ccb60835229fe0e9ee67609e91..b14a518bd8142b70a0c098966f2a7fcfed5aee02 100644 (file)
@@ -11,15 +11,6 @@ def build(bld):
                      deps='krb5samba cmocka',
                      for_selftest=True)
 
-    bld.SAMBA_BINARY('test_sambafs_srv_pipe',
-                     source='test_sambafs_srv_pipe.c',
-                     deps='''
-                          RPC_SERVER
-                          RPC_SAMR
-                          cmocka
-                          ''',
-                     for_selftest=True)
-
     bld.SAMBA_BINARY('test_lib_util_modules',
                      source='test_lib_util_modules.c',
                      deps='''