leds: pca955x: Fix -Wvoid-pointer-to-enum-cast warning
authorJustin Stitt <justinstitt@google.com>
Wed, 16 Aug 2023 19:37:52 +0000 (19:37 +0000)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:24 +0000 (11:28 +0000)
When building with clang 18 I see the following warning:
|      drivers/leds/leds-pca955x.c:487:15: warning: cast to smaller integer
|      type 'enum pca955x_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]
|        487 |                 chip_type = (enum pca955x_type)md;

This is due to the fact that `md` is a void* while `enum pca995x_type` has the
size of an int.

Add uintptr_t cast to silence clang warning while also keeping enum cast
for readability and consistency with other `chip_type` assignment just a
few lines below:
| chip_type = (enum pca955x_type)id->driver_data;

Reported-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://github.com/ClangBuiltLinux/linux/issues/1910
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20230816-void-drivers-leds-leds-pca955x-v1-1-2967e4c1bdcc@google.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-pca955x.c

index b10e1ef38db0b558e26fc143fb9318a9cb14a039..1d7fa0cd97bf8845616a0629fbcb154f16a44153 100644 (file)
@@ -484,7 +484,7 @@ static int pca955x_probe(struct i2c_client *client)
        const void *md = device_get_match_data(&client->dev);
 
        if (md) {
-               chip_type = (enum pca955x_type)md;
+               chip_type = (enum pca955x_type)(uintptr_t)md;
        } else {
                const struct i2c_device_id *id = i2c_match_id(pca955x_id,
                                                              client);