lib:compression: Initialize variables
authorAndreas Schneider <asn@samba.org>
Sat, 3 Dec 2022 17:20:53 +0000 (18:20 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Sun, 4 Dec 2022 09:12:30 +0000 (09:12 +0000)
lib/compression/tests/test_lzx_huffman.c: In function ‘test_lzxpress_huffman_overlong_matches’:
lib/compression/tests/test_lzx_huffman.c:1013:35: error: ‘j’ may be used uninitialized [-Werror=maybe-uninitialized]
 1013 |         assert_int_equal(score, i * j);
      |                                   ^
lib/compression/tests/test_lzx_huffman.c:979:19: note: ‘j’ was declared here
  979 |         size_t i, j;
      |                   ^
lib/compression/tests/test_lzx_huffman.c: In function ‘test_lzxpress_huffman_overlong_matches_abc’:
lib/compression/tests/test_lzx_huffman.c:1059:39: error: ‘k’ may be used uninitialized [-Werror=maybe-uninitialized]
 1059 |         assert_int_equal(score, i * j * k);
      |                                       ^
lib/compression/tests/test_lzx_huffman.c:1020:22: note: ‘k’ was declared here
 1020 |         size_t i, j, k;
      |                      ^
lib/compression/tests/test_lzx_huffman.c:1059:35: error: ‘j’ may be used uninitialized [-Werror=maybe-uninitialized]
 1059 |         assert_int_equal(score, i * j * k);
      |                                   ^
lib/compression/tests/test_lzx_huffman.c:1020:19: note: ‘j’ was declared here
 1020 |         size_t i, j, k;
      |                   ^

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Sun Dec  4 09:12:30 UTC 2022 on sn-devel-184

lib/compression/tests/test_lzx_huffman.c

index 2adbe68f79968aaa8be2e556694c7abd6f62c4aa..da094555c2d713158db9d88a52953eb182ffe4ca 100644 (file)
@@ -976,7 +976,7 @@ static void test_lzxpress_huffman_random_noise_round_trip(void **state)
 
 static void test_lzxpress_huffman_overlong_matches(void **state)
 {
-       size_t i, j;
+       size_t i, j = 0;
        TALLOC_CTX *mem_ctx = talloc_new(NULL);
        DATA_BLOB original = data_blob_talloc(mem_ctx, NULL, 1024 * 1024);
        DATA_BLOB ref = {0};
@@ -1017,7 +1017,7 @@ static void test_lzxpress_huffman_overlong_matches(void **state)
 
 static void test_lzxpress_huffman_overlong_matches_abc(void **state)
 {
-       size_t i, j, k;
+       size_t i, j = 0, k = 0;
        TALLOC_CTX *mem_ctx = talloc_new(NULL);
        DATA_BLOB original = data_blob_talloc(mem_ctx, NULL, 1024 * 1024);
        DATA_BLOB ref = {0};