riscv: Fix early alternative patching
authorSamuel Holland <samuel@sholland.org>
Sun, 12 Feb 2023 02:15:32 +0000 (20:15 -0600)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 15 Feb 2023 00:10:35 +0000 (16:10 -0800)
Now that the text to patch is located using a relative offset from the
alternative entry, the text address should be computed without applying
the kernel mapping offset, both before and after VM setup.

Fixes: 8d23e94a4433 ("riscv: switch to relative alternative entries")
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Guo Ren <guoren@kernel.org>
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>
Tested-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230212021534.59121-2-samuel@sholland.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/errata/thead/errata.c

index c0bea5c94128a305a7ad3e3330e6c03d9ca89ca4..1dd90a5f86f0def25fedf320462b2e0865206ac2 100644 (file)
@@ -102,9 +102,7 @@ void __init_or_module thead_errata_patch_func(struct alt_entry *begin, struct al
 
                        /* On vm-alternatives, the mmu isn't running yet */
                        if (stage == RISCV_ALTERNATIVES_EARLY_BOOT)
-                               memcpy((void *)__pa_symbol(oldptr),
-                                      (void *)__pa_symbol(altptr),
-                                      alt->alt_len);
+                               memcpy(oldptr, altptr, alt->alt_len);
                        else
                                patch_text_nosync(oldptr, altptr, alt->alt_len);
                }