s3-passdb: Fix string duplication to pointers.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Jan  9 22:35:25 CET 2014 on sn-devel-104

diff --git a/source3/passdb/py_passdb.c b/source3/passdb/py_passdb.c
index 87dbb5dd43579920a5c20ae7fdc1321983566e40..2d3b6371b31b9aa0d93d4a68f27d583d27e3b5d8 100644 (file)
--- a/source3/passdb/py_passdb.c
+++ b/source3/passdb/py_passdb.c
@@ -2265,8 +2265,18 @@ static PyObject *py_pdb_set_aliasinfo(pytalloc_Object *self, PyObject *args)
 
        alias_sid = pytalloc_get_ptr(py_alias_sid);
 
-       fstrcpy(alias_info.acct_name, PyString_AsString(PyDict_GetItemString(py_alias_info, "acct_name")));
-       fstrcpy(alias_info.acct_desc, PyString_AsString(PyDict_GetItemString(py_alias_info, "acct_desc")));
+       alias_info.acct_name = talloc_strdup(frame, PyString_AsString(PyDict_GetItemString(py_alias_info, "acct_name")));
+       if (alias_info.acct_name == NULL) {
+               PyErr_Format(py_pdb_error, "Unable to allocate memory");
+               talloc_free(frame);
+               return NULL;
+       }
+       alias_info.acct_desc = talloc_strdup(frame, PyString_AsString(PyDict_GetItemString(py_alias_info, "acct_desc")));
+       if (alias_info.acct_desc == NULL) {
+               PyErr_Format(py_pdb_error, "Unable to allocate memory");
+               talloc_free(frame);
+               return NULL;
+       }
 
        status = methods->set_aliasinfo(methods, alias_sid, &alias_info);
        if (!NT_STATUS_IS_OK(status)) {