nsswitch/libwbclient: clang Fix Potential leak of memory

Fixes:

nsswitch/libwbclient/wbc_sid.c:848:2: warning: Potential leak of memory pointed to by 'extra_data'
        free(extra_data);
        ^
1 warning generated.
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>

diff --git a/nsswitch/libwbclient/wbc_sid.c b/nsswitch/libwbclient/wbc_sid.c
index cec7b519bfd3dd6191350d7c91fafc6686bd92d6..aab96cf9188a2c740802892242577aafe58f34e1 100644 (file)
--- a/nsswitch/libwbclient/wbc_sid.c
+++ b/nsswitch/libwbclient/wbc_sid.c
@@ -792,12 +792,14 @@ wbcErr wbcCtxGetSidAliases(struct wbcContext *ctx,
                sid_len = wbcSidToStringBuf(&sids[i], sid_str, sizeof(sid_str));
 
                if (buflen < extra_data_len + sid_len + 2) {
+                       char * tmp_data = NULL;
                        buflen *= 2;
-                       extra_data = (char *)realloc(extra_data, buflen);
-                       if (!extra_data) {
+                       tmp_data = (char *)realloc(extra_data, buflen);
+                       if (!tmp_data) {
                                wbc_status = WBC_ERR_NO_MEMORY;
                                BAIL_ON_WBC_ERROR(wbc_status);
                        }
+                       extra_data = tmp_data;
                }
 
                strncpy(&extra_data[extra_data_len], sid_str,