Recent coverity changes added directory_create_or_exist() checks to many directories.

These may not be needed, but in the meantime - ensure "make test" works again
by chmod'ing the created test directories from 0777 to 0755.

Reviewed-By: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Dec 22 02:08:33 CET 2012 on sn-devel-104

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index ea2e21d6f313aa641879a52df06e62457ab78c70..adca52fdfa32579e69a79a4e5ac403a28163bd4c 100755 (executable)
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -764,6 +764,13 @@ sub provision($$$$$$)
        }
        mkdir($_, 0777) foreach(@dirs);
 
+       ##
+       ## lockdir and piddir must be 0755
+       ##
+       chmod 0755, $lockdir;
+       chmod 0755, $piddir;
+
+
        ##
        ## create ro and msdfs share layout
        ##

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 5988b8364253ae7c29cef143d20da8ad1f8063a7..ba37504651521ac5d141fd88862338764ab2f703 100644 (file)
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -555,6 +555,12 @@ sub provision_raw_step1($$)
 
        mkdir($_, 0777) foreach (@{$ctx->{directories}});
 
+       ##
+       ## lockdir and piddir must be 0755
+       ##
+       chmod 0755, $ctx->{lockdir};
+       chmod 0755, $ctx->{piddir};
+
        unless (open(CONFFILE, ">$ctx->{smb_conf}")) {
                warn("can't open $ctx->{smb_conf}$?");
                return undef;