2006-09-21 Mikael Hallendal <micke@imendio.com>

	* loudmouth/lm-connection.c: (connection_connect_cb):
	* loudmouth/lm-proxy.c: (_lm_proxy_connect_cb):
	- Initiatilize len, patch from Richard Hult.
	- Fixes LM-58.

diff --git a/ChangeLog b/ChangeLog
index 29218a7daf328f53c4013f366a2ef61b2beb724e..deab0baadb85c96c520768328df5a843a6e7ecc3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,17 @@
+2006-09-21  Mikael Hallendal  <micke@imendio.com>
+
+       * loudmouth/lm-connection.c: (connection_connect_cb):
+       * loudmouth/lm-proxy.c: (_lm_proxy_connect_cb):
+       - Initiatilize len, patch from Richard Hult.
+       - Fixes LM-58.
+
+2006-09-19  Richard Hult  <richard@imendio.com>
+
+       * loudmouth/lm-connection.c (connection_connect_cb): 
+       * loudmouth/lm-proxy.c (_lm_proxy_connect_cb): Initialize len,
+       fixes some random bugs on connection errors, where the error code
+       returned is random numbers.
+
 2006-09-13  Mikael Hallendal  <micke@imendio.com>
 
        * loudmouth/lm-connection.c: (connection_free):

diff --git a/loudmouth/lm-connection.c b/loudmouth/lm-connection.c
index 03047d292e7e4a865950e6663f9e2b28f5b5f70a..26897ee8629a44174a05a57e2b6790e539f5f2e0 100644 (file)
--- a/loudmouth/lm-connection.c
+++ b/loudmouth/lm-connection.c
@@ -24,7 +24,6 @@
 #include <sys/stat.h> 
 #include <sys/types.h>
 #include <fcntl.h>
-#include <errno.h>
 
 #include <glib.h>
 
@@ -521,6 +520,7 @@ connection_connect_cb (GIOChannel   *source,
        fd = g_io_channel_unix_get_fd (source);
        
        if (condition == G_IO_ERR) {
+               len = sizeof (err);
                _lm_sock_get_error (fd, &err, &len);
                if (!_lm_sock_is_blocking_error (err)) {
                        g_log (LM_LOG_DOMAIN, LM_LOG_LEVEL_NET,

diff --git a/loudmouth/lm-proxy.c b/loudmouth/lm-proxy.c
index 8b5318eb3c2cc7942881fc77843e8761e7837060..dc19d32c40b6af21e42a18fa6f00533012960a19 100644 (file)
--- a/loudmouth/lm-proxy.c
+++ b/loudmouth/lm-proxy.c
@@ -202,6 +202,7 @@ _lm_proxy_connect_cb (GIOChannel *source, GIOCondition condition, gpointer data)
        g_return_val_if_fail (proxy != NULL, FALSE);
 
        if (condition == G_IO_ERR) {
+               len = sizeof (error);
                _lm_sock_get_error (connect_data->fd, &error, &len);
                _lm_connection_failed_with_error (connect_data, error);
                return FALSE;