selftest: move vfs_fruit tests that require "fruit:metadata=netatalk" to vfs.fruit_ne...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12427

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>

diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py
index 314ac9683e8037c7b73112943ddb10959a8b6831..efbde00ed5d5623c13e5e377621231137780877a 100755 (executable)
--- a/source3/selftest/tests.py
+++ b/source3/selftest/tests.py
@@ -334,7 +334,7 @@ nbt = ["nbt.dgram" ]
 
 libsmbclient = ["libsmbclient"]
 
-vfs = ["vfs.fruit", "vfs.acl_xattr"]
+vfs = ["vfs.fruit", "vfs.acl_xattr", "vfs.fruit_netatalk"]
 
 tests= base + raw + smb2 + rpc + unix + local + rap + nbt + libsmbclient + idmap + vfs
 
@@ -418,6 +418,8 @@ for t in tests:
         plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD')
     elif t == "vfs.fruit":
         plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/vfs_fruit -U$USERNAME%$PASSWORD --option=torture:localdir=$SELFTEST_PREFIX/nt4_dc/share')
+    elif t == "vfs.fruit_netatalk":
+        plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/vfs_fruit -U$USERNAME%$PASSWORD --option=torture:localdir=$SELFTEST_PREFIX/nt4_dc/share')
     elif t == "rpc.schannel_anon_setpw":
         plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/tmp -U$%', description="anonymous password set")
         plansmbtorture4testsuite(t, "nt4_dc_schannel", '//$SERVER_IP/tmp -U$%', description="anonymous password set (schannel enforced server-side)")

diff --git a/source4/torture/vfs/fruit.c b/source4/torture/vfs/fruit.c
index d5de9d5c805f1b6567455fe02712a0c93a573983..ff3bfa23af83d58a85196e4b3ca926a338c05039 100644 (file)
--- a/source4/torture/vfs/fruit.c
+++ b/source4/torture/vfs/fruit.c
@@ -3542,11 +3542,9 @@ struct torture_suite *torture_vfs_fruit(void)
        suite->description = talloc_strdup(suite, "vfs_fruit tests");
 
        torture_suite_add_1smb2_test(suite, "copyfile", test_copyfile);
-       torture_suite_add_1smb2_test(suite, "read netatalk metadata", test_read_netatalk_metadata);
        torture_suite_add_1smb2_test(suite, "read metadata", test_read_afpinfo);
        torture_suite_add_1smb2_test(suite, "write metadata", test_write_atalk_metadata);
        torture_suite_add_1smb2_test(suite, "resource fork IO", test_write_atalk_rfork_io);
-       torture_suite_add_1smb2_test(suite, "OS X AppleDouble file conversion", test_adouble_conversion);
        torture_suite_add_1smb2_test(suite, "SMB2/CREATE context AAPL", test_aapl);
        torture_suite_add_1smb2_test(suite, "stream names", test_stream_names);
        torture_suite_add_1smb2_test(suite, "truncate resource fork to 0 bytes", test_rfork_truncate);
@@ -3563,3 +3561,16 @@ struct torture_suite *torture_vfs_fruit(void)
 
        return suite;
 }
+
+struct torture_suite *torture_vfs_fruit_netatalk(void)
+{
+       struct torture_suite *suite = torture_suite_create(
+               talloc_autofree_context(), "fruit_netatalk");
+
+       suite->description = talloc_strdup(suite, "vfs_fruit tests for Netatalk interop that require fruit:metadata=netatalk");
+
+       torture_suite_add_1smb2_test(suite, "read netatalk metadata", test_read_netatalk_metadata);
+       torture_suite_add_1smb2_test(suite, "OS X AppleDouble file conversion", test_adouble_conversion);
+
+       return suite;
+}

diff --git a/source4/torture/vfs/vfs.c b/source4/torture/vfs/vfs.c
index 7f805f4d8822f773cfa99c108f6c48577ef3e5de..8b443fbecc9b94cd6a2dd26165f76c266f097091 100644 (file)
--- a/source4/torture/vfs/vfs.c
+++ b/source4/torture/vfs/vfs.c
@@ -107,6 +107,7 @@ NTSTATUS torture_vfs_init(void)
        suite->description = talloc_strdup(suite, "VFS modules tests");
 
        torture_suite_add_suite(suite, torture_vfs_fruit());
+       torture_suite_add_suite(suite, torture_vfs_fruit_netatalk());
        torture_suite_add_suite(suite, torture_acl_xattr());
 
        torture_register_suite(suite);