hwspinlock: omap: Use index to get hwspinlock pointer
authorAndrew Davis <afd@ti.com>
Thu, 8 Feb 2024 16:51:14 +0000 (10:51 -0600)
committerBjorn Andersson <andersson@kernel.org>
Wed, 6 Mar 2024 04:01:14 +0000 (20:01 -0800)
For loops with multiple initializers and increments are hard to read
and reason about, simplify this by using the looping index to index
into the hwspinlock array.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240208165114.63148-4-afd@ti.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/hwspinlock/omap_hwspinlock.c

index fe73da80018b1180f0882ecf618e2447dc029831..27b47b8623c09cca9c3d8da8cd6bf38f27f28f14 100644 (file)
@@ -75,7 +75,6 @@ static const struct hwspinlock_ops omap_hwspinlock_ops = {
 static int omap_hwspinlock_probe(struct platform_device *pdev)
 {
        struct hwspinlock_device *bank;
-       struct hwspinlock *hwlock;
        void __iomem *io_base;
        int num_locks, i, ret;
        /* Only a single hwspinlock block device is supported */
@@ -117,8 +116,8 @@ static int omap_hwspinlock_probe(struct platform_device *pdev)
        if (!bank)
                return -ENOMEM;
 
-       for (i = 0, hwlock = &bank->lock[0]; i < num_locks; i++, hwlock++)
-               hwlock->priv = io_base + LOCK_BASE_OFFSET + sizeof(u32) * i;
+       for (i = 0; i < num_locks; i++)
+               bank->lock[i].priv = io_base + LOCK_BASE_OFFSET + sizeof(u32) * i;
 
        return devm_hwspin_lock_register(&pdev->dev, bank, &omap_hwspinlock_ops,
                                                base_id, num_locks);