ntb: intel: Remove redundant pci_clear_master
authorCai Huoqing <cai.huoqing@linux.dev>
Fri, 24 Mar 2023 01:32:20 +0000 (09:32 +0800)
committerJon Mason <jdmason@kudzu.us>
Sat, 8 Jul 2023 15:02:37 +0000 (11:02 -0400)
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;

pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}

pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.

Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Acked-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
drivers/ntb/hw/intel/ntb_hw_gen1.c

index 60a4ebc7bf35ad327f75e25f201fb78c8a0acc8b..9ab836d0d4f12d1f634f0e3a8830deab38fe0df0 100644 (file)
@@ -1791,7 +1791,6 @@ static int intel_ntb_init_pci(struct intel_ntb_dev *ndev, struct pci_dev *pdev)
 
 err_mmio:
 err_dma_mask:
-       pci_clear_master(pdev);
        pci_release_regions(pdev);
 err_pci_regions:
        pci_disable_device(pdev);
@@ -1808,7 +1807,6 @@ static void intel_ntb_deinit_pci(struct intel_ntb_dev *ndev)
                pci_iounmap(pdev, ndev->peer_mmio);
        pci_iounmap(pdev, ndev->self_mmio);
 
-       pci_clear_master(pdev);
        pci_release_regions(pdev);
        pci_disable_device(pdev);
        pci_set_drvdata(pdev, NULL);