gpio: mockup: initialize a managed pointer in place
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 15 Nov 2023 16:29:01 +0000 (17:29 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 20 Nov 2023 13:24:50 +0000 (14:24 +0100)
The preferred pattern for autopointers is to initialize them when they're
declared unless it doesn't make sense. Move the declaration of the
managed device pointer to where it's initialized.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-mockup.c

index 4870e267a402acd877e7facfe844d8fe3925aa45..455eecf6380e4422156786516d64c13e4c08933d 100644 (file)
@@ -354,7 +354,6 @@ static const struct file_operations gpio_mockup_debugfs_ops = {
 static void gpio_mockup_debugfs_setup(struct device *dev,
                                      struct gpio_mockup_chip *chip)
 {
-       struct device *child __free(put_device) = NULL;
        struct gpio_mockup_dbgfs_private *priv;
        struct gpio_chip *gc;
        const char *devname;
@@ -367,7 +366,7 @@ static void gpio_mockup_debugfs_setup(struct device *dev,
         * There can only be a single GPIO device per platform device in
         * gpio-mockup so using device_find_any_child() is OK.
         */
-       child = device_find_any_child(dev);
+       struct device *child __free(put_device) = device_find_any_child(dev);
        if (!child)
                return;