s4:torture: Pass buffer correctly to write()
authorAndreas Schneider <asn@samba.org>
Wed, 28 Oct 2020 14:05:34 +0000 (15:05 +0100)
committerKarolin Seeger <kseeger@samba.org>
Fri, 30 Oct 2020 13:53:37 +0000 (13:53 +0000)
../../source4/torture/basic/denytest.c: In function ‘torture_createx_specific.isra’:
../../source4/torture/basic/denytest.c:2372:9: error: ‘write’ reading 56 bytes from a region of size 8 [-Werror=stringop-overflow=]
 2372 |   res = write(data_file_fd, &cxd, cxd_len);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14555

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 5f92ec6988d2f4c20eab9449cbe17317588f6634)

Autobuild-User(v4-13-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-13-test): Fri Oct 30 13:53:37 UTC 2020 on sn-devel-184

source4/torture/basic/denytest.c

index 1c946b81b9225fb3a80fe29593e7bf47b9bdf28f..8e7a822df09e93dfedd698905e0327827dcef0e5 100644 (file)
@@ -2369,7 +2369,7 @@ static bool torture_createx_specific(struct torture_context *tctx, struct
        if (data_file_fd >= 0) {
                size_t cxd_len = sizeof(struct createx_data);
                found = true;
-               res = write(data_file_fd, &cxd, cxd_len);
+               res = write(data_file_fd, cxd, cxd_len);
                if (res != cxd_len) {
                        torture_result(tctx, TORTURE_FAIL,
                                "(%s): write failed: %s!",