ctdb-test: Fix CID 1419118 (Error handling issues)
authorMartin Schwenke <martin@meltin.net>
Wed, 11 Oct 2017 08:04:28 +0000 (19:04 +1100)
committerMartin Schwenke <martins@samba.org>
Mon, 16 Oct 2017 03:28:19 +0000 (05:28 +0200)
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
ctdb/tests/src/fake_ctdbd.c

index 06b5b2265c926352437854d64b5891fd69b64f72..b0a251af9be3f3fd1b6bc4725eacb5f173f6d34c 100644 (file)
@@ -251,7 +251,11 @@ static bool nodemap_parse(struct node_map *node_map)
                }
                node = &node_map->node[node_map->num_nodes];
 
-               ctdb_sock_addr_from_string(ip, &node->addr, false);
+               ret = ctdb_sock_addr_from_string(ip, &node->addr, false);
+               if (ret != 0) {
+                       fprintf(stderr, "bad line (%s) - invalid IP\n", line);
+                       continue;
+               }
                ctdb_sock_addr_set_port(&node->addr, CTDB_PORT);
                node->pnn = pnn;
                node->flags = flags;