ldb: pass module init errors back to the caller

This makes provision errors clearer in Samba, as we can now get
permission denied errors presented from LDB modules.

Andrew Bartlett

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>

diff --git a/lib/ldb/common/ldb.c b/lib/ldb/common/ldb.c
index e5fa81977a7e87824466f23a027b44732d051a15..36f1c37437cb06350588ec26ddbe716d626d78b2 100644 (file)
--- a/lib/ldb/common/ldb.c
+++ b/lib/ldb/common/ldb.c
@@ -257,11 +257,12 @@ int ldb_connect(struct ldb_context *ldb, const char *url,
                return ret;
        }
 
-       if (ldb_load_modules(ldb, options) != LDB_SUCCESS) {
+       ret = ldb_load_modules(ldb, options);
+       if (ret != LDB_SUCCESS) {
                ldb_debug(ldb, LDB_DEBUG_FATAL,
                          "Unable to load modules for %s: %s",
                          url, ldb_errstring(ldb));
-               return LDB_ERR_OTHER;
+               return ret;
        }
 
        /* set the default base dn */