ctdb-tests: Fix CID 1361816 Buffer not null terminated (BUFFER_SIZE_WARNING)
authorMartin Schwenke <martin@meltin.net>
Thu, 4 Aug 2016 05:58:50 +0000 (15:58 +1000)
committerMartin Schwenke <martins@samba.org>
Mon, 8 Aug 2016 06:17:34 +0000 (08:17 +0200)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12110

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/tests/src/fake_ctdbd.c

index 35bca88b28633d2b772a0e09fd90e67949401a56..c27af4a4d7af04e2e821fd691747c33c3b522fbf 100644 (file)
@@ -2196,8 +2196,8 @@ static void control_get_ifaces(TALLOC_CTX *mem_ctx,
                        .link_state = iface->link_up,
                        .references = iface->references,
                };
-               strncpy(iface_list->iface[i].name, iface->name,
-                       CTDB_IFACE_SIZE+2);
+               strlcpy(iface_list->iface[i].name, iface->name,
+                       sizeof(iface_list->iface[i].name));
        }
 
        reply.rdata.data.iface_list = iface_list;