s4-dsdb Remove rootDSE and anonymous checks from acl_read
authorAndrew Bartlett <abartlet@samba.org>
Thu, 25 Nov 2010 05:17:10 +0000 (16:17 +1100)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 25 Nov 2010 23:36:19 +0000 (00:36 +0100)
The rootdse module handles rootDSE requests, and blocks anonymous
access, so we on't need to do it again here.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Nov 26 00:36:19 CET 2010 on sn-devel-104

source4/dsdb/samdb/ldb_modules/acl_read.c

index 3a0f6f34eb2983a9d5cff7316129def260e2e3a0..81f9bf62842245f74b4d684cf2ecb125198baa6c 100644 (file)
@@ -191,11 +191,9 @@ static int aclread_search(struct ldb_module *module, struct ldb_request *req)
 {
        struct ldb_context *ldb;
        int ret;
-       bool block_anonymous;
        struct aclread_context *ac;
        struct ldb_request *down_req;
        struct ldb_control *as_system = ldb_request_get_control(req, LDB_CONTROL_AS_SYSTEM_OID);
-       struct auth_session_info *session_info;
        struct ldb_result *res;
        struct ldb_message_element *parent;
        struct aclread_private *p;
@@ -219,19 +217,6 @@ static int aclread_search(struct ldb_module *module, struct ldb_request *req)
        if (ldb_dn_is_special(req->op.search.base)) {
                return ldb_next_request(module, req);
        }
-       /* allow all access to rootDSE */
-       if (req->op.search.scope == LDB_SCOPE_BASE && ldb_dn_is_null(req->op.search.base)) {
-               return ldb_next_request(module, req);
-       }
-
-       session_info = (struct auth_session_info *)ldb_get_opaque(ldb, "sessionInfo");
-       if (session_info && security_token_is_anonymous(session_info->security_token)) {
-               block_anonymous = dsdb_block_anonymous_ops(module);
-               if (block_anonymous) {
-                       return ldb_error(ldb, LDB_ERR_OPERATIONS_ERROR,
-                                        "This request is not allowed to an anonymous connection.");
-               }
-       }
 
        /* check accessibility of base */
        if (!ldb_dn_is_null(req->op.search.base)) {