Remove a pointles call to smb_bufrem
authorVolker Lendecke <vl@samba.org>
Fri, 31 Oct 2008 21:02:45 +0000 (22:02 +0100)
committerVolker Lendecke <vl@samba.org>
Fri, 31 Oct 2008 21:06:22 +0000 (22:06 +0100)
This call expanded to

(smb_buflen(req->inbuf)
  - PTR_DIFF(smb_buf(req->inbuf) - smb_buf(req->inbuf)))

which seems pretty pointless :-)

source3/smbd/sesssetup.c

index a482b3398a23c4f03eb90b801143164415bed3f2..b2583861217f93ead7d082233283f4280132d5c0 100644 (file)
@@ -1447,8 +1447,7 @@ void reply_sesssetup_and_X(struct smb_request *req)
                remove_from_common_flags2(FLAGS2_32_BIT_ERROR_CODES);
 
                if ((passlen1 > MAX_PASS_LEN)
-                   || (passlen1 > smb_bufrem(req->inbuf,
-                                             smb_buf(req->inbuf)))) {
+                   || (passlen1 > smb_buflen(req->inbuf))) {
                        reply_nterror(req, nt_status_squash(
                                              NT_STATUS_INVALID_PARAMETER));
                        END_PROFILE(SMBsesssetupX);