wafsamba: Remove 2010 comments that seems not accurate anymore common-pthreadpool
authorMatthieu Patou <mat@matws.net>
Wed, 8 Feb 2017 20:01:50 +0000 (12:01 -0800)
committerMatthieu Patou <mat@matws.net>
Wed, 8 Feb 2017 20:01:50 +0000 (12:01 -0800)
In my tests default value is correctly used and if we provide explicitly
a --with it will comply with the store_true and if we provide --without
then it will comply with the store_false

Change-Id: I820a7f2f08c51ec23b694bce7009c3891d4ab8ef
Signed-off-by: Matthieu Patou <mat@matws.net>
buildtools/wafsamba/samba_utils.py

index f5c0c53a75ea721f1fe522a6f64dc98e35016c65..0f95c125854edd19ba0193f8fc08c02a0e0bd798 100644 (file)
@@ -689,8 +689,6 @@ def samba_add_onoff_option(opt, option, help=(), dest=None, default=True,
     with_val = "--%s-%s" % (with_name, option)
     without_val = "--%s-%s" % (without_name, option)
 
-    #FIXME: This is broken and will always default to "default" no matter if
-    # --with or --without is chosen.
     opt.add_option(with_val, help=help, action="store_true", dest=dest,
                    default=default)
     opt.add_option(without_val, help=SUPPRESS_HELP, action="store_false",