From: Jeremy Allison <jra@samba.org> 
Date: Thu, 10 Aug 2000 17:48:15 +0000 (+0000)
Subject: Removed requirement that sid have an owner before being interpreted.
X-Git-Tag: samba-2.2.5pre1~3281
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=1d9a5494f8214b8d6171073f4090687a8535d78c;p=samba.git

Removed requirement that sid have an owner before being interpreted.
Thanks to Elrond for pointing this out.
Jeremy.
---

diff --git a/source/lib/util_seaccess.c b/source/lib/util_seaccess.c
index 354f7f2faee..486db7c8c80 100644
--- a/source/lib/util_seaccess.c
+++ b/source/lib/util_seaccess.c
@@ -229,30 +229,21 @@ BOOL se_access_check(SEC_DESC *sd, struct current_user *user,
 		return True;
 	}
 
-
-	/* We must know the owner sid */
-
-	if (sd->owner_sid == NULL) {
-		DEBUG(1, ("no owner for security descriptor\n"));
-		*acc_granted = 0;
-		*status = NT_STATUS_ACCESS_DENIED;
-		DEBUG(5, ("se_access_check: no owner sid, access denied\n"));
-		return False;
-	}
-
 	/* The user sid is the first in the token */
 
 	DEBUG(3, ("se_access_check: user sid is %s\n", sid_to_string(sid_str, &token->user_sids[0]) ));
 
 	/* Is the token the owner of the SID ? */
 
-	for (i = 0; i < token->num_sids; i++) {
-		if (sid_equal(&token->user_sids[i], sd->owner_sid)) {
-			/*
-			 * The owner always has SEC_RIGHTS_WRITE_DAC.
-			 */
-			if (tmp_acc_desired & SEC_RIGHTS_WRITE_DAC)
-				tmp_acc_desired &= ~SEC_RIGHTS_WRITE_DAC;
+	if (sd->owner_sid) {
+		for (i = 0; i < token->num_sids; i++) {
+			if (sid_equal(&token->user_sids[i], sd->owner_sid)) {
+				/*
+				 * The owner always has SEC_RIGHTS_WRITE_DAC.
+				 */
+				if (tmp_acc_desired & SEC_RIGHTS_WRITE_DAC)
+					tmp_acc_desired &= ~SEC_RIGHTS_WRITE_DAC;
+			}
 		}
 	}