From: David Disseldorp via samba-technical <samba-technical@lists.samba.org>
Date: Tue, 16 May 2017 12:03:32 +0000 (+0200)
Subject: smbd/smb2_ioctl: check for NULL dst_fsp before use
X-Git-Tag: ldb-1.1.30~202
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=4d1d6e2d861fdf00bef67ac4d5be5aa781c43787;p=samba.git

smbd/smb2_ioctl: check for NULL dst_fsp before use

...not after. CID #1409040.

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed May 17 01:46:52 CEST 2017 on sn-devel-144
---

diff --git a/source3/smbd/smb2_ioctl_filesys.c b/source3/smbd/smb2_ioctl_filesys.c
index fbff97cc830..392372ffecd 100644
--- a/source3/smbd/smb2_ioctl_filesys.c
+++ b/source3/smbd/smb2_ioctl_filesys.c
@@ -186,16 +186,17 @@ static struct tevent_req *fsctl_dup_extents_send(TALLOC_CTX *mem_ctx,
 	if (req == NULL) {
 		return NULL;
 	}
-	*state = (struct fsctl_dup_extents_state) {
-		.conn = dst_fsp->conn,
-		.ev = ev,
-	};
 
 	if (dst_fsp == NULL) {
 		tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER);
 		return tevent_req_post(req, ev);
 	}
 
+	*state = (struct fsctl_dup_extents_state) {
+		.conn = dst_fsp->conn,
+		.ev = ev,
+	};
+
 	if ((dst_fsp->conn->fs_capabilities
 				& FILE_SUPPORTS_BLOCK_REFCOUNTING) == 0) {
 		DBG_INFO("FS does not advertise block refcounting support\n");