From: Volker Lendecke <vl@samba.org>
Date: Sat, 17 Feb 2018 19:06:36 +0000 (+0100)
Subject: nbt_server: Avoid a talloc call
X-Git-Tag: ldb-1.3.2~4
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=7b06eacd59137711728fab17ff3517e7dbb3a5ef;p=samba.git

nbt_server: Avoid a talloc call

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source4/nbt_server/dgram/netlogon.c b/source4/nbt_server/dgram/netlogon.c
index 4753ca88a3d..3a7b1d0e4ad 100644
--- a/source4/nbt_server/dgram/netlogon.c
+++ b/source4/nbt_server/dgram/netlogon.c
@@ -143,9 +143,11 @@ static NTSTATUS nbtd_netlogon_samlogon(
 		netlogon->req.logon.nt_version, nbtsrv->task->lp_ctx,
 		&response->data.samlogon, false);
 	if (!NT_STATUS_IS_OK(status)) {
+		char buf[DOM_SID_STR_BUFLEN];
+		dom_sid_string_buf(sid, buf, sizeof(buf));
+
 		DBG_NOTICE("NBT netlogon query failed domain=%s sid=%s "
-			   "version=%d - %s\n", dst_name->name,
-			   dom_sid_string(response, sid),
+			   "version=%d - %s\n", dst_name->name, buf,
 			   netlogon->req.logon.nt_version, nt_errstr(status));
 		TALLOC_FREE(response);
 		return status;