From: Günther Deschner <gd@samba.org>
Date: Thu, 18 Feb 2010 10:20:49 +0000 (+0100)
Subject: s3-selftest: fix return code for modprinter.pl -a.
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=b6f58e25b5bbce25d4e8825e680afe3986f10e8c;hp=c42d9c4ec410e205091784cd97cbceb5572609d8;p=abartlet%2Fsamba.git%2F.git

s3-selftest: fix return code for modprinter.pl -a.

Background is: the SetPrinter level 2 calls "addprinter command" an fails if a
share already existed (and the addprinter command returned a non-0 return code).
Removing the non-0 return code is fine, as in AddPrinter{Ex}, we have checks to
see if a share already exists before calling out the addprinter command.

Maybe one day, we need to have a "changeprinter command"...

Guenther
---

diff --git a/source3/script/tests/printing/modprinter.pl b/source3/script/tests/printing/modprinter.pl
index 406484188da..9e5e3292c6c 100755
--- a/source3/script/tests/printing/modprinter.pl
+++ b/source3/script/tests/printing/modprinter.pl
@@ -95,7 +95,8 @@ while (<CONFIGFILE>) {
 		if ($section eq $share_name) {
 			$found_section = 1;
 			if ($opt_add) {
-				die("share $share_name already exists\n");
+				exit 0;
+#				die("share $share_name already exists\n");
 			}
 			if ($opt_delete) {
 				$within_section = 1;