From: Björn Jacke <bj@sernet.de>
Date: Wed, 15 Sep 2010 22:57:39 +0000 (+0200)
Subject: s3/printing: avoid a possible race condition in the cache timeout
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=cd56e40117c542fd90362abe8130f7f8d8ee02e3;p=abartlet%2Fsamba.git%2F.git

s3/printing: avoid a possible race condition in the cache timeout
---

diff --git a/source3/printing/printer_list.c b/source3/printing/printer_list.c
index d02ab886637..f52dfcffa5f 100644
--- a/source3/printing/printer_list.c
+++ b/source3/printing/printer_list.c
@@ -218,7 +218,6 @@ done:
 bool printer_list_need_refresh(void)
 {
 	NTSTATUS status;
-	time_t now = time_mono(NULL);
 	time_t last_refresh;
 	int timediff;
 
@@ -226,7 +225,7 @@ bool printer_list_need_refresh(void)
 	if (!NT_STATUS_IS_OK(status)) {
 		return true;
 	}
-	timediff = now - last_refresh;
+	timediff = time_mono(NULL) - last_refresh;
 
 	if (timediff > 1 ) {
 		/* if refresh occurred more than 1s (TODO:use lp_printcap_cache_time) ago,