From: Andrew Tridgell <tridge@samba.org>
Date: Fri, 27 Nov 2009 03:22:29 +0000 (+1100)
Subject: s4-pvfs: fixed access check failure in SFILEINFO test
X-Git-Tag: samba-4.0.0alpha9~128
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=d78921d78ca0a9211f044092b9a7f29bcfdd5397;p=samba.git

s4-pvfs: fixed access check failure in SFILEINFO test

matching windows behaviour is not always the right thing to do!
---

diff --git a/source4/ntvfs/posix/pvfs_open.c b/source4/ntvfs/posix/pvfs_open.c
index b100c856b49..621db3cf1da 100644
--- a/source4/ntvfs/posix/pvfs_open.c
+++ b/source4/ntvfs/posix/pvfs_open.c
@@ -1941,15 +1941,12 @@ NTSTATUS pvfs_can_update_file_size(struct pvfs_state *pvfs,
 			  NTCREATEX_SHARE_ACCESS_WRITE |
 			  NTCREATEX_SHARE_ACCESS_DELETE;
 	/*
-	 * I would have thought that we would need to pass
-	 * SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA here too
-	 *
-	 * But you only need SEC_FILE_WRITE_ATTRIBUTE permissions
-	 * to set the filesize.
-	 *
-	 * --metze
+	 * this code previous set only SEC_FILE_WRITE_ATTRIBUTE, with
+	 * a comment that this seemed to be wrong, but matched windows
+	 * behaviour. It now appears that this windows behaviour is
+	 * just a bug.
 	 */
-	access_mask	= SEC_FILE_WRITE_ATTRIBUTE;
+	access_mask	= SEC_FILE_WRITE_ATTRIBUTE | SEC_FILE_WRITE_DATA | SEC_FILE_APPEND_DATA;
 	delete_on_close	= false;
 	break_to_none	= true;