From: Matthieu Patou <mat@matws.net>
Date: Fri, 5 Aug 2011 19:07:57 +0000 (+0400)
Subject: pidl: add subcontext handling for wireshark
X-Git-Tag: talloc-2.0.6~27
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=da02b56572f1d7f176e9ce9044cad99640d113a1;p=ddiss%2Fsamba.git

pidl: add subcontext handling for wireshark
---

diff --git a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
index 4ff5f41e11e..ef87908fbc9 100644
--- a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
+++ b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm
@@ -361,11 +361,18 @@ sub ElementLevel($$$$$$$)
 		}
 	} elsif ($_->{TYPE} eq "SUBCONTEXT") {
 		my $num_bits = ($l->{HEADER_SIZE}*8);
+		my $hf2 = $self->register_hf_field($hf."_", "Subcontext length", "$ifname.$pn.$_->{NAME}subcontext", "FT_UINT$num_bits", "BASE_HEX", "NULL", 0, "");
+		$self->{hf_used}->{$hf2} = 1;
+		$self->pidl_code("dcerpc_info *di = pinfo->private_data;");
 		$self->pidl_code("guint$num_bits size;");
-		$self->pidl_code("int start_offset = offset;");
+		$self->pidl_code("int conformant = di->conformant_run;");
 		$self->pidl_code("tvbuff_t *subtvb;");
-		$self->pidl_code("offset = dissect_ndr_uint$num_bits(tvb, offset, pinfo, tree, drep, $hf, &size);");
-		$self->pidl_code("proto_tree_add_text(tree, tvb, start_offset, offset - start_offset + size, \"Subcontext size\");");
+		$self->pidl_code("");
+		# We need to be able to dissect the length of the context in every case
+		# and conformant run skips the dissections of scalars ...
+		$self->pidl_code("if (!conformant) {");
+		$self->indent;
+		$self->pidl_code("offset = dissect_ndr_uint$num_bits(tvb, offset, pinfo, tree, drep, $hf2, &size);");
 
 		$self->pidl_code("subtvb = tvb_new_subset(tvb, offset, size, -1);");
 		$self->pidl_code("$myname\_(subtvb, 0, pinfo, tree, drep);");