From: David Disseldorp <ddiss@samba.org>
Date: Fri, 31 Aug 2012 15:41:31 +0000 (+0200)
Subject: tdb: return unpack error on strdup failure
X-Git-Tag: samba-4.0.0rc1~296
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=e4505fc27bf31dbf922635fac19ea52a2a002bd4;p=ddiss%2Fsamba.git

tdb: return unpack error on strdup failure

Signed-off-by: Lars Müller <lars@samba.org>

Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Aug 31 21:05:21 CEST 2012 on sn-devel-104
---

diff --git a/source3/lib/util_tdb.c b/source3/lib/util_tdb.c
index c6c6d262772..8bfc75f18b6 100644
--- a/source3/lib/util_tdb.c
+++ b/source3/lib/util_tdb.c
@@ -237,6 +237,9 @@ int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...)
 			if (bufsize < len)
 				goto no_space;
 			*ps = SMB_STRDUP((const char *)buf);
+			if (*ps == NULL) {
+				goto no_space;
+			}
 			break;
 		case 'f': /* null-terminated string */
 			s = va_arg(ap,char *);