From: Andrew Bartlett <abartlet@samba.org>
Date: Thu, 27 Jun 2013 23:15:16 +0000 (+1000)
Subject: dsdb: Add assert in drepl_take_FSMO_role
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=e9faf50ee123a8d1d647ebffa39107ca0dce756c;p=mat%2Fsamba.git

dsdb: Add assert in drepl_take_FSMO_role

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source4/dsdb/repl/drepl_fsmo.c b/source4/dsdb/repl/drepl_fsmo.c
index 37fb684f47..7a107da6a3 100644
--- a/source4/dsdb/repl/drepl_fsmo.c
+++ b/source4/dsdb/repl/drepl_fsmo.c
@@ -91,11 +91,10 @@ NTSTATUS drepl_take_FSMO_role(struct irpc_message *msg,
 		extended_op = DRSUAPI_EXOP_FSMO_REQ_PDC;
 		break;
 	default:
-		DEBUG(2,("Unknown role %u in role transfer\n",
+		DEBUG(0,("Unknown role %u in role transfer\n",
 			 (unsigned)role));
-		r->out.result = WERR_DS_DRA_INTERNAL_ERROR;
-		talloc_free(tmp_ctx);
-		return NT_STATUS_OK;
+		/* IRPC messages are trusted, so this really should not happen */
+		smb_panic("Unknown role despite dsdb_get_fsmo_role_info success");
 	}
 
 	ret = samdb_dn_is_our_ntdsa(service->samdb, role_owner_dn, &is_us);