From: Volker Lendecke <vl@samba.org>
Date: Sat, 23 Jan 2010 12:53:48 +0000 (+0100)
Subject: libcli/security: Fix a valgrind error in dom_sid_parse
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=f1c889a4e61d6d751cbabd8014b4345b8051b97c;p=abartlet%2Fsamba.git%2F.git

libcli/security: Fix a valgrind error in dom_sid_parse
---

diff --git a/libcli/security/dom_sid.c b/libcli/security/dom_sid.c
index 9952977fa9e..6a046cd8061 100644
--- a/libcli/security/dom_sid.c
+++ b/libcli/security/dom_sid.c
@@ -113,6 +113,10 @@ bool dom_sid_parse(const char *sidstr, struct dom_sid *ret)
 		if (sidstr[i] == '-') num_sub_auths++;
 	}
 
+	if (num_sub_auths > ARRAY_SIZE(ret->sub_auths)) {
+		return false;
+	}
+
 	ret->sid_rev_num = rev;
 	ret->id_auth[0] = 0;
 	ret->id_auth[1] = 0;