samba.git
16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 12 Jan 2008 06:38:42 +0000 (22:38 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoFix some indents.
Günther Deschner [Sat, 12 Jan 2008 01:24:55 +0000 (02:24 +0100)]
Fix some indents.

Guenther

16 years agoCall dsgetdcname when we have no specific dc defined for joining.
Günther Deschner [Sat, 12 Jan 2008 01:22:44 +0000 (02:22 +0100)]
Call dsgetdcname when we have no specific dc defined for joining.

Guenther

16 years agoFix some error strings in libnet_join.
Günther Deschner [Sat, 12 Jan 2008 01:20:33 +0000 (02:20 +0100)]
Fix some error strings in libnet_join.

Guenther

16 years agoAdd appropriate error code when pre-creating accounts in ous isnt supported by DC.
Günther Deschner [Sat, 12 Jan 2008 01:19:21 +0000 (02:19 +0100)]
Add appropriate error code when pre-creating accounts in ous isnt supported by DC.

Guenther

16 years agoFor libnet_join error string functions, make sure not to overwrite last status string.
Günther Deschner [Sat, 12 Jan 2008 01:17:10 +0000 (02:17 +0100)]
For libnet_join error string functions, make sure not to overwrite last status string.

Guenther

16 years agoMerge all ads related calls in libnet_join_post_processing_ads().
Günther Deschner [Sat, 12 Jan 2008 01:15:42 +0000 (02:15 +0100)]
Merge all ads related calls in libnet_join_post_processing_ads().

Guenther

16 years agoUse WITH_ADS define in libnet_join, hopefully not breaking the build.
Günther Deschner [Sat, 12 Jan 2008 01:10:17 +0000 (02:10 +0100)]
Use WITH_ADS define in libnet_join, hopefully not breaking the build.

Guenther

16 years agoAuto-add missing shares in libnet_conf_set_parameter().
Günther Deschner [Sat, 12 Jan 2008 00:28:20 +0000 (01:28 +0100)]
Auto-add missing shares in libnet_conf_set_parameter().
Michael, please have a look.

Guenther

16 years agoAdd debug bool flag for libnetjoin ctx.
Günther Deschner [Fri, 11 Jan 2008 17:51:15 +0000 (18:51 +0100)]
Add debug bool flag for libnetjoin ctx.

Guenther

16 years agoUse domain_is_ad one more time in libnetjoin.
Günther Deschner [Fri, 11 Jan 2008 17:49:20 +0000 (18:49 +0100)]
Use domain_is_ad one more time in libnetjoin.

Guenther

16 years agoSync tdb with the tdb changes in ctdb. Spoke to tridge about
Jeremy Allison [Fri, 11 Jan 2008 23:08:37 +0000 (15:08 -0800)]
Sync tdb with the tdb changes in ctdb. Spoke to tridge about
this. Fixes insidious problem with order n^2 freelist merging.
Jeremy.

16 years agoRemove code accidentially submittet with last commit 83aed537c16f63.
Michael Adam [Fri, 11 Jan 2008 18:02:26 +0000 (19:02 +0100)]
Remove code accidentially submittet with last commit 83aed537c16f63.

This is ist still in preparation and will follow soon. Soory!

Michael

16 years agoFix panic in "net conf": Fix logic in error condition.
Michael Adam [Fri, 11 Jan 2008 17:55:20 +0000 (18:55 +0100)]
Fix panic in "net conf": Fix logic in error condition.

Michael

16 years agoFix a build warning.
Günther Deschner [Fri, 11 Jan 2008 17:46:41 +0000 (18:46 +0100)]
Fix a build warning.

Guenther

16 years agoAs long as DsGetDcName is not part of libnetapi, lowercase the fn name.
Günther Deschner [Fri, 11 Jan 2008 14:32:20 +0000 (15:32 +0100)]
As long as DsGetDcName is not part of libnetapi, lowercase the fn name.

Guenther

16 years agoFix libnetapi error string callers.
Günther Deschner [Fri, 11 Jan 2008 14:28:24 +0000 (15:28 +0100)]
Fix libnetapi error string callers.

Guenther

16 years agoRemove '\n' from error strings in libnet_join context.
Günther Deschner [Fri, 11 Jan 2008 14:03:31 +0000 (15:03 +0100)]
Remove '\n' from error strings in libnet_join context.

Guenther

16 years agoSet error string when ads_leave_realm() has failed in libnetjoin.
Günther Deschner [Fri, 11 Jan 2008 13:50:10 +0000 (14:50 +0100)]
Set error string when ads_leave_realm() has failed in libnetjoin.

Guenther

16 years agoInclude some basic headers in netapi.h.
Günther Deschner [Fri, 11 Jan 2008 13:47:52 +0000 (14:47 +0100)]
Include some basic headers in netapi.h.

Guenther

16 years agoRefactor libnetapi error string functions a bit.
Günther Deschner [Fri, 11 Jan 2008 13:47:23 +0000 (14:47 +0100)]
Refactor libnetapi error string functions a bit.

Guenther

16 years agoIgnore result of libnet_conf_delete_parameter here, as realm may be not there.
Günther Deschner [Fri, 11 Jan 2008 13:43:56 +0000 (14:43 +0100)]
Ignore result of libnet_conf_delete_parameter here, as realm may be not there.

Guenther

16 years agoRemove some more references to global_myname() in libnet_join.
Günther Deschner [Fri, 11 Jan 2008 13:42:48 +0000 (14:42 +0100)]
Remove some more references to global_myname() in libnet_join.

Guenther

16 years agoUse domain_is_ad bool.
Günther Deschner [Fri, 11 Jan 2008 13:41:34 +0000 (14:41 +0100)]
Use domain_is_ad bool.

Guenther

16 years agoAdd domain_is_ad bool to libnetjoin ctx.
Günther Deschner [Fri, 11 Jan 2008 13:40:06 +0000 (14:40 +0100)]
Add domain_is_ad bool to libnetjoin ctx.

Guenther

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 11 Jan 2008 00:36:05 +0000 (16:36 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoDon't switch user contexts unless you have to. Saves
Jeremy Allison [Fri, 11 Jan 2008 00:35:54 +0000 (16:35 -0800)]
Don't switch user contexts unless you have to. Saves
a bunch of syscalls on close. Noticed by Volker.
Jeremy.

16 years agoCombine fsp and tofd to tofsp in SMB_VFS_RECVFILE().
Michael Adam [Fri, 11 Jan 2008 00:26:54 +0000 (01:26 +0100)]
Combine fsp and tofd to tofsp in SMB_VFS_RECVFILE().

Michael

16 years agoRemove now redundant parameter fd from prime_cache().
Michael Adam [Thu, 10 Jan 2008 23:56:06 +0000 (00:56 +0100)]
Remove now redundant parameter fd from prime_cache().

Michael

16 years agoCombine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().
Michael Adam [Thu, 10 Jan 2008 23:51:19 +0000 (00:51 +0100)]
Combine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().

Michael

16 years agoDon't print out debug messages at level 0 if we can't
Jeremy Allison [Thu, 10 Jan 2008 23:15:01 +0000 (15:15 -0800)]
Don't print out debug messages at level 0 if we can't
bind to a socket if we've already bound to one (this
prevents :
bind failed on port 445 socket_addr = 0.0.0.0.
Error = Address already in use
bind failed on port 139 socket_addr = 0.0.0.0.
Error = Address already in use
messages when trying to bind to an IPv4 address
when we've already bound to the IPv6 equivalent.
Jeremy.

16 years agoFix the build of the cacheprime VFS module after API changes.
Michael Adam [Thu, 10 Jan 2008 22:40:13 +0000 (23:40 +0100)]
Fix the build of the cacheprime VFS module after API changes.

Sorry, that had escaped my attention.

Michael

16 years ago--enable-libwbclient-shared
Volker Lendecke [Mon, 7 Jan 2008 17:27:10 +0000 (18:27 +0100)]
--enable-libwbclient-shared

This patch adds the configure option --enable-libwbclient-shared that defaults
to yes. If you set --enable-developer=yes, then you can say
--enable-libwbclient-shared=no to avoid problems you might have with the wrong
shared libaries.

Jerry, is this acceptable to you? If yes, please push.

Thanks!

Volker

16 years agoTiny cosmetic fix
Volker Lendecke [Thu, 10 Jan 2008 12:22:51 +0000 (13:22 +0100)]
Tiny cosmetic fix

16 years agoRemove redundant parameter fd from SMB_VFS_WRITE().
Michael Adam [Thu, 10 Jan 2008 14:49:35 +0000 (15:49 +0100)]
Remove redundant parameter fd from SMB_VFS_WRITE().

Michael

16 years agoRemove redundant parameter fd from SMB_VFS_READ().
Michael Adam [Thu, 10 Jan 2008 14:33:51 +0000 (15:33 +0100)]
Remove redundant parameter fd from SMB_VFS_READ().

Michael

16 years agoMove transfer_file and transfer_file_internal to a module of their own.
Michael Adam [Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)]
Move transfer_file and transfer_file_internal to a module of their own.

Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)

Michael

16 years agoReformat some code I just touched.
Michael Adam [Thu, 10 Jan 2008 12:55:46 +0000 (13:55 +0100)]
Reformat some code I just touched.

Michael

16 years agoMake casts to (void *) explicit to remove compiler warnings.
Michael Adam [Thu, 10 Jan 2008 12:55:16 +0000 (13:55 +0100)]
Make casts to (void *) explicit to remove compiler warnings.

Michael

16 years agoFix a really silly typo.
Michael Adam [Thu, 10 Jan 2008 13:18:46 +0000 (14:18 +0100)]
Fix a really silly typo.

Michael

16 years agoCorrectly abstract the transfer_file mechanism with callbacks and void ptrs.
Michael Adam [Thu, 10 Jan 2008 12:30:43 +0000 (13:30 +0100)]
Correctly abstract the transfer_file mechanism with callbacks and void ptrs.

This removes the in_fsp and out_fsp global variables hack from smbd/vfs.c.

Michael

16 years agouse talloc_tos() in share_access_check()
Volker Lendecke [Sun, 6 Jan 2008 13:17:15 +0000 (14:17 +0100)]
use talloc_tos() in share_access_check()

16 years agoSome more talloc_tos()
Volker Lendecke [Sun, 6 Jan 2008 15:15:45 +0000 (16:15 +0100)]
Some more talloc_tos()

16 years agouse talloc_tos in a few more places
Volker Lendecke [Sun, 6 Jan 2008 13:21:25 +0000 (14:21 +0100)]
use talloc_tos in a few more places

16 years agoRemove unused string.
Günther Deschner [Thu, 10 Jan 2008 10:13:23 +0000 (11:13 +0100)]
Remove unused string.

Guenther

16 years agoFix a c++ warning
Volker Lendecke [Thu, 10 Jan 2008 10:35:40 +0000 (11:35 +0100)]
Fix a c++ warning

16 years agotalloc_free_children can only reset pool if it's empty
Volker Lendecke [Thu, 10 Jan 2008 10:35:17 +0000 (11:35 +0100)]
talloc_free_children can only reset pool if it's empty

16 years agoMark talloc_pool memory for valgrind
Volker Lendecke [Thu, 10 Jan 2008 10:34:07 +0000 (11:34 +0100)]
Mark talloc_pool memory for valgrind

16 years agoFix suspicious Makefile line
Volker Lendecke [Thu, 10 Jan 2008 09:55:20 +0000 (10:55 +0100)]
Fix suspicious Makefile line

If @WINBIND_KRB5_LOCATOR@ is not defined, this leads to a line with just one
tab in.

16 years agoForm a proper hierarchy in talloc_stack
Volker Lendecke [Thu, 10 Jan 2008 08:53:51 +0000 (09:53 +0100)]
Form a proper hierarchy in talloc_stack

This way talloc_stackframe() can benefit from a pool put on the stack further
up. No need to remove talloc_stackframe().

16 years agoFixup hot paths - add macro for toupper (c < 0x80).
Jeremy Allison [Thu, 10 Jan 2008 01:32:26 +0000 (17:32 -0800)]
Fixup hot paths - add macro for toupper (c < 0x80).
This now matches 3.0.x on my micro-tests.
Jeremy.

16 years agoMake use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy Allison [Thu, 10 Jan 2008 01:11:04 +0000 (17:11 -0800)]
Make use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy.

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 10 Jan 2008 01:08:20 +0000 (17:08 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoAdd the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy Allison [Thu, 10 Jan 2008 01:07:58 +0000 (17:07 -0800)]
Add the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy.

16 years agoImplement talloc_pool()
Volker Lendecke [Sat, 5 Jan 2008 17:26:54 +0000 (18:26 +0100)]
Implement talloc_pool()

A talloc pool is a chunk of memory that can be used as a context for further
talloc calls. Allocations with the pool as the parent just chew from that
memory by incrementing a pointer. If the talloc pool is full, then we fall back
to the normal system-level malloc(3) to get memory.

The use case for talloc pools is the transient memory that is used for handling
a single SMB request. Incrementing a pointer will be way faster than any malloc
implementation.

There is a downside of this: If you use talloc_steal() to move something out of
the pool, the whole pool memory is kept around until the last object inside the
pool is freed. So if you talloc_free() the pool, it might happen that the
memory is freed later. So don't hang anything off a talloc pool that should
live long.

Volker

16 years agoTry and fix the AIX build.
Michael Adam [Thu, 10 Jan 2008 00:04:47 +0000 (01:04 +0100)]
Try and fix the AIX build.

The __ss_family workaround is in lib/replace/system/network.h ...

Michael

16 years agoEnable building the notify_fam module.
Michael Adam [Wed, 9 Jan 2008 23:45:54 +0000 (00:45 +0100)]
Enable building the notify_fam module.

Found by Timur I. Bakeyev <timur@com.bat.ru>.

Michael

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 22:35:37 +0000 (14:35 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years agoTry and fix the AIX build.
Jeremy Allison [Wed, 9 Jan 2008 22:35:15 +0000 (14:35 -0800)]
Try and fix the AIX build.
Jeremy.

16 years agoEnsure we don't take address of one past buffer.
Jeremy Allison [Wed, 9 Jan 2008 22:35:00 +0000 (14:35 -0800)]
Ensure we don't take address of one past buffer.
Jeremy.

16 years agoFix the max_dead_record calculations
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations

16 years agoTry to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.
Michael Adam [Wed, 9 Jan 2008 22:15:56 +0000 (23:15 +0100)]
Try to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.

Michael

16 years agoFix a memleak found by the IBM checker.
Michael Adam [Wed, 9 Jan 2008 21:25:52 +0000 (22:25 +0100)]
Fix a memleak found by the IBM checker.

Michael

16 years agoFix memleak in ldapsam_rename_sam_account() found by IBM checker.
Michael Adam [Wed, 9 Jan 2008 21:09:55 +0000 (22:09 +0100)]
Fix memleak in ldapsam_rename_sam_account() found by IBM checker.

The check for out of memory was the wrong way round.

Michael

16 years agoAnother attempt to fix builds w/o ldap and/or krb5.
Günther Deschner [Wed, 9 Jan 2008 11:47:13 +0000 (12:47 +0100)]
Another attempt to fix builds w/o ldap and/or krb5.

Guenther

16 years agoRe-run make idl to get even nicer pidl generated server code.
Günther Deschner [Wed, 9 Jan 2008 11:28:44 +0000 (12:28 +0100)]
Re-run make idl to get even nicer pidl generated server code.

Guenther

16 years agoCorrect comment. Default debug level of smbclient is 1, not 0.
Karolin Seeger [Tue, 8 Jan 2008 18:21:26 +0000 (19:21 +0100)]
Correct comment. Default debug level of smbclient is 1, not 0.

16 years agoAttempt to fix the compile of source/utils/net_dns.c
Volker Lendecke [Wed, 9 Jan 2008 10:44:40 +0000 (11:44 +0100)]
Attempt to fix the compile of source/utils/net_dns.c

Jeremy, please check!

16 years agoRe-run make idl. The pidl generated code now fully complies to coding standards.
Günther Deschner [Wed, 9 Jan 2008 10:59:11 +0000 (11:59 +0100)]
Re-run make idl. The pidl generated code now fully complies to coding standards.

Guenther

16 years agoFix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.
Michael Adam [Wed, 9 Jan 2008 10:22:29 +0000 (11:22 +0100)]
Fix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.

Michael

16 years agoReduce stat cache size default
Volker Lendecke [Tue, 8 Jan 2008 09:17:05 +0000 (10:17 +0100)]
Reduce stat cache size default

Now that we have a LRU scheme for the stat cache we can live with a lot less

16 years agoReplace an uninitialized variable
Volker Lendecke [Wed, 9 Jan 2008 09:29:34 +0000 (10:29 +0100)]
Replace an uninitialized variable

Reported by the IBM checker

16 years agoAdd libnet_join_derive_salting_principal().
Günther Deschner [Tue, 8 Jan 2008 17:59:57 +0000 (18:59 +0100)]
Add libnet_join_derive_salting_principal().

Guenther

16 years agoFix build warning for libsmbclient example.
Günther Deschner [Tue, 8 Jan 2008 15:57:16 +0000 (16:57 +0100)]
Fix build warning for libsmbclient example.

Guenther

16 years agogit-ignore generated files under examples/VFS/
Michael Adam [Wed, 9 Jan 2008 01:35:34 +0000 (02:35 +0100)]
git-ignore generated files under examples/VFS/

Michael

16 years agoIgnore test directory.
Michael Adam [Wed, 9 Jan 2008 01:32:56 +0000 (02:32 +0100)]
Ignore test directory.

Michael

16 years agoensure uni_name.buffer is initialised
Volker Lendecke [Wed, 9 Jan 2008 06:59:12 +0000 (07:59 +0100)]
ensure uni_name.buffer is initialised

merge from http://samba.org/~tridge/3_0-ctdb

16 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 06:48:40 +0000 (22:48 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test

16 years ago ensure uni_name.buffer is initialised
Jeremy Allison [Wed, 9 Jan 2008 06:48:22 +0000 (22:48 -0800)]
ensure uni_name.buffer is initialised

    merge from http://samba.org/~tridge/3_0-ctdb

Jeremy.

16 years agoFix CID 461 - resource leak on error.
Jeremy Allison [Wed, 9 Jan 2008 02:51:55 +0000 (18:51 -0800)]
Fix CID 461 - resource leak on error.
Jeremy.

16 years agoFix CID 460 - resource leak on error.
Jeremy Allison [Wed, 9 Jan 2008 02:48:04 +0000 (18:48 -0800)]
Fix CID 460 - resource leak on error.
Jeremy.

16 years agoFix resource leak found by coverity (CID 521).
Jeremy Allison [Wed, 9 Jan 2008 02:44:19 +0000 (18:44 -0800)]
Fix resource leak found by coverity (CID 521).
Jeremy.

16 years agoChange registry_create_admin_token() to return NTSTATUS.
Michael Adam [Wed, 9 Jan 2008 00:17:13 +0000 (01:17 +0100)]
Change registry_create_admin_token() to return NTSTATUS.

Michael

16 years agoMove content of comment.
Michael Adam [Tue, 8 Jan 2008 23:25:27 +0000 (00:25 +0100)]
Move content of comment.

Michael

16 years agoConvert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.
Michael Adam [Tue, 8 Jan 2008 23:11:31 +0000 (00:11 +0100)]
Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.

Michael

16 years agoFix prototype: Add a void to an empty function parameter list.
Michael Adam [Tue, 8 Jan 2008 22:02:50 +0000 (23:02 +0100)]
Fix prototype: Add a void to an empty function parameter list.

Michael

16 years agoDon't leak data.dptr on error path.
Michael Adam [Tue, 8 Jan 2008 20:51:07 +0000 (21:51 +0100)]
Don't leak data.dptr on error path.

Michael

16 years agoExtend a comment.
Michael Adam [Tue, 8 Jan 2008 14:21:08 +0000 (15:21 +0100)]
Extend a comment.

Michael

16 years agoAdd a comment.
Michael Adam [Wed, 9 Jan 2008 00:35:43 +0000 (01:35 +0100)]
Add a comment.

Michael

16 years agoFix talloctort: move size check after referenced ptr check.
Michael Adam [Wed, 9 Jan 2008 00:34:21 +0000 (01:34 +0100)]
Fix talloctort: move size check after referenced ptr check.

Michael

16 years agoSimplify... plus add a debug message.
Jeremy Allison [Wed, 9 Jan 2008 00:08:39 +0000 (16:08 -0800)]
Simplify... plus add a debug message.
Jeremy.

16 years agoCorrectly identify enc/non-enc packets.
Jeremy Allison [Tue, 8 Jan 2008 23:57:08 +0000 (15:57 -0800)]
Correctly identify enc/non-enc packets.
Jeremy.

16 years agoSave one popular malloc
Volker Lendecke [Tue, 8 Jan 2008 22:18:03 +0000 (23:18 +0100)]
Save one popular malloc

16 years agoDon't shrink a talloc area if we have less than 1k to gain
Volker Lendecke [Tue, 8 Jan 2008 21:42:27 +0000 (22:42 +0100)]
Don't shrink a talloc area if we have less than 1k to gain

16 years agoFix returns in void functions.
Michael Adam [Tue, 8 Jan 2008 21:51:21 +0000 (22:51 +0100)]
Fix returns in void functions.

Michael

16 years agoFix examples/VFS after VFS API changes.
Michael Adam [Tue, 8 Jan 2008 21:13:25 +0000 (22:13 +0100)]
Fix examples/VFS after VFS API changes.

Michael

16 years agoOnly realloc the talloc stack if necessary
Volker Lendecke [Tue, 8 Jan 2008 21:12:35 +0000 (22:12 +0100)]
Only realloc the talloc stack if necessary

16 years agoAllocate dirp->name_cache on demand only
Volker Lendecke [Tue, 8 Jan 2008 20:45:21 +0000 (21:45 +0100)]
Allocate dirp->name_cache on demand only

16 years agoMove the DNS tsig update to using struct sockaddr_storage
Jeremy Allison [Tue, 8 Jan 2008 21:11:12 +0000 (13:11 -0800)]
Move the DNS tsig update to using struct sockaddr_storage
from struct in_addr. Still only does IPv4 updates but now
it'll be easy to add IPv6 when we have time.
Jeremy.

16 years agoPedantic cosmetics: rerun make idl.
Günther Deschner [Tue, 8 Jan 2008 17:07:55 +0000 (18:07 +0100)]
Pedantic cosmetics: rerun make idl.

Guenther