Jeremy Allison [Sat, 12 Jan 2008 06:38:42 +0000 (22:38 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Günther Deschner [Sat, 12 Jan 2008 01:24:55 +0000 (02:24 +0100)]
Fix some indents.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:22:44 +0000 (02:22 +0100)]
Call dsgetdcname when we have no specific dc defined for joining.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:20:33 +0000 (02:20 +0100)]
Fix some error strings in libnet_join.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:19:21 +0000 (02:19 +0100)]
Add appropriate error code when pre-creating accounts in ous isnt supported by DC.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:17:10 +0000 (02:17 +0100)]
For libnet_join error string functions, make sure not to overwrite last status string.
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:15:42 +0000 (02:15 +0100)]
Merge all ads related calls in libnet_join_post_processing_ads().
Guenther
Günther Deschner [Sat, 12 Jan 2008 01:10:17 +0000 (02:10 +0100)]
Use WITH_ADS define in libnet_join, hopefully not breaking the build.
Guenther
Günther Deschner [Sat, 12 Jan 2008 00:28:20 +0000 (01:28 +0100)]
Auto-add missing shares in libnet_conf_set_parameter().
Michael, please have a look.
Guenther
Günther Deschner [Fri, 11 Jan 2008 17:51:15 +0000 (18:51 +0100)]
Add debug bool flag for libnetjoin ctx.
Guenther
Günther Deschner [Fri, 11 Jan 2008 17:49:20 +0000 (18:49 +0100)]
Use domain_is_ad one more time in libnetjoin.
Guenther
Jeremy Allison [Fri, 11 Jan 2008 23:08:37 +0000 (15:08 -0800)]
Sync tdb with the tdb changes in ctdb. Spoke to tridge about
this. Fixes insidious problem with order n^2 freelist merging.
Jeremy.
Michael Adam [Fri, 11 Jan 2008 18:02:26 +0000 (19:02 +0100)]
Remove code accidentially submittet with last commit
83aed537c16f63.
This is ist still in preparation and will follow soon. Soory!
Michael
Michael Adam [Fri, 11 Jan 2008 17:55:20 +0000 (18:55 +0100)]
Fix panic in "net conf": Fix logic in error condition.
Michael
Günther Deschner [Fri, 11 Jan 2008 17:46:41 +0000 (18:46 +0100)]
Fix a build warning.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:32:20 +0000 (15:32 +0100)]
As long as DsGetDcName is not part of libnetapi, lowercase the fn name.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:28:24 +0000 (15:28 +0100)]
Fix libnetapi error string callers.
Guenther
Günther Deschner [Fri, 11 Jan 2008 14:03:31 +0000 (15:03 +0100)]
Remove '\n' from error strings in libnet_join context.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:50:10 +0000 (14:50 +0100)]
Set error string when ads_leave_realm() has failed in libnetjoin.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:47:52 +0000 (14:47 +0100)]
Include some basic headers in netapi.h.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:47:23 +0000 (14:47 +0100)]
Refactor libnetapi error string functions a bit.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:43:56 +0000 (14:43 +0100)]
Ignore result of libnet_conf_delete_parameter here, as realm may be not there.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:42:48 +0000 (14:42 +0100)]
Remove some more references to global_myname() in libnet_join.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:41:34 +0000 (14:41 +0100)]
Use domain_is_ad bool.
Guenther
Günther Deschner [Fri, 11 Jan 2008 13:40:06 +0000 (14:40 +0100)]
Add domain_is_ad bool to libnetjoin ctx.
Guenther
Jeremy Allison [Fri, 11 Jan 2008 00:36:05 +0000 (16:36 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 11 Jan 2008 00:35:54 +0000 (16:35 -0800)]
Don't switch user contexts unless you have to. Saves
a bunch of syscalls on close. Noticed by Volker.
Jeremy.
Michael Adam [Fri, 11 Jan 2008 00:26:54 +0000 (01:26 +0100)]
Combine fsp and tofd to tofsp in SMB_VFS_RECVFILE().
Michael
Michael Adam [Thu, 10 Jan 2008 23:56:06 +0000 (00:56 +0100)]
Remove now redundant parameter fd from prime_cache().
Michael
Michael Adam [Thu, 10 Jan 2008 23:51:19 +0000 (00:51 +0100)]
Combine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().
Michael
Jeremy Allison [Thu, 10 Jan 2008 23:15:01 +0000 (15:15 -0800)]
Don't print out debug messages at level 0 if we can't
bind to a socket if we've already bound to one (this
prevents :
bind failed on port 445 socket_addr = 0.0.0.0.
Error = Address already in use
bind failed on port 139 socket_addr = 0.0.0.0.
Error = Address already in use
messages when trying to bind to an IPv4 address
when we've already bound to the IPv6 equivalent.
Jeremy.
Michael Adam [Thu, 10 Jan 2008 22:40:13 +0000 (23:40 +0100)]
Fix the build of the cacheprime VFS module after API changes.
Sorry, that had escaped my attention.
Michael
Volker Lendecke [Mon, 7 Jan 2008 17:27:10 +0000 (18:27 +0100)]
--enable-libwbclient-shared
This patch adds the configure option --enable-libwbclient-shared that defaults
to yes. If you set --enable-developer=yes, then you can say
--enable-libwbclient-shared=no to avoid problems you might have with the wrong
shared libaries.
Jerry, is this acceptable to you? If yes, please push.
Thanks!
Volker
Volker Lendecke [Thu, 10 Jan 2008 12:22:51 +0000 (13:22 +0100)]
Tiny cosmetic fix
Michael Adam [Thu, 10 Jan 2008 14:49:35 +0000 (15:49 +0100)]
Remove redundant parameter fd from SMB_VFS_WRITE().
Michael
Michael Adam [Thu, 10 Jan 2008 14:33:51 +0000 (15:33 +0100)]
Remove redundant parameter fd from SMB_VFS_READ().
Michael
Michael Adam [Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)]
Move transfer_file and transfer_file_internal to a module of their own.
Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:46 +0000 (13:55 +0100)]
Reformat some code I just touched.
Michael
Michael Adam [Thu, 10 Jan 2008 12:55:16 +0000 (13:55 +0100)]
Make casts to (void *) explicit to remove compiler warnings.
Michael
Michael Adam [Thu, 10 Jan 2008 13:18:46 +0000 (14:18 +0100)]
Fix a really silly typo.
Michael
Michael Adam [Thu, 10 Jan 2008 12:30:43 +0000 (13:30 +0100)]
Correctly abstract the transfer_file mechanism with callbacks and void ptrs.
This removes the in_fsp and out_fsp global variables hack from smbd/vfs.c.
Michael
Volker Lendecke [Sun, 6 Jan 2008 13:17:15 +0000 (14:17 +0100)]
use talloc_tos() in share_access_check()
Volker Lendecke [Sun, 6 Jan 2008 15:15:45 +0000 (16:15 +0100)]
Some more talloc_tos()
Volker Lendecke [Sun, 6 Jan 2008 13:21:25 +0000 (14:21 +0100)]
use talloc_tos in a few more places
Günther Deschner [Thu, 10 Jan 2008 10:13:23 +0000 (11:13 +0100)]
Remove unused string.
Guenther
Volker Lendecke [Thu, 10 Jan 2008 10:35:40 +0000 (11:35 +0100)]
Fix a c++ warning
Volker Lendecke [Thu, 10 Jan 2008 10:35:17 +0000 (11:35 +0100)]
talloc_free_children can only reset pool if it's empty
Volker Lendecke [Thu, 10 Jan 2008 10:34:07 +0000 (11:34 +0100)]
Mark talloc_pool memory for valgrind
Volker Lendecke [Thu, 10 Jan 2008 09:55:20 +0000 (10:55 +0100)]
Fix suspicious Makefile line
If @WINBIND_KRB5_LOCATOR@ is not defined, this leads to a line with just one
tab in.
Volker Lendecke [Thu, 10 Jan 2008 08:53:51 +0000 (09:53 +0100)]
Form a proper hierarchy in talloc_stack
This way talloc_stackframe() can benefit from a pool put on the stack further
up. No need to remove talloc_stackframe().
Jeremy Allison [Thu, 10 Jan 2008 01:32:26 +0000 (17:32 -0800)]
Fixup hot paths - add macro for toupper (c < 0x80).
This now matches 3.0.x on my micro-tests.
Jeremy.
Jeremy Allison [Thu, 10 Jan 2008 01:11:04 +0000 (17:11 -0800)]
Make use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy.
Jeremy Allison [Thu, 10 Jan 2008 01:08:20 +0000 (17:08 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 10 Jan 2008 01:07:58 +0000 (17:07 -0800)]
Add the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy.
Volker Lendecke [Sat, 5 Jan 2008 17:26:54 +0000 (18:26 +0100)]
Implement talloc_pool()
A talloc pool is a chunk of memory that can be used as a context for further
talloc calls. Allocations with the pool as the parent just chew from that
memory by incrementing a pointer. If the talloc pool is full, then we fall back
to the normal system-level malloc(3) to get memory.
The use case for talloc pools is the transient memory that is used for handling
a single SMB request. Incrementing a pointer will be way faster than any malloc
implementation.
There is a downside of this: If you use talloc_steal() to move something out of
the pool, the whole pool memory is kept around until the last object inside the
pool is freed. So if you talloc_free() the pool, it might happen that the
memory is freed later. So don't hang anything off a talloc pool that should
live long.
Volker
Michael Adam [Thu, 10 Jan 2008 00:04:47 +0000 (01:04 +0100)]
Try and fix the AIX build.
The __ss_family workaround is in lib/replace/system/network.h ...
Michael
Michael Adam [Wed, 9 Jan 2008 23:45:54 +0000 (00:45 +0100)]
Enable building the notify_fam module.
Found by Timur I. Bakeyev <timur@com.bat.ru>.
Michael
Jeremy Allison [Wed, 9 Jan 2008 22:35:37 +0000 (14:35 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 22:35:15 +0000 (14:35 -0800)]
Try and fix the AIX build.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 22:35:00 +0000 (14:35 -0800)]
Ensure we don't take address of one past buffer.
Jeremy.
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations
Michael Adam [Wed, 9 Jan 2008 22:15:56 +0000 (23:15 +0100)]
Try to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.
Michael
Michael Adam [Wed, 9 Jan 2008 21:25:52 +0000 (22:25 +0100)]
Fix a memleak found by the IBM checker.
Michael
Michael Adam [Wed, 9 Jan 2008 21:09:55 +0000 (22:09 +0100)]
Fix memleak in ldapsam_rename_sam_account() found by IBM checker.
The check for out of memory was the wrong way round.
Michael
Günther Deschner [Wed, 9 Jan 2008 11:47:13 +0000 (12:47 +0100)]
Another attempt to fix builds w/o ldap and/or krb5.
Guenther
Günther Deschner [Wed, 9 Jan 2008 11:28:44 +0000 (12:28 +0100)]
Re-run make idl to get even nicer pidl generated server code.
Guenther
Karolin Seeger [Tue, 8 Jan 2008 18:21:26 +0000 (19:21 +0100)]
Correct comment. Default debug level of smbclient is 1, not 0.
Volker Lendecke [Wed, 9 Jan 2008 10:44:40 +0000 (11:44 +0100)]
Attempt to fix the compile of source/utils/net_dns.c
Jeremy, please check!
Günther Deschner [Wed, 9 Jan 2008 10:59:11 +0000 (11:59 +0100)]
Re-run make idl. The pidl generated code now fully complies to coding standards.
Guenther
Michael Adam [Wed, 9 Jan 2008 10:22:29 +0000 (11:22 +0100)]
Fix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.
Michael
Volker Lendecke [Tue, 8 Jan 2008 09:17:05 +0000 (10:17 +0100)]
Reduce stat cache size default
Now that we have a LRU scheme for the stat cache we can live with a lot less
Volker Lendecke [Wed, 9 Jan 2008 09:29:34 +0000 (10:29 +0100)]
Replace an uninitialized variable
Reported by the IBM checker
Günther Deschner [Tue, 8 Jan 2008 17:59:57 +0000 (18:59 +0100)]
Add libnet_join_derive_salting_principal().
Guenther
Günther Deschner [Tue, 8 Jan 2008 15:57:16 +0000 (16:57 +0100)]
Fix build warning for libsmbclient example.
Guenther
Michael Adam [Wed, 9 Jan 2008 01:35:34 +0000 (02:35 +0100)]
git-ignore generated files under examples/VFS/
Michael
Michael Adam [Wed, 9 Jan 2008 01:32:56 +0000 (02:32 +0100)]
Ignore test directory.
Michael
Volker Lendecke [Wed, 9 Jan 2008 06:59:12 +0000 (07:59 +0100)]
ensure uni_name.buffer is initialised
merge from http://samba.org/~tridge/3_0-ctdb
Jeremy Allison [Wed, 9 Jan 2008 06:48:40 +0000 (22:48 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 06:48:22 +0000 (22:48 -0800)]
ensure uni_name.buffer is initialised
merge from http://samba.org/~tridge/3_0-ctdb
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 02:51:55 +0000 (18:51 -0800)]
Fix CID 461 - resource leak on error.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 02:48:04 +0000 (18:48 -0800)]
Fix CID 460 - resource leak on error.
Jeremy.
Jeremy Allison [Wed, 9 Jan 2008 02:44:19 +0000 (18:44 -0800)]
Fix resource leak found by coverity (CID 521).
Jeremy.
Michael Adam [Wed, 9 Jan 2008 00:17:13 +0000 (01:17 +0100)]
Change registry_create_admin_token() to return NTSTATUS.
Michael
Michael Adam [Tue, 8 Jan 2008 23:25:27 +0000 (00:25 +0100)]
Move content of comment.
Michael
Michael Adam [Tue, 8 Jan 2008 23:11:31 +0000 (00:11 +0100)]
Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.
Michael
Michael Adam [Tue, 8 Jan 2008 22:02:50 +0000 (23:02 +0100)]
Fix prototype: Add a void to an empty function parameter list.
Michael
Michael Adam [Tue, 8 Jan 2008 20:51:07 +0000 (21:51 +0100)]
Don't leak data.dptr on error path.
Michael
Michael Adam [Tue, 8 Jan 2008 14:21:08 +0000 (15:21 +0100)]
Extend a comment.
Michael
Michael Adam [Wed, 9 Jan 2008 00:35:43 +0000 (01:35 +0100)]
Add a comment.
Michael
Michael Adam [Wed, 9 Jan 2008 00:34:21 +0000 (01:34 +0100)]
Fix talloctort: move size check after referenced ptr check.
Michael
Jeremy Allison [Wed, 9 Jan 2008 00:08:39 +0000 (16:08 -0800)]
Simplify... plus add a debug message.
Jeremy.
Jeremy Allison [Tue, 8 Jan 2008 23:57:08 +0000 (15:57 -0800)]
Correctly identify enc/non-enc packets.
Jeremy.
Volker Lendecke [Tue, 8 Jan 2008 22:18:03 +0000 (23:18 +0100)]
Save one popular malloc
Volker Lendecke [Tue, 8 Jan 2008 21:42:27 +0000 (22:42 +0100)]
Don't shrink a talloc area if we have less than 1k to gain
Michael Adam [Tue, 8 Jan 2008 21:51:21 +0000 (22:51 +0100)]
Fix returns in void functions.
Michael
Michael Adam [Tue, 8 Jan 2008 21:13:25 +0000 (22:13 +0100)]
Fix examples/VFS after VFS API changes.
Michael
Volker Lendecke [Tue, 8 Jan 2008 21:12:35 +0000 (22:12 +0100)]
Only realloc the talloc stack if necessary
Volker Lendecke [Tue, 8 Jan 2008 20:45:21 +0000 (21:45 +0100)]
Allocate dirp->name_cache on demand only
Jeremy Allison [Tue, 8 Jan 2008 21:11:12 +0000 (13:11 -0800)]
Move the DNS tsig update to using struct sockaddr_storage
from struct in_addr. Still only does IPv4 updates but now
it'll be easy to add IPv6 when we have time.
Jeremy.
Günther Deschner [Tue, 8 Jan 2008 17:07:55 +0000 (18:07 +0100)]
Pedantic cosmetics: rerun make idl.
Guenther