kamenim/samba.git
13 years agos3: Remove smbd_messaging_context() from make_connection_snum()
Volker Lendecke [Sun, 4 Jul 2010 17:51:43 +0000 (19:51 +0200)]
s3: Remove smbd_messaging_context() from make_connection_snum()

13 years agos3: Remove smbd_messaging_context() from reprocess_blocked_smb2_lock()
Volker Lendecke [Sun, 4 Jul 2010 17:50:35 +0000 (19:50 +0200)]
s3: Remove smbd_messaging_context() from reprocess_blocked_smb2_lock()

13 years agos3: Remove smbd_messaging_context() from remove_pending_lock()
Volker Lendecke [Sun, 4 Jul 2010 17:50:25 +0000 (19:50 +0200)]
s3: Remove smbd_messaging_context() from remove_pending_lock()

13 years agos3: Remove smbd_messaging_context() from push_blocking_lock_request_smb2()
Volker Lendecke [Sun, 4 Jul 2010 17:47:45 +0000 (19:47 +0200)]
s3: Remove smbd_messaging_context() from push_blocking_lock_request_smb2()

13 years agos3: Remove procid_self() from irix_oplocks_read_fde_handler()
Volker Lendecke [Sun, 4 Jul 2010 17:47:02 +0000 (19:47 +0200)]
s3: Remove procid_self() from irix_oplocks_read_fde_handler()

13 years agos3: Remove smbd_messaging_context() from smb_set_posix_lock()
Volker Lendecke [Sun, 4 Jul 2010 17:46:15 +0000 (19:46 +0200)]
s3: Remove smbd_messaging_context() from smb_set_posix_lock()

13 years agos3: Remove smbd_messaging_context() from linux_oplock_signal_handler()
Volker Lendecke [Sun, 4 Jul 2010 17:44:57 +0000 (19:44 +0200)]
s3: Remove smbd_messaging_context() from linux_oplock_signal_handler()

13 years agos3: Remove procid_self() from blocking_lock_cancel_smb1()
Volker Lendecke [Sun, 4 Jul 2010 16:46:27 +0000 (18:46 +0200)]
s3: Remove procid_self() from blocking_lock_cancel_smb1()

13 years agos3: Remove procid_self() from process_blocking_lock_queue()
Volker Lendecke [Sun, 4 Jul 2010 16:45:15 +0000 (18:45 +0200)]
s3: Remove procid_self() from process_blocking_lock_queue()

13 years agos3: Remove procid_self() from remove_pending_lock_requests_by_mid_smb1()
Volker Lendecke [Sun, 4 Jul 2010 16:44:46 +0000 (18:44 +0200)]
s3: Remove procid_self() from remove_pending_lock_requests_by_mid_smb1()

13 years agos3: Remove procid_self() from cancel_pending_lock_requests_by_fid()
Volker Lendecke [Sun, 4 Jul 2010 16:44:14 +0000 (18:44 +0200)]
s3: Remove procid_self() from cancel_pending_lock_requests_by_fid()

13 years agos3: Remove procid_self() from generic_blocking_lock_error()
Volker Lendecke [Sun, 4 Jul 2010 16:43:39 +0000 (18:43 +0200)]
s3: Remove procid_self() from generic_blocking_lock_error()

13 years agos3: Remove procid_self() from push_blocking_lock_request()
Volker Lendecke [Sun, 4 Jul 2010 16:42:55 +0000 (18:42 +0200)]
s3: Remove procid_self() from push_blocking_lock_request()

13 years agos3: Remove smbd_messaging_context() from blocking_lock_cancel_smb1()
Volker Lendecke [Sun, 4 Jul 2010 16:40:57 +0000 (18:40 +0200)]
s3: Remove smbd_messaging_context() from blocking_lock_cancel_smb1()

13 years agos3: Remove smbd_messaging_context() from process_trans2()
Volker Lendecke [Sun, 4 Jul 2010 16:40:40 +0000 (18:40 +0200)]
s3: Remove smbd_messaging_context() from process_trans2()

13 years agos3: Remove smbd_messaging_context() from process_lockingX()
Volker Lendecke [Sun, 4 Jul 2010 16:39:57 +0000 (18:39 +0200)]
s3: Remove smbd_messaging_context() from process_lockingX()

13 years agos3: Remove smbd_messaging_context() from reply_lockingX_error()
Volker Lendecke [Sun, 4 Jul 2010 16:39:31 +0000 (18:39 +0200)]
s3: Remove smbd_messaging_context() from reply_lockingX_error()

13 years agos3: Remove smbd_messaging_context() from push_blocking_lock_request()
Volker Lendecke [Sun, 4 Jul 2010 16:38:12 +0000 (18:38 +0200)]
s3: Remove smbd_messaging_context() from push_blocking_lock_request()

13 years agos3: Remove smbd_messaging_context() from contend_level2_oplocks_begin_default()
Volker Lendecke [Sun, 4 Jul 2010 16:35:06 +0000 (18:35 +0200)]
s3: Remove smbd_messaging_context() from contend_level2_oplocks_begin_default()

13 years agos3: Remove smbd_messaging_context() from reply_to_oplock_break_requests()
Volker Lendecke [Sun, 4 Jul 2010 16:34:31 +0000 (18:34 +0200)]
s3: Remove smbd_messaging_context() from reply_to_oplock_break_requests()

13 years agos3: Remove smbd_messaging_context() from smbd_do_locking()
Volker Lendecke [Sun, 4 Jul 2010 16:32:17 +0000 (18:32 +0200)]
s3: Remove smbd_messaging_context() from smbd_do_locking()

13 years agos3: Remove smbd_messaging_context() from rename_open_files()
Volker Lendecke [Sun, 4 Jul 2010 16:31:41 +0000 (18:31 +0200)]
s3: Remove smbd_messaging_context() from rename_open_files()

13 years agos3: Remove smbd_messaging_context() from reply_unlock()
Volker Lendecke [Sun, 4 Jul 2010 16:31:09 +0000 (18:31 +0200)]
s3: Remove smbd_messaging_context() from reply_unlock()

13 years agos3: Remove smbd_messaging_context() from reply_lock()
Volker Lendecke [Sun, 4 Jul 2010 16:30:48 +0000 (18:30 +0200)]
s3: Remove smbd_messaging_context() from reply_lock()

13 years agos3: Remove smbd_messaging_context() from reply_writeunlock()
Volker Lendecke [Sun, 4 Jul 2010 16:30:08 +0000 (18:30 +0200)]
s3: Remove smbd_messaging_context() from reply_writeunlock()

13 years agos3: Remove smbd_messaging_context() from reply_lockread()
Volker Lendecke [Sun, 4 Jul 2010 16:28:53 +0000 (18:28 +0200)]
s3: Remove smbd_messaging_context() from reply_lockread()

13 years agos3: Remove smbd_messaging_context() from send_break_message()
Volker Lendecke [Sun, 4 Jul 2010 16:28:04 +0000 (18:28 +0200)]
s3: Remove smbd_messaging_context() from send_break_message()

13 years agos3: Remove smbd_messaging_context() from exit_server_common()
Volker Lendecke [Sun, 4 Jul 2010 16:26:57 +0000 (18:26 +0200)]
s3: Remove smbd_messaging_context() from exit_server_common()

13 years agos3: Remove smbd_messaging_context() from close_normal_file()
Volker Lendecke [Sun, 4 Jul 2010 16:26:14 +0000 (18:26 +0200)]
s3: Remove smbd_messaging_context() from close_normal_file()

13 years agos3: Remove smbd_messaging_context() from notify_deferred_opens()
Volker Lendecke [Sun, 4 Jul 2010 16:25:02 +0000 (18:25 +0200)]
s3: Remove smbd_messaging_context() from notify_deferred_opens()

13 years agos3: Remove procid_self() from fill_share_mode_entry()
Volker Lendecke [Sun, 4 Jul 2010 16:20:11 +0000 (18:20 +0200)]
s3: Remove procid_self() from fill_share_mode_entry()

13 years agos3: Remove procid_self() from init_strict_lock_struct()
Volker Lendecke [Sun, 4 Jul 2010 16:18:58 +0000 (18:18 +0200)]
s3: Remove procid_self() from init_strict_lock_struct()

13 years agos3: Remove procid_self() from make_connection_snum()
Volker Lendecke [Sun, 4 Jul 2010 16:17:36 +0000 (18:17 +0200)]
s3: Remove procid_self() from make_connection_snum()

13 years agos3: Remove procid_self() from claim_connection()
Volker Lendecke [Sun, 4 Jul 2010 16:15:36 +0000 (18:15 +0200)]
s3: Remove procid_self() from claim_connection()

13 years agos3: Remove NULL checks from claim_connection()
Volker Lendecke [Sun, 4 Jul 2010 16:12:24 +0000 (18:12 +0200)]
s3: Remove NULL checks from claim_connection()

Nowadays this is only called from make_connection_snum() where we always
provide a connection_struct.

13 years agos3: Remove procid_self() from push_blocking_lock_request_smb2()
Volker Lendecke [Sun, 4 Jul 2010 16:09:59 +0000 (18:09 +0200)]
s3: Remove procid_self() from push_blocking_lock_request_smb2()

13 years agos3: Remove procid_self() from reply_negprot()
Volker Lendecke [Sun, 4 Jul 2010 16:08:16 +0000 (18:08 +0200)]
s3: Remove procid_self() from reply_negprot()

13 years agos3: Remove procid_self() from break_kernel_oplock()
Volker Lendecke [Sun, 4 Jul 2010 16:07:29 +0000 (18:07 +0200)]
s3: Remove procid_self() from break_kernel_oplock()

13 years agos3: Remove procid_self() from session_claim()
Volker Lendecke [Sun, 4 Jul 2010 16:06:26 +0000 (18:06 +0200)]
s3: Remove procid_self() from session_claim()

13 years agos3: Remove procid_self() from exit_server_common
Volker Lendecke [Sun, 4 Jul 2010 16:06:01 +0000 (18:06 +0200)]
s3: Remove procid_self() from exit_server_common

13 years agos3: Add sconn_server_id()
Volker Lendecke [Sun, 4 Jul 2010 16:02:36 +0000 (18:02 +0200)]
s3: Add sconn_server_id()

13 years agos3: Add missing prototype for smb2_opcode_name
Volker Lendecke [Sun, 4 Jul 2010 16:02:19 +0000 (18:02 +0200)]
s3: Add missing prototype for smb2_opcode_name

13 years agos3: Add messaging_server_id
Volker Lendecke [Sun, 4 Jul 2010 15:57:57 +0000 (17:57 +0200)]
s3: Add messaging_server_id

13 years agos3: Add msg_ctx to smbd_server_connection
Volker Lendecke [Sun, 4 Jul 2010 15:50:04 +0000 (17:50 +0200)]
s3: Add msg_ctx to smbd_server_connection

It would be obvious to initialize this in smbd_init_globals(), but there the
messaging_context can't be initialized yet because we don't have smb.conf
loaded yet.

13 years agos3:Fix a bogus uninitialized variable warning
Volker Lendecke [Sun, 4 Jul 2010 15:49:30 +0000 (17:49 +0200)]
s3:Fix a bogus uninitialized variable warning

13 years agos3: Pass procid_self() explicitly to messaging_ctdbd_connection()
Volker Lendecke [Sun, 4 Jul 2010 14:54:04 +0000 (16:54 +0200)]
s3: Pass procid_self() explicitly to messaging_ctdbd_connection()

13 years agos3: Create a unique id for the smbd parent
Volker Lendecke [Sun, 4 Jul 2010 14:51:06 +0000 (16:51 +0200)]
s3: Create a unique id for the smbd parent

13 years agos3: Keep the connections.tdb data format fixed
Volker Lendecke [Mon, 5 Jul 2010 08:05:27 +0000 (10:05 +0200)]
s3: Keep the connections.tdb data format fixed

At Simo's request, we can not change internal databases anymore. Sorry for not
respecting this policy.

13 years agoChanged passwords.py to use the correct account as acl checks now pass.
Nadezhda Ivanova [Sun, 4 Jul 2010 21:20:37 +0000 (00:20 +0300)]
Changed passwords.py to use the correct account as acl checks now pass.

13 years agos4-dsdb: Implementation of User-Change-Password and User-Force-Password-Change
Nadezhda Ivanova [Sun, 4 Jul 2010 21:17:38 +0000 (00:17 +0300)]
s4-dsdb: Implementation of User-Change-Password and User-Force-Password-Change

    These CARs need to be checked on password change and password reset operations.
    Apparently the password attributes are not influenced by Write Property.
    Single detele operations and modifications of dBCSPwd are let through to the
    password_hash module. This is determined experimentally.

13 years agos4:subtree_rename LDB module - Cosmetic fixes
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 08:41:17 +0000 (10:41 +0200)]
s4:subtree_rename LDB module - Cosmetic fixes

13 years agos4:subtree_delete LDB module - fix comments and add my copyright
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 08:23:41 +0000 (10:23 +0200)]
s4:subtree_delete LDB module - fix comments and add my copyright

(I've introduced the subtree delete mechanism)

13 years agos4:wb_cmd_list_groups.c - don't crash when we don't get any group at all
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 19:22:28 +0000 (21:22 +0200)]
s4:wb_cmd_list_groups.c - don't crash when we don't get any group at all

13 years agos4:wb_cmd_list_groups.c - indentation and comment fixes
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 19:19:36 +0000 (21:19 +0200)]
s4:wb_cmd_list_groups.c - indentation and comment fixes

13 years agos4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operations
Matthias Dieter Wallnöfer [Sun, 4 Jul 2010 18:04:28 +0000 (20:04 +0200)]
s4:libnet - add missing "talloc_free"s for "c" contexts on "recv" operations

13 years agos3: Remove an unused variable -- thanks, metze!
Volker Lendecke [Sun, 4 Jul 2010 18:04:55 +0000 (20:04 +0200)]
s3: Remove an unused variable -- thanks, metze!

13 years agos3: Remove unused msg_flags from connections.tdb
Volker Lendecke [Sun, 4 Jul 2010 18:45:43 +0000 (20:45 +0200)]
s3: Remove unused msg_flags from connections.tdb

This breaks rolling code upgrade!

13 years agos3: Replace register_message_flags() with serverid_register_msg_flags()
Volker Lendecke [Sun, 4 Jul 2010 18:40:46 +0000 (20:40 +0200)]
s3: Replace register_message_flags() with serverid_register_msg_flags()

message_send_all is now done by walking the serverid.tdb, not the
connections.tdb anymore.

Günther, Simo, please check!

13 years agos3: Use msg_ctx->id in messaging
Volker Lendecke [Sun, 4 Jul 2010 14:41:51 +0000 (16:41 +0200)]
s3: Use msg_ctx->id in messaging

This removes some references to procid_self() deep inside the code

13 years agos3: Pass the new server_id through reinit_after_fork
Volker Lendecke [Sun, 4 Jul 2010 14:28:13 +0000 (16:28 +0200)]
s3: Pass the new server_id through reinit_after_fork

13 years agos3: Re-initialize the server_id in messaging_reinit
Volker Lendecke [Sun, 4 Jul 2010 14:18:12 +0000 (16:18 +0200)]
s3: Re-initialize the server_id in messaging_reinit

13 years agos3: Fix some type-punned warnings
Volker Lendecke [Sun, 4 Jul 2010 14:09:09 +0000 (16:09 +0200)]
s3: Fix some type-punned warnings

13 years agos3: Fix some nested extern warnings
Volker Lendecke [Sun, 4 Jul 2010 14:08:59 +0000 (16:08 +0200)]
s3: Fix some nested extern warnings

13 years agos3: Remove serverid_[de]register_self
Volker Lendecke [Sun, 4 Jul 2010 14:08:03 +0000 (16:08 +0200)]
s3: Remove serverid_[de]register_self

This removes some deep references to procid_self()

13 years agos3: ALWAYS run make test before checkin ....
Volker Lendecke [Sun, 4 Jul 2010 12:59:23 +0000 (14:59 +0200)]
s3: ALWAYS run make test before checkin ....

13 years agos3: Slight reshaping of server_exists_parse
Volker Lendecke [Sun, 4 Jul 2010 12:35:05 +0000 (14:35 +0200)]
s3: Slight reshaping of server_exists_parse

Doing a copy and then do the compare is a bit pointless, use memcmp

13 years agos3: Don't attempt to deregister from serverid twice
Volker Lendecke [Sun, 4 Jul 2010 11:46:48 +0000 (13:46 +0200)]
s3: Don't attempt to deregister from serverid twice

The parent has to take care of crashed child processes anyway, so we don't have
to clean up in the child

13 years agos3: Fix bug 7338, smbget skips leading slash when using a custom outputfile
Volker Lendecke [Sun, 4 Jul 2010 09:32:50 +0000 (11:32 +0200)]
s3: Fix bug 7338, smbget skips leading slash when using a custom outputfile

13 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 4 Jul 2010 09:02:21 +0000 (11:02 +0200)]
s3: Fix some nonempty blank lines

13 years agos3: Fix bug 7336: Enable idmap_passdb module build as shared
Volker Lendecke [Sun, 4 Jul 2010 08:01:42 +0000 (10:01 +0200)]
s3: Fix bug 7336: Enable idmap_passdb module build as shared

13 years agowbinfo: Fix error messages
Volker Lendecke [Sat, 3 Jul 2010 20:41:23 +0000 (22:41 +0200)]
wbinfo: Fix error messages

13 years agos4:torture/rpc/samlogon.c - strip trailing whitespaces
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 19:09:06 +0000 (21:09 +0200)]
s4:torture/rpc/samlogon.c - strip trailing whitespaces

13 years agos4:torture/rpc/samlogon.c - provide a function which sets and afterwards resets the...
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 19:04:47 +0000 (21:04 +0200)]
s4:torture/rpc/samlogon.c - provide a function which sets and afterwards resets the minimum password age

This is needed since we on s4 do now use the Windows Server standard of 1 day.

13 years agos4:kinit blackbox test - set/reset also here the "minPwdAge"
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 13:52:00 +0000 (15:52 +0200)]
s4:kinit blackbox test - set/reset also here the "minPwdAge"

13 years agos4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" request
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 13:37:45 +0000 (15:37 +0200)]
s4:dsdb/tests/python/ldap_schema.py - remove a now useless "schemaUpdateNow" request

"schemaUpdateNow" on s4 is now a non-op and therefore not strictly needed anymore.

13 years agos4:urgent_replication.py test - remove unneeded "relax" control parameters
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:52:18 +0000 (14:52 +0200)]
s4:urgent_replication.py test - remove unneeded "relax" control parameters

13 years agos4:schema_load LDB module - fix a segfault condition on schema refresh
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:33:23 +0000 (14:33 +0200)]
s4:schema_load LDB module - fix a segfault condition on schema refresh

The schema refresh operation itself starts requests from the top of the LDB
modules stack (see call "dsdb_schema_set_attributes" - search operations).
This doesn't work well when these do perform "dsdb_get_schema" calls. Since the
new schema isn't marked as "refreshed" atm (but in fact it still is - we didn't
terminate the reload/refresh yet) we could perform other calls to
"dsdb_schema_refresh" and run into serious trouble (segfault).

13 years agos4:schema_set.c - Fix a comment
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:07:44 +0000 (14:07 +0200)]
s4:schema_set.c - Fix a comment

13 years agos4:dsdb_schema_set_attributes - remove unneeded filter criterias
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 12:05:04 +0000 (14:05 +0200)]
s4:dsdb_schema_set_attributes - remove unneeded filter criterias

We already choose the right entry by specifying the right basedn with scope
"LDB_SCOPE_BASE".

13 years agos4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:47:46 +0000 (12:47 +0200)]
s4:dsdb_module_load_partition_usn - check for "res->count" equal/unequal to 1

13 years agos4:schema_set.c - fix typo
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:36:34 +0000 (12:36 +0200)]
s4:schema_set.c - fix typo

13 years agos4:schema_load.c - jump to "failed" on an error condition
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 10:35:16 +0000 (12:35 +0200)]
s4:schema_load.c - jump to "failed" on an error condition

13 years agos4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right value
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 08:56:14 +0000 (10:56 +0200)]
s4:setup/provision_basedn_modify.ldif - set "minPwdAge" to the right value

Now we should have fixed all password related tests to cooperate with this value

13 years agos4:pwsettings net utility - change also here the "minPwdAge" to be the real default
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:27:20 +0000 (11:27 +0200)]
s4:pwsettings net utility - change also here the "minPwdAge" to be the real default

Which is one day.

13 years agos4:blackbox/test_passwords.sh - perform also here the adaptions for "minPwdAge" != 0
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:23:39 +0000 (11:23 +0200)]
s4:blackbox/test_passwords.sh - perform also here the adaptions for "minPwdAge" != 0

13 years agos4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly
Matthias Dieter Wallnöfer [Sat, 3 Jul 2010 09:07:10 +0000 (11:07 +0200)]
s4:dsdb/tests/passwords.py - set and reset the "minPwdAge" properly

After a patch proposal of Nadya and some reflection I think that it's really
worth to change all tests which need a "0" "minPwdAge" to set it manually and
reset the default afterwards.

So we can finally introduce the default "minPwdAge" on provision.

Patch proposal by: Nadya Ivanova

13 years agoTests for user-change-password and force-password-change access rights
Nadezhda Ivanova [Fri, 2 Jul 2010 13:38:05 +0000 (16:38 +0300)]
Tests for user-change-password and force-password-change access rights

13 years agos3-net: forgot to set type in winreg getvalue operation.
Günther Deschner [Fri, 2 Jul 2010 11:08:00 +0000 (13:08 +0200)]
s3-net: forgot to set type in winreg getvalue operation.

Guenther

13 years agos4/schema: remove unnecessary deletion of dsdb_schema cached pointer
Anatoliy Atanasov [Fri, 2 Jul 2010 08:39:39 +0000 (11:39 +0300)]
s4/schema: remove unnecessary deletion of dsdb_schema cached pointer

This is needed so we can find and free old schemas based using
the cached pointer

13 years agos3-registry: remove 2 byte winreg type limitation.
Günther Deschner [Thu, 1 Jul 2010 09:22:20 +0000 (11:22 +0200)]
s3-registry: remove 2 byte winreg type limitation.

We already pull and push 4 byte winreg type in the registry.tdb, we were just
not using full 4 bytes within the reg_object functions.

With this change we finally pass the set extended value torture test.

Guenther

13 years agos3-registry: allow to read NULL entries (that we allow to store) back from the tdb.
Günther Deschner [Thu, 1 Jul 2010 13:50:58 +0000 (15:50 +0200)]
s3-registry: allow to read NULL entries (that we allow to store) back from the tdb.

Guenther

13 years agos4-smbtorture: enable extended SetValue test against Samba3.
Günther Deschner [Thu, 1 Jul 2010 01:04:39 +0000 (03:04 +0200)]
s4-smbtorture: enable extended SetValue test against Samba3.

Guenther

13 years agos3-registry: remove unused reg_util_marshalling code.
Günther Deschner [Thu, 1 Jul 2010 00:57:19 +0000 (02:57 +0200)]
s3-registry: remove unused reg_util_marshalling code.

Guenther

13 years agos3-registry: avoid using registry_value union.
Günther Deschner [Tue, 29 Jun 2010 14:13:15 +0000 (16:13 +0200)]
s3-registry: avoid using registry_value union.

Just pull and push data as is.

Guenther

13 years agos4-ldb: fixed error handling in openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:39:28 +0000 (11:39 +1000)]
s4-ldb: fixed error handling in openldap backend

fixed several bugs in error handling. the ldb context was used without
being initialised in the error paths, and several error paths did not
set an ldb error string.

13 years agos4-ldb: fixed the parsing of references in the openldap backend
Andrew Tridgell [Fri, 2 Jul 2010 01:37:50 +0000 (11:37 +1000)]
s4-ldb: fixed the parsing of references in the openldap backend

We need to use ldap_parse_reference() not ldap_parse_result()

13 years agos4-dsdb: fixed use after free of sasl mechanisms opaque
Andrew Tridgell [Wed, 30 Jun 2010 03:49:05 +0000 (13:49 +1000)]
s4-dsdb: fixed use after free of sasl mechanisms opaque

the supportedSASLMechanisms opaque must live for at least as long as
the ldb, or we can crash when the first connection is torn down

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4-dsdb: fixed spelling of supportedSASLMechanisms
Andrew Tridgell [Wed, 30 Jun 2010 03:47:29 +0000 (13:47 +1000)]
s4-dsdb: fixed spelling of supportedSASLMechanisms

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

13 years agos4:dsdb Ensure we free old schema copies
Andrew Bartlett [Wed, 30 Jun 2010 13:25:32 +0000 (23:25 +1000)]
s4:dsdb Ensure we free old schema copies

It was reported by aatanasov that we kept around one whole schema per
modification made.  This does not fix that, but I hope moves us closer
to a fix

The most important part of the fix is that:

- if (schema_out != schema_in) {
- talloc_unlink(schema_in, ldb);
- }

was the wrong way around.  This is now handled in the schema_set calls.

Andrew Bartlett

13 years agos4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call
Kamen Mazdrashki [Thu, 1 Jul 2010 20:47:02 +0000 (23:47 +0300)]
s4/dsdb: Assert DSDB_FLAG_*_MODULE is always passed in function call

Signed-off-by: Andrew Bartlett <abartlet@samba.org>