Matthieu Patou [Sun, 13 Jun 2010 21:50:47 +0000 (01:50 +0400)]
s4 upgradeprovision: add an option to force the rebuilding of FS ACLs on sysvols share
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Tue, 15 Jun 2010 08:53:18 +0000 (12:53 +0400)]
s4 unittests: add unit tests for upgradehelpers
The functions tested are:
* construct_existor_expr
* search_constructed_attrs_stored
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Tue, 15 Jun 2010 08:50:29 +0000 (12:50 +0400)]
s4 upgradeprovision: Add function for searching stored constructed attributes
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 14 Jun 2010 22:41:18 +0000 (02:41 +0400)]
s4: Using control bypassoperational allow the logic of this module to be bypassed for some given attributes
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 14 Jun 2010 22:23:11 +0000 (02:23 +0400)]
ldb: add a new control bypassioperationnal
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Tue, 15 Jun 2010 19:41:39 +0000 (23:41 +0400)]
s4 upgradeprovision: additional restyling
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Wed, 9 Jun 2010 21:00:43 +0000 (01:00 +0400)]
s4 upgradeprovision: Restyle imports
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 20:01:16 +0000 (00:01 +0400)]
s4 upgradeprovision: Move functions to helpers and improve code
Among code improvement the most significant part is that we now
compare DN object instead of their string representation. It allow
to better react to case an white space difference.
Some new move objects have been added (ie. System into well known
security principals).
This will allow more unittesting
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Fri, 7 May 2010 00:22:36 +0000 (04:22 +0400)]
s4 python: Update unit tests related to create secrets
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 24 May 2010 05:41:44 +0000 (09:41 +0400)]
s4: Add comments about setup_secrets
Comments are to inform people that this function should not handle
transaction within the function as it is mainly used in provision and
that we want to commit secrets only if all the action on secrets have
worked.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Fri, 7 May 2010 12:26:26 +0000 (16:26 +0400)]
s4 upgradeprovision: Add documentation on the update process
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 3 May 2010 20:01:00 +0000 (00:01 +0400)]
s4 python: Add unit tests for upgradeprovision related stuff
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 20:52:25 +0000 (00:52 +0400)]
s4 upgradeprovision: move some functions to upgradehelpers for unit tests
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 21:13:45 +0000 (01:13 +0400)]
s4 upgradeprovision: Fix style
reformat *_update_samdb functions
fix_partition_sd
rebuild_sd
update_samdb
update_privilege
update_machine_account_password
update_gpo
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 12:27:48 +0000 (16:27 +0400)]
s4 upgradeprovision: Use replPropertyMetaData for better guess
Rework upgradeprovision in order to get more precise updates when doing upgrade provision.
This is done through the use of replPropertyMetaData information and raw information revealed by the
"reveal" control.
The code has been changed also to avoid double free error when changing the schema (for old provision).
Checking of SD is done a bit more cleverly as we compare the different parts for an ACL separately.
Fix logic when upgrading provision without replPropertyMetaData infos
Also for old provision (pre alpha9) do not copy the usn range because data here will be wrong
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 19:47:43 +0000 (23:47 +0400)]
s4 upgradeprovision: Reformat attributes lists and reformat parser
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Thu, 8 Apr 2010 22:55:38 +0000 (02:55 +0400)]
s4 upgradeprovision: Inform about new dns dynamic update if the provision didn't have it
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 20:21:48 +0000 (00:21 +0400)]
s4 upgradeprovision: fix style
add_deletedobj_containers
add missing objects
clean add-mising
handle special add + dump denied
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Sun, 2 May 2010 15:56:03 +0000 (19:56 +0400)]
s4 upgrade provision: Refactor code to do all the modification within 1 transaction
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Mon, 7 Jun 2010 20:21:00 +0000 (00:21 +0400)]
s4 upgrade provision: Fix style in gen_dn_index
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Sun, 2 May 2010 15:56:31 +0000 (19:56 +0400)]
s4 Add functions related to ldb manipulation when doing upgrade
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Matthieu Patou [Thu, 22 Apr 2010 08:53:12 +0000 (12:53 +0400)]
s4 provision: Add information about provisioned usn range in sam.ldb
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Jelmer Vernooij [Sat, 19 Jun 2010 16:58:18 +0000 (18:58 +0200)]
python: Use samba.tests.TestCase, make sure base class tearDown and
setUp methods are called, fix formatting.
Jelmer Vernooij [Sat, 19 Jun 2010 16:57:35 +0000 (18:57 +0200)]
acl: Clean up formatting, use samba.tests.TestCase.
Jelmer Vernooij [Sat, 19 Jun 2010 16:57:13 +0000 (18:57 +0200)]
pyrpc: Fix reference counting when using secondary connections.
Jelmer Vernooij [Sat, 19 Jun 2010 15:49:46 +0000 (17:49 +0200)]
samba.tests.samba3: Clean up imports, use new TestCase class.
Jelmer Vernooij [Sat, 19 Jun 2010 15:49:15 +0000 (17:49 +0200)]
ntacls: Raise TestSkipped rather than writing to stdout.
Jelmer Vernooij [Sat, 19 Jun 2010 15:48:37 +0000 (17:48 +0200)]
python/passwords: Clean up imports.
Jelmer Vernooij [Sat, 19 Jun 2010 15:48:05 +0000 (17:48 +0200)]
samba.tests: Provide TestCase and TestSkipped classes (from testtools) for convenience.
Jelmer Vernooij [Sat, 19 Jun 2010 15:46:57 +0000 (17:46 +0200)]
pytdb: Cleanup formatting.
Jelmer Vernooij [Sat, 19 Jun 2010 15:32:01 +0000 (17:32 +0200)]
dsdb_schema_info: Clean up imports, avoid using rpc test case for
non-RPC tests.
Jelmer Vernooij [Sat, 19 Jun 2010 15:27:50 +0000 (17:27 +0200)]
python: Remove unnecessary Ldb.set_invocation_id - use SamDB.set_invocation_id instead.
Jelmer Vernooij [Sat, 19 Jun 2010 15:23:41 +0000 (17:23 +0200)]
pyglue: Trim dependencies.
Jelmer Vernooij [Sat, 19 Jun 2010 15:19:48 +0000 (17:19 +0200)]
pyglue: Remove unused code.
Jelmer Vernooij [Sat, 19 Jun 2010 15:15:26 +0000 (17:15 +0200)]
pydsdb: Move write_prefixes_from_schema_to_ldb to pydsdb from pyglue.
Jelmer Vernooij [Sat, 19 Jun 2010 15:09:52 +0000 (17:09 +0200)]
pydsdb: Move dsdb_set_schema_from_ldb to pydsdb.
Jelmer Vernooij [Sat, 19 Jun 2010 14:52:09 +0000 (16:52 +0200)]
pydsdb: Move set_schema_from_ldif function to pydsdb from pyglue.
Brendan Powers [Tue, 25 May 2010 20:14:37 +0000 (16:14 -0400)]
libcli: Fixed a segfault in security_acl_dup when the acl is NULL.
This can happen when duplicating a security descriptor that is missing either sacls or dacls.
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Stefan Metzmacher [Fri, 30 Apr 2010 16:47:44 +0000 (18:47 +0200)]
s4:provision: don't use hardcoded 'Default-First-Site-Name'
metze
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Matthias Dieter Wallnöfer [Sat, 19 Jun 2010 17:33:16 +0000 (19:33 +0200)]
s4:instancetype LDB module - "instanceType" is single-valued - MS-ADTS 3.1.1.5.2.2
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 13:39:06 +0000 (15:39 +0200)]
s4:torture/ldap/basic.c - add more error code/messages tests
And now we do match at least the LDAP error code (the WERROR one does still
differ from Windows - we will see how to change that).
Matthias Dieter Wallnöfer [Sat, 19 Jun 2010 12:58:31 +0000 (14:58 +0200)]
s4:ldap_backend.c - more customisations to match Windows Server error behaviour on renames
Matthias Dieter Wallnöfer [Sat, 19 Jun 2010 12:49:23 +0000 (14:49 +0200)]
ldb:ldb_dn.c - don't support "ldb_dn_add_child" on a "" parent DN
It's meaningless and could end in DNs as "cn=child,".
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 20:20:22 +0000 (22:20 +0200)]
s4:python/samba/__init__.py - now specify the "relax" control for the delete operation before the provision
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 20:17:54 +0000 (22:17 +0200)]
ldb:api.py - add a small test for the enhanced "py_ldb_delete" syntax
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 20:08:58 +0000 (22:08 +0200)]
ldb:python bindings - some small cleanup & improvements in "py_ldb_add"
Also to make it similar to "py_ldb_delete".
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 20:04:07 +0000 (22:04 +0200)]
ldb:python bindings - let also "py_ldb_delete" support controls
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 19:35:43 +0000 (21:35 +0200)]
s4:objectclass LDB module - disable delete operations when "SYSTEM_FLAG_DISALLOW_DELETE" is specified
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 19:13:39 +0000 (21:13 +0200)]
s4:rootdse LDB module - strip trailing whitespaces
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 19:10:19 +0000 (21:10 +0200)]
s4:rootdse LDB module - protect add and delete operations on the rootdse entry
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 18:53:25 +0000 (20:53 +0200)]
s4:rootdse LDB module - Return "UNWILLING_TO_PERFORM" when no attribute fits on a change
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 18:52:33 +0000 (20:52 +0200)]
s4:rootdse LDB module - refactor error messages
Fix indentations, use "set_errstring" when no "asprintf" functionality required.
Matthias Dieter Wallnöfer [Sat, 19 Jun 2010 15:47:22 +0000 (17:47 +0200)]
s4:objectclass LDB module - use the old DN when displaying error messages
Matthias Dieter Wallnöfer [Sat, 19 Jun 2010 15:46:57 +0000 (17:46 +0200)]
s4:objectclass LDB module - add a better message when the parent DN is invalid
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 13:32:48 +0000 (15:32 +0200)]
s4:objectclass LDB module - add an error message when someone tries to add entries without objectclasses
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 13:17:05 +0000 (15:17 +0200)]
s4:objectclass LDB module - handle the case when there is a retry to add the root basedn
This isn't quitted with a normal "NO_SUCH_OBJECT" (parent not found) but with a
very special referral: one with the DN itself and the hostname is the last
component value of the DN.
Jelmer Vernooij [Sat, 19 Jun 2010 14:00:04 +0000 (16:00 +0200)]
wafsamba: Use octal modes directly rather than constants.
Jelmer Vernooij [Sat, 19 Jun 2010 13:32:27 +0000 (15:32 +0200)]
heimdal/waf: Initial work on making it possible to use the system
heimdal again.
Still missing are the detection of the right Heimdal version and
linking (unresolved symbols at the moment).
Jelmer Vernooij [Sat, 19 Jun 2010 12:46:22 +0000 (14:46 +0200)]
dsdb: Fix includes when building against system ldb.
Jelmer Vernooij [Sat, 19 Jun 2010 12:45:35 +0000 (14:45 +0200)]
wafsamba: Allow manually specifying cflags/ldflags for system libraries.
Jelmer Vernooij [Sat, 19 Jun 2010 12:02:18 +0000 (14:02 +0200)]
wafsamba: Use convenience function to find out if bundling is necessary.
Jelmer Vernooij [Sat, 19 Jun 2010 11:55:41 +0000 (13:55 +0200)]
dsdb: Use Samba includes so _PUBLIC_ is defined.
Jelmer Vernooij [Sat, 19 Jun 2010 11:47:11 +0000 (13:47 +0200)]
wafsamba: Factor out functions to determine if a bundled library should not or
must be used.
Jelmer Vernooij [Sat, 19 Jun 2010 11:46:39 +0000 (13:46 +0200)]
dsdb: Make module ops struct for each module public.
Jelmer Vernooij [Sat, 19 Jun 2010 11:41:48 +0000 (13:41 +0200)]
s4-python: Use sys.prefix rather than guessing prefix from current
file path.
Jelmer Vernooij [Sat, 19 Jun 2010 10:10:29 +0000 (12:10 +0200)]
wafsamba: Fix typo: noextenion -> noextension.
Jelmer Vernooij [Sat, 19 Jun 2010 00:26:13 +0000 (02:26 +0200)]
waf: Add missing dependency (so header paths are inherited) on talloc to internal python lib.
Jelmer Vernooij [Fri, 18 Jun 2010 20:43:37 +0000 (22:43 +0200)]
samba4: Build libreplace as builtin library by default so it doesn't end
up in $prefix/lib.
Jelmer Vernooij [Fri, 18 Jun 2010 20:43:17 +0000 (22:43 +0200)]
replace: Avoid hiding symbols when libreplace is builtin, as this
appears to cause unresolved symbols at the moment.
Jelmer Vernooij [Fri, 18 Jun 2010 08:09:03 +0000 (10:09 +0200)]
ldb: Remove dependency on self.
Jelmer Vernooij [Fri, 18 Jun 2010 07:45:15 +0000 (09:45 +0200)]
wafsamba: Use BUILTIN_LIBRARY() rather than relying on side-effects.
Jelmer Vernooij [Thu, 17 Jun 2010 20:36:33 +0000 (22:36 +0200)]
ldbsamba: Build as subsystem to prevent infinite recursion issues.
Jelmer Vernooij [Wed, 16 Jun 2010 18:38:22 +0000 (20:38 +0200)]
s4: Don't build a $prefix/lib/libpython.so, as such a library often already exists :-)
Jelmer Vernooij [Wed, 16 Jun 2010 18:35:40 +0000 (20:35 +0200)]
s4-waf: Don't include pytalloc when embedding python.
Jelmer Vernooij [Wed, 16 Jun 2010 18:15:19 +0000 (20:15 +0200)]
s4: Build more python convenience files as subsystems rather than as python modules.
Jelmer Vernooij [Wed, 16 Jun 2010 18:14:46 +0000 (20:14 +0200)]
ldb: Don't build pyldb_util as python module but rather as subsystem, so as to not delute /usr/lib.
Jelmer Vernooij [Wed, 16 Jun 2010 18:14:31 +0000 (20:14 +0200)]
ldb-samba: Don't build pyldbsamba as python module but rather as subsystem, so as to not delute /usr/lib.
Jelmer Vernooij [Wed, 16 Jun 2010 18:01:38 +0000 (20:01 +0200)]
web_server: Don't build wsgi support as python module but rather as
subsystem so we don't install it into /usr/lib.
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 17:11:35 +0000 (19:11 +0200)]
s4:cldap_server/rootdse.c - simplify the code a bit
Remove "NULL"-content variables and use "NULL"s directly as arguments. Add some
linewraps where needed.
Matthias Dieter Wallnöfer [Fri, 18 Jun 2010 16:57:38 +0000 (18:57 +0200)]
s4:cldap_server.c - here the counter variable should be "signed"
Jeremy Allison [Thu, 17 Jun 2010 22:51:19 +0000 (15:51 -0700)]
Second part of fix converting prs_XX struct and functions to talloc. Remove unneeded prs_mem_free calls.
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
Jeremy Allison [Thu, 17 Jun 2010 22:35:07 +0000 (15:35 -0700)]
Convert the prs_XXX struct and functions to use talloc instead of malloc. Passes valgrind and make tests for client and server. Second version of this patch after splitting up at Simo's request. Patch to follow will delete extraneous prs_mem_free() calls.
Jeremy.
Signed-off-by: Simo Sorce <idra@samba.org>
Matthieu Patou [Wed, 16 Jun 2010 08:39:16 +0000 (12:39 +0400)]
unittest: Change the name of the base ldb test so that it can be easily called separatly
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 14:35:55 +0000 (16:35 +0200)]
s4:ldap_backend.c - fix crash bugs when we got in error situations with "res" still set to "NULL"
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 14:00:13 +0000 (16:00 +0200)]
s4:ldap_backend.c - fix a small error (use "ModifyResponse" rather than "AddResponse")
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 13:27:50 +0000 (15:27 +0200)]
s4:objectclass LDB module - move "mem_ctx" initialisation lower
Saves us some "talloc_free"s on error cases
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 07:42:17 +0000 (09:42 +0200)]
s4:dcesrv_netr_DsRAddressToSitenamesExW - fix the detection of the address family in a better way
Obviously the last attempt wasn't enough. Now we do really only read the first
byte in the address buffer which on little endian transmission does always
contain the address family (MS-NRPC 2.2.1.2.4.1).
This should now be working platform-independently.
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 07:33:10 +0000 (09:33 +0200)]
s4:torture/rpc/netlogon.c - make sure that the address family is set in little endian in the "AddressToSitenames" tests
Matthias Dieter Wallnöfer [Thu, 17 Jun 2010 07:23:00 +0000 (09:23 +0200)]
s4:torture/rpc/netlogon.c - activate "AddressToSitenames" tests which do run against s4
Jeremy Allison [Thu, 17 Jun 2010 19:34:15 +0000 (12:34 -0700)]
Use #defined constant instead of "false" to be clearer about intent.
Günther Deschner [Thu, 17 Jun 2010 13:01:01 +0000 (15:01 +0200)]
s3-selftest: fix locktest9 in make selftest.
Guenther
Björn Jacke [Wed, 16 Jun 2010 21:36:38 +0000 (23:36 +0200)]
s3:configure: use cc for linking on IRIX and fix shlib usage
Stefan Metzmacher [Wed, 16 Jun 2010 21:11:05 +0000 (23:11 +0200)]
s4:torture/rpc/remote_pac: use dcerpc_netr_LogonSamLogon_r() instead of dcerpc_netr_LogonSamLogon()
metze
Stefan Metzmacher [Wed, 16 Jun 2010 09:22:30 +0000 (11:22 +0200)]
selftest/Samba4: make the naming of passwords more consistent
metze
Stefan Metzmacher [Wed, 16 Jun 2010 09:14:46 +0000 (11:14 +0200)]
selftest/Samba4: let localfl2000dc use 127.0.0.5
Now we have 127.0.0.6-10 available for more servers.
metze
Stefan Metzmacher [Wed, 16 Jun 2010 09:13:28 +0000 (11:13 +0200)]
selftest/Samba4: let localvampiredc use 127.0.0.2
metze
Stefan Metzmacher [Wed, 16 Jun 2010 09:02:48 +0000 (11:02 +0200)]
selftest: use 127.0.0.11-16 for the client
This gives more room for servers.
Note: socket_wrapper currently only supports 127.0.0.1-16
see MAX_WRAPPED_INTERFACES.
metze
Stefan Metzmacher [Wed, 16 Jun 2010 09:00:29 +0000 (11:00 +0200)]
selftest/Samba3: remove unused create_clientconf() function
metze
Stefan Metzmacher [Thu, 17 Jun 2010 06:55:10 +0000 (08:55 +0200)]
pidl/wscript: build manpages in build group 'final'
So that waf --target=smbtorture doesn't build them
metze
Stefan Metzmacher [Thu, 17 Jun 2010 06:49:36 +0000 (08:49 +0200)]
pidl/wscript: only try to build pidl manpages if pod2man is available
metze