samba.git
11 years agos3fs-smbd: Make sure the registry is set up before we init printing.
Andreas Schneider [Tue, 2 Oct 2012 13:51:08 +0000 (15:51 +0200)]
s3fs-smbd: Make sure the registry is set up before we init printing.

(cherry picked from commit 50de2c9bbbc25074f022b4b2cf9d49f8e9a53e01)

Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #9245 - Printing backend is initialized before the winreg pipe is set
up.

11 years agodocs: Remove duplicate synonym min protocol.
Karolin Seeger [Thu, 4 Oct 2012 08:00:44 +0000 (10:00 +0200)]
docs: Remove duplicate synonym min protocol.

Karolin
(cherry picked from commit c627ba145e18c3fb91ca6da730541dd1f119c4d0)

The last 2 patches address bug #9243 - Duplicate synonym 'min protocol'.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Oct  4 16:42:57 CEST 2012 on sn-devel-104

11 years agosmb.conf(5): Add basic documentation for 'server min protocol'.
Jelmer Vernooij [Wed, 26 Sep 2012 22:55:04 +0000 (15:55 -0700)]
smb.conf(5): Add basic documentation for 'server min protocol'.

Conflicts:
docs-xml/smbdotconf/protocol/serverminprotocol.xml
(cherry picked from commit b97c257f3af942d0767226793fa705940caad8dd)

11 years agohtml docs: Remove link to Using Samba.
Karolin Seeger [Thu, 4 Oct 2012 09:43:20 +0000 (11:43 +0200)]
html docs: Remove link to Using Samba.

Thanks to Christian Perrier <bubulle@debian.org> for reporting!

Fix bug #7826 - HTML docs index file still points to Using Samba.

Karolin

Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Thu Oct  4 13:48:00 CEST 2012 on sn-devel-104
(cherry picked from commit 1bf209dd7e5a0f0001b3d1e3798093772bbd3fd3)

11 years agoFix net rpc share allowedusers to work with 2008r2
Jeremy Allison [Thu, 4 Oct 2012 08:56:12 +0000 (10:56 +0200)]
Fix net rpc share allowedusers to work with 2008r2

The RAP NetShareEnum command was removed in 2008r2, so use the RPC equivalent
instead.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=8966
Author: Jeremy Allison <jra@samba.org>

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Oct  4 12:41:16 CEST 2012 on sn-devel-104

11 years agos3-docs: Fix opening and ending tag mismatch in Samba3-HOWTO (Bug #9235)
Björn Baumbach [Tue, 2 Oct 2012 08:53:15 +0000 (10:53 +0200)]
s3-docs: Fix opening and ending tag mismatch in Samba3-HOWTO (Bug #9235)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit f5a7bc26648e5edd2d0958c50a4432f14f5ce727)

The last 5 patches address bug #9235 - Opening and ending tag mismatch in
Samba3-HOWTO/TOSHARG-PDC.xml.

11 years agodocs: Remove Win9X/WinMe mentions from TOSHARG-PDC
Andrew Bartlett [Sat, 22 Sep 2012 18:55:20 +0000 (04:55 +1000)]
docs: Remove Win9X/WinMe mentions from TOSHARG-PDC
(cherry picked from commit e3f554a99f3871eabac35db1ba3236772ef58f64)

11 years agodocs: Add mention of AD DC support in TOSHARG-PDC
Andrew Bartlett [Sat, 22 Sep 2012 18:54:24 +0000 (04:54 +1000)]
docs: Add mention of AD DC support in TOSHARG-PDC
(cherry picked from commit f82affaa6defef52696f69f114143cfb80fee241)

11 years agodocs: Explain the no-domain-logons restriction applies to all HOME editions
Andrew Bartlett [Sat, 22 Sep 2012 18:53:55 +0000 (04:53 +1000)]
docs: Explain the no-domain-logons restriction applies to all HOME editions
(cherry picked from commit 6fcb95bad7db8f970ae6c74f1fdd7b4c2a41f25c)

11 years agodocs: Remove references to default paramters in TOSHARG-PDC
Andrew Bartlett [Sat, 22 Sep 2012 18:52:56 +0000 (04:52 +1000)]
docs: Remove references to default paramters in TOSHARG-PDC
(cherry picked from commit 3be323c6110f1a241f86aacb94c8ff1ba69351c5)

11 years agos4 dns: Fix return code for deleted records
Kai Blin [Sun, 30 Sep 2012 09:26:24 +0000 (11:26 +0200)]
s4 dns: Fix return code for deleted records

This fixes bug #9225. We already had a test for this scenario, but the test wasn't
correct. This patch fixes the test, and also fixes the bug.

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Tue Oct  2 16:46:06 CEST 2012 on sn-devel-104

11 years agos4:dns_server - introduce the wildcard binding feature
Matthias Dieter Wallnöfer [Sun, 12 Aug 2012 16:08:20 +0000 (18:08 +0200)]
s4:dns_server - introduce the wildcard binding feature

We need the wildcard binding feature otherwise we might get bound to a
private interface in case of multiple interfaces and no "interfaces"
parameter in smb.conf.

Code taken from source4/ldap_server/ldap_server.c

Signed-off-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Kai Blin <kai@samba.org>
Autobuild-Date(master): Sun Sep 23 23:44:03 CEST 2012 on sn-devel-104

Fix bug #9183 - DNS server does not listen on localhost.

11 years agos4: Fix a -Wunused-value warning
Volker Lendecke [Wed, 26 Sep 2012 17:07:32 +0000 (10:07 -0700)]
s4: Fix a -Wunused-value warning

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Sep 26 21:52:00 CEST 2012 on sn-devel-104
(cherry picked from commit 5022b3d8c183181b922e3ccac49e5819eb453035)

Fix bug #9223 - Uninitialized variable in the cldap server can give bad netlogon
netsamlogon response.

11 years agoselftest/knownfail: samba*.smb2.oplock.stream1 doesn't work
Stefan Metzmacher [Wed, 26 Sep 2012 01:24:22 +0000 (03:24 +0200)]
selftest/knownfail: samba*.smb2.oplock.stream1 doesn't work

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Sep 26 07:57:12 CEST 2012 on sn-devel-104
(cherry picked from commit 98d117a5424d62804b7cb3d8a9ad35e703fc158a)

11 years agos4:torture/smb2: remove samba specific stuff from smb2.oplock
Stefan Metzmacher [Wed, 26 Sep 2012 01:08:33 +0000 (03:08 +0200)]
s4:torture/smb2: remove samba specific stuff from smb2.oplock

metze
(cherry picked from commit 7a14f09f9cc14cfb6234175add1841faf751d51a)

11 years agos3:smb2_create: don't take 'state->te' as indication for "was_deferred" (bug #9196)
Stefan Metzmacher [Wed, 26 Sep 2012 01:04:20 +0000 (03:04 +0200)]
s3:smb2_create: don't take 'state->te' as indication for "was_deferred" (bug #9196)

We always set state->te = NULL of TALLOC_FREE(state->te),
before calling smbd_smb2_request_dispatch(), so
open_was_deferred_smb2() always returned false, while dispatching
it again.

But it's remove_deferred_open_message_smb2_internal() which
should reset this state.

In developer mode validate_my_share_entries() did call smb_panic()
before.

metze
(cherry picked from commit 4604219ceba96955b3c4bf6ab31aa70c11442d61)

11 years agoFix bug #9209 - Parse of invalid SMB2 create blob can cause smbd crash.
Jeremy Allison [Wed, 26 Sep 2012 23:58:58 +0000 (16:58 -0700)]
Fix bug #9209 - Parse of invalid SMB2 create blob can cause smbd crash.

Ensure we correctly protect against blobs with data_offset==0
and data_length != 0.

Jeremy.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 27 22:07:02 CEST 2012 on sn-devel-104
(cherry picked from commit 322e3d42f65dadabeccf8813fcb0e9b7d353ffb2)

11 years agolibcli/smb: fix padding in smb2_create_blob*
Stefan Metzmacher [Wed, 19 Sep 2012 06:11:23 +0000 (08:11 +0200)]
libcli/smb: fix padding in smb2_create_blob*

metze
(cherry picked from commit aa5caf1fe92b159eae00c7b11499e9ec697cf9ae)

11 years agoVERSION: Bump version up to 4.0.0rc3.
Karolin Seeger [Tue, 2 Oct 2012 07:55:44 +0000 (09:55 +0200)]
VERSION: Bump version up to 4.0.0rc3.

And enable GIT snapshots.

Karolin

11 years agoVERSION: Bump version number up to 4.0.0rc2. samba-4.0.0rc2
Karolin Seeger [Tue, 2 Oct 2012 07:54:10 +0000 (09:54 +0200)]
VERSION: Bump version number up to 4.0.0rc2.

Karolin

11 years agolibrelease.sh: Move the GPG data to the library section.
Karolin Seeger [Tue, 2 Oct 2012 08:29:16 +0000 (10:29 +0200)]
librelease.sh: Move the GPG data to the library section.

Don't use the Library key for the samba releases.

Karolin

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agoWHATSNEW: Add kernel oplocks...
Karolin Seeger [Tue, 2 Oct 2012 08:52:21 +0000 (10:52 +0200)]
WHATSNEW: Add kernel oplocks...

to the list of changed defaults.

Karolin

11 years agoWHATSNEW: Remove default values.
Karolin Seeger [Tue, 2 Oct 2012 07:23:45 +0000 (09:23 +0200)]
WHATSNEW: Remove default values.

Karolin

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Tue Oct  2 11:05:25 CEST 2012 on sn-devel-104

11 years agoWHATSNEW: Add more changes since rc1.
Karolin Seeger [Tue, 2 Oct 2012 07:20:00 +0000 (09:20 +0200)]
WHATSNEW: Add more changes since rc1.

Karolin

11 years agos4-dns: fix a non handled memory out of memory
Matthieu Patou [Tue, 2 Oct 2012 04:43:11 +0000 (21:43 -0700)]
s4-dns: fix a non handled memory out of memory

Fix bug #9233 - internal dns server has a non handled out of memory case.

11 years agos3fs-smbd: Move housekeeping to the background process.
Andreas Schneider [Thu, 27 Sep 2012 17:01:15 +0000 (19:01 +0200)]
s3fs-smbd: Move housekeeping to the background process.

If you add 200 printers using lpadmin. Then you wait for the printcap
cache to expire. As soon as this expires we notify all deamons that they
should reload the printers. This mean we need to create the default
registry keys for each printer. If you do e.g. a 'smbclient -L' during
that time you will get a lot of timeouts.

This lets the housekeeping function of the printcap cache do the task of
creating the default registry keys in background queue process. When it is done
with the task it will tell all smbd childs to reload the printers and the 200
printers appear.

(cherry picked from commit aa6a7a97803b1106d2200c889a2260f81059c450)

Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #9231 - NT_STATUS_IO_TIMEOUT during slow import of printers into
registry.

11 years agoFix service control for non-internal services.
Vladimir Marek [Mon, 17 Sep 2012 20:50:55 +0000 (13:50 -0700)]
Fix service control for non-internal services.

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit a4e8869f7c93f30dd7014ff83d6d2f2b5afc2d64)
Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #9192 - svcctl list option prohibits smbd to start.

11 years agos3-winbindd: Adjust error code loop logic in rpc_trusted_domains().
Günther Deschner [Fri, 28 Sep 2012 16:04:07 +0000 (18:04 +0200)]
s3-winbindd: Adjust error code loop logic in rpc_trusted_domains().

Guenther

Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Sat Sep 29 00:34:04 CEST 2012 on sn-devel-104

Fix bug #9185 - Winbind cannot resolve AD DC in a different subnet.

11 years agos3-lsa: Flesh out the returned info in _lsa_EnumTrustedDomainsEx().
Günther Deschner [Fri, 28 Sep 2012 16:03:25 +0000 (18:03 +0200)]
s3-lsa: Flesh out the returned info in _lsa_EnumTrustedDomainsEx().

Guenther

11 years agos3-winbindd: Allow DNS resolution of trusted domains if DNS name is avaliable
Sumit Bose [Tue, 11 Sep 2012 11:28:35 +0000 (13:28 +0200)]
s3-winbindd: Allow DNS resolution of trusted domains if DNS name is avaliable

Signed-off-by: Günther Deschner <gd@samba.org>
11 years agodocs-xml: fix build of winbindd- and krb5 locator-related manpages
Alexander Bokovoy [Mon, 17 Sep 2012 16:09:35 +0000 (19:09 +0300)]
docs-xml: fix build of winbindd- and krb5 locator-related manpages

These manpages depend on docs-xml infrastructure (samba DTDs)

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Mon Sep 17 19:52:53 CEST 2012 on sn-devel-104

The last 2 patches address bug #9229 - make man pages buildable via WAF.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Mon Oct  1 13:08:28 CEST 2012 on sn-devel-104

11 years agodocs-xml: convert smb.conf.5 build to waf
Alexander Bokovoy [Mon, 17 Sep 2012 10:07:26 +0000 (13:07 +0300)]
docs-xml: convert smb.conf.5 build to waf

smb.conf(5) is different from other manpages because before it is
built, it gets merged together from a number of smaller files, one
per parameter. So we first create a parameters.all.xml file that
references all these files and then include it into master smb.conf.5.xml

One small issue is how to handle generated files in WAF build
from xi:include perspective as the files are generated in bin/default/docs-xml
rather than in docs-xml. We solve this by further expanding use of XML catalogs
and rewriting virtual path http://www.samba.org/samba/smbdotconf/ to proper
location.

Both docs-xml autoconf and waf builds work correctly now.

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Mon Sep 17 14:18:31 CEST 2012 on sn-devel-104

11 years agobuild: Fix build on systems without ldap development headers
Andrew Bartlett [Fri, 14 Sep 2012 18:58:02 +0000 (11:58 -0700)]
build: Fix build on systems without ldap development headers

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Sep 14 22:53:30 CEST 2012 on sn-devel-104

The last 2 patches address bug #9228 - libpdb/pdb_ldap/idmap_ldap build
dependencies cleanup (for 4.0RC2).

11 years agos3: make smbldaphelper subsystem an internal library
Alexander Bokovoy [Thu, 13 Sep 2012 17:29:25 +0000 (20:29 +0300)]
s3: make smbldaphelper subsystem an internal library

Break pdb_ldap -> smbldaphelper -> pdb -> pdb_ldap loop by
making smbldaphelp intentionally underlinked internal library.

It means that libsmbldaphelp is not usable unless its user is
also linked to libpdb (that is the case for both its users,
idmap_ldap and pdb_ldap, already) but gives us a break of
the circular dependency in case pdb_ldap statically linked
into pdb (default).

This should solve case when idmap_ldap and pdb_ldap are dynamically
loaded modules

Autobuild-User(master): Alexander Bokovoy <ab@samba.org>
Autobuild-Date(master): Fri Sep 14 01:02:21 CEST 2012 on sn-devel-104

11 years agoWHATSNEW: Start release notes for Samba 4.0.0rc2.
Karolin Seeger [Fri, 28 Sep 2012 09:30:06 +0000 (11:30 +0200)]
WHATSNEW: Start release notes for Samba 4.0.0rc2.

To be continued...

Karolin
(cherry picked from commit e30937e2826b43ebb3a77b621a6de8bf272b02d0)

11 years agos3-smbd: Don't segfault if user specified ports out for range.
Andreas Schneider [Tue, 25 Sep 2012 12:28:22 +0000 (14:28 +0200)]
s3-smbd: Don't segfault if user specified ports out for range.

Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Sep 26 16:28:44 CEST 2012 on sn-devel-104
(cherry picked from commit 50d324b7e070de4672eff3fb6231923e6dca807a)

Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #9218 - Samba panics if a user specifies an invalid port number.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Fri Sep 28 11:02:16 CEST 2012 on sn-devel-104

11 years agoFix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.
Jeremy Allison [Tue, 25 Sep 2012 23:35:09 +0000 (16:35 -0700)]
Fix bug #9213 - Bad ASN.1 NegTokenInit packet can cause invalid free.

Not the correct fix for the specific issue, but a general fix to
make sure this can never happen again.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Sep 26 04:07:57 CEST 2012 on sn-devel-104
(cherry picked from commit 83f60672e1b3069e6b1b90b376460da895e37df3)

11 years agos4:dns.py: reproducer for (bug #9184)
Stefan Metzmacher [Fri, 21 Sep 2012 21:06:13 +0000 (23:06 +0200)]
s4:dns.py: reproducer for (bug #9184)

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Sep 22 06:08:05 CEST 2012 on sn-devel-104

11 years agolib/tsocket: fix receiving of udp packets from 0 bytes (bug #9184)
Stefan Metzmacher [Fri, 21 Sep 2012 20:54:26 +0000 (22:54 +0200)]
lib/tsocket: fix receiving of udp packets from 0 bytes (bug #9184)

It's possible for a client to send 0 bytes in a UDP packet,
we need still need to call recvfrom() and skip the invalid
packet at a higher level. Otherwise the kernel receive queue
is blocked.

metze

11 years agolibcli/echo: validate the message length
Stefan Metzmacher [Fri, 21 Sep 2012 20:18:10 +0000 (22:18 +0200)]
libcli/echo: validate the message length

metze

11 years agoselftest: skip the samba4.smb2.compound testsuite
Michael Adam [Sat, 22 Sep 2012 17:07:51 +0000 (19:07 +0200)]
selftest: skip the samba4.smb2.compound testsuite

Too many tests are starting but never finish.

Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sat Sep 22 20:50:06 CEST 2012 on sn-devel-104
(cherry picked from commit 162fbf4adbd78af0ca62e01da30e9c8bf86d3b4d)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
The last 21 patches address bug #9173 - SMB2 compound request
create/delete_on_close/close doesn't work as windows.

11 years agos3:smbd:smb2: initialize variable in vfs_default_durable_reconnect()
Michael Adam [Fri, 21 Sep 2012 20:56:20 +0000 (22:56 +0200)]
s3:smbd:smb2: initialize variable in vfs_default_durable_reconnect()

Found by Ambi's state-of-the-art compiler!
(cherry picked from commit 93bee9b3e31b398b9becc7be7804025d4066359b)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoselftest: we fail samba3.smb2.compound.interim2
Michael Adam [Thu, 20 Sep 2012 18:46:53 +0000 (20:46 +0200)]
selftest: we fail samba3.smb2.compound.interim2

We currently return NT_STATUS_CANCELLED where we should
return NT_STATUS_INTERNAL_ERROR.
(cherry picked from commit 841934647b06d6400148932cc8ce02a20c209610)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2:compound: remove two unused macros (cherry picked from commit 6f6b1c6...
Michael Adam [Wed, 19 Sep 2012 22:43:54 +0000 (00:43 +0200)]
s4:torture:smb2:compound: remove two unused macros (cherry picked from commit 6f6b1c6ac15f225978e8c2d67c1a817d9e098317)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2: don't skip the compound.interim2 test for non win7/win2k8 (cherry...
Michael Adam [Wed, 19 Sep 2012 22:41:48 +0000 (00:41 +0200)]
s4:torture:smb2: don't skip the compound.interim2 test for non win7/win2k8 (cherry picked from commit 8df0b023c51ed198d3054760447e1b273eada991)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2: don't skip the compound.interim1 test for non win7/win2k8 (cherry...
Michael Adam [Wed, 19 Sep 2012 22:41:04 +0000 (00:41 +0200)]
s4:torture:smb2: don't skip the compound.interim1 test for non win7/win2k8 (cherry picked from commit 917e714831178b2a3d07c7f9d09711231a7ccf31)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbd: remove struct member smbd_smb2_request.cancelled - it was only written ...
Michael Adam [Sat, 22 Sep 2012 00:05:18 +0000 (02:05 +0200)]
s3:smbd: remove struct member smbd_smb2_request.cancelled - it was only written (cherry picked from commit 88d051f7f18ff88ec5385fdc798f051659134bd3)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_lock: let smbd_smb2_create_cancel() trigger NT_STATUS_CANCELED
Stefan Metzmacher [Thu, 20 Sep 2012 14:16:03 +0000 (16:16 +0200)]
s3:smb2_lock: let smbd_smb2_create_cancel() trigger NT_STATUS_CANCELED

Instead of violating the tevent_req layers.

metze
(cherry picked from commit 603f9bfa4cf7910e1c1cae1a8d0741a6d0874baa)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_lock: smbd_smb2_notify_recv() can already return NT_STATUS_CANCELED
Stefan Metzmacher [Thu, 20 Sep 2012 14:16:03 +0000 (16:16 +0200)]
s3:smb2_lock: smbd_smb2_notify_recv() can already return NT_STATUS_CANCELED

That's why we can remove the code that violates the tevent_req layers.

metze
(cherry picked from commit 65a81060093cf9d7c0ebf8d6e160625bdc87baab)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_notify: make use of tevent_req_defer_callback() instead of custom tevent_imme...
Stefan Metzmacher [Thu, 20 Sep 2012 14:25:58 +0000 (16:25 +0200)]
s3:smb2_notify: make use of tevent_req_defer_callback() instead of custom tevent_immediate

metze
(cherry picked from commit 882cee0acb9c1e2105a005f0ea90691197a696c7)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_notify: don't call tevent_req_done() from smbd_smb2_notify_cancel()
Stefan Metzmacher [Thu, 20 Sep 2012 14:23:26 +0000 (16:23 +0200)]
s3:smb2_notify: don't call tevent_req_done() from smbd_smb2_notify_cancel()

smbd_notify_cancel_by_smbreq() will already trigger this via
smbd_smb2_notify_reply() and smbd_smb2_notify_reply_trigger().

metze
(cherry picked from commit 1f0dfd42f16c388abc7054a7b615d2e81031472b)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_lock: let smbd_smb2_lock_cancel() trigger NT_STATUS_CANCELED
Stefan Metzmacher [Thu, 20 Sep 2012 14:16:03 +0000 (16:16 +0200)]
s3:smb2_lock: let smbd_smb2_lock_cancel() trigger NT_STATUS_CANCELED

Instead of violating the tevent_req layers.

metze
(cherry picked from commit 1f8e4732c5870043fbbc22c772404b5380f808f0)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_server: avoid segfault in smbd_smb2_request_pending_queue()
Stefan Metzmacher [Thu, 20 Sep 2012 14:04:01 +0000 (16:04 +0200)]
s3:smb2_server: avoid segfault in smbd_smb2_request_pending_queue()

Because we should not call smbd_smb2_request_error() on an
request that is still running.

If the subreq implementes a cancel function, this should
take care of triggering smbd_smb2_request_error.

metze

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 9249871f40aab021d62d3154f8ca286b52f5ef76)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2: extend the compound.invalid1 test
Stefan Metzmacher [Fri, 21 Sep 2012 20:20:20 +0000 (22:20 +0200)]
s4:torture:smb2: extend the compound.invalid1 test

Test that when turning the related flag back off for the
last compound request, the return code changes from
invalid parameter to file closed.

Pair-Programmed-With: Michael Adam <obnox@samba.org>
(cherry picked from commit 25437df8a65e56616499dda18c696f58be08f67a)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbd:smb2: simplify smbd_smb2_request_validate() and smbd_smb2_request_dispatch()
Michael Adam [Fri, 21 Sep 2012 19:43:36 +0000 (21:43 +0200)]
s3:smbd:smb2: simplify smbd_smb2_request_validate() and smbd_smb2_request_dispatch()

removes unnneccary checks/assignments for compound_related and next_status
and duplicate setting of error status.

And remove (now) unused next_status from struct smbd_smb2_request.

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1ae6f9c62629f8513bbe93a56775b3c64ff06832)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smbd:smb2: add check for session_status for compound requests (cherry picked from...
Michael Adam [Sat, 22 Sep 2012 02:06:27 +0000 (04:06 +0200)]
s3:smbd:smb2: add check for session_status for compound requests (cherry picked from commit 27d38b5c27bd96d5124c175d946718bf0836b8f4)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_server: do the req->next_status check before the signing checks
Stefan Metzmacher [Wed, 19 Sep 2012 22:52:19 +0000 (00:52 +0200)]
s3:smb2_server: do the req->next_status check before the signing checks

Windows 2012 returns NT_STATUS_INVALID_PARAMETER to
the smb2.compound.invalid1 test if that uses signing
(instead of NT_STATUS_ACCESS_DENIED).

metze
(cherry picked from commit 4384485f82aac109bf4c4c31075e313e54b4c076)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:smb2_server: reset req->last_session_id and req->last_tid after using it
Stefan Metzmacher [Thu, 20 Sep 2012 03:10:28 +0000 (05:10 +0200)]
s3:smb2_server: reset req->last_session_id and req->last_tid after using it

If we can find a valid session or tcon we'll set it after the lookup,
but it need to make sure to reset it if we don't find the session.

This fixes a problem where a compound unrelated request between
related requests doesn't reset the session.

If we have 3 requests in a compound chain, request 3 should never
use the id's cached from request 1. It should only every inherit
handles from request 2.

metze
(cherry picked from commit 2552b6632372b35cbd7b788c4e00091dfe520a41)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2: fix the compound.invalid3 test to work against windows (cherry picke...
Michael Adam [Wed, 19 Sep 2012 22:36:29 +0000 (00:36 +0200)]
s4:torture:smb2: fix the compound.invalid3 test to work against windows (cherry picked from commit bd8d50b451ea7f94efa7777fbe5dc0c2c19f6bf9)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:torture:smb2: fix compound.related3 test to work against windows (cherry picked...
Michael Adam [Wed, 19 Sep 2012 22:35:52 +0000 (00:35 +0200)]
s4:torture:smb2: fix compound.related3 test to work against windows (cherry picked from commit 8e525a29a7c6512f61e4647ecb2e0771e2019a49)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3: Compound requests should continue processing.
Ira Cooper [Wed, 19 Sep 2012 18:39:07 +0000 (18:39 +0000)]
s3: Compound requests should continue processing.

This patch addresses #9173.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit 75951946193c874b6db30c1b9c8722264c3ce656)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3-spoolss: Fix builtin forms order to match Windows again.
Andreas Schneider [Wed, 26 Sep 2012 16:21:55 +0000 (18:21 +0200)]
s3-spoolss: Fix builtin forms order to match Windows again.

Thanks to mamachine@gmail.com.

(cherry picked from commit 24fc5b46f2b33f94bf79fc375432609697aaa45e)

Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #8632 - printing regression: form sizes seem broken, cannot print letter
size correctly.

11 years agos3: For read-only shares, filter out write bits from conn->access_mask
Volker Lendecke [Wed, 26 Sep 2012 22:26:35 +0000 (15:26 -0700)]
s3: For read-only shares, filter out write bits from conn->access_mask

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 54e5590cc1267e9c886bc9abd37d8a8eb33cf3f6)

The last 2 patches address bug #9217 - CreateFile with FILE_DIRECTORY_FILE can
create directories on read-only shares.

11 years agos3: Fix rejecting mkdir on read-only shares
Volker Lendecke [Wed, 26 Sep 2012 21:53:59 +0000 (14:53 -0700)]
s3: Fix rejecting mkdir on read-only shares

Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 6351ed1ec4b93ef1d7b79bab0b92536d74693d2a)

11 years agopanic action is defined as GLOBAL_VAR(szPanicAction) not GLOBAL_VAR(panic_action)
Matthieu Patou [Mon, 17 Sep 2012 23:51:02 +0000 (16:51 -0700)]
panic action is defined as GLOBAL_VAR(szPanicAction) not GLOBAL_VAR(panic_action)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Sep 18 06:12:00 CEST 2012 on sn-devel-104
(cherry picked from commit 2a7484eb7286a6896826ad1ed15aa7b1760a451c)

Fix bug #9199 - fix usage of panic action.

11 years agos3:printing only do printing_subsystem_update when printing is enabled
Christian Ambach [Sun, 23 Sep 2012 06:39:49 +0000 (08:39 +0200)]
s3:printing only do printing_subsystem_update when printing is enabled

no point in calling this if printing was disabled and no spoolss service was started
this hurts CTDB clusters as the smbds on the cluster nodes will fight for the single record in the TDB

This fixes Bug 9197 - Disabling printing still makes smbd create and access printer_list.tdb

11 years agodynconfig/config.m4: disallow --prefix=/usr and --prefix=/usr/local without --enable-fhs
Stefan Metzmacher [Wed, 18 Jan 2012 07:33:37 +0000 (08:33 +0100)]
dynconfig/config.m4: disallow --prefix=/usr and --prefix=/usr/local without --enable-fhs

This matches the waf configure behavior and catches the case where old build
scripts try '--with-fhs' instead of '--enable-fhs'.

metze
(cherry picked from commit ae037670b83557d8591c633896186a3634de30cc)

Fix bug #9194 - dynconfig/config.m4: disallow --prefix=/usr and
--prefix=/usr/local without --enable-fhs.

11 years agos3:smb2_server: fix usage of invalid memory in smb2_signing_check_pdu()
Stefan Metzmacher [Wed, 19 Sep 2012 22:42:02 +0000 (00:42 +0200)]
s3:smb2_server: fix usage of invalid memory in smb2_signing_check_pdu()

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Sep 20 07:18:31 CEST 2012 on sn-devel-104
(cherry picked from commit bc77745cfaf502e24575dab9ae323643d94760e3)

Fix bug #9193 - s3:smb2_server: fix usage of invalid memory in
smb2_signing_check_pdu().

11 years agoWe now pass "samba3.raw.acls.generic" and "samba3.smb2.acls.GENERIC" with the max...
Jeremy Allison [Thu, 20 Sep 2012 20:35:47 +0000 (13:35 -0700)]
We now pass "samba3.raw.acls.generic" and "samba3.smb2.acls.GENERIC" with the max access change.

11 years agoFix bug #9189 - SMB2 Create doesn't return correct MAX ACCESS access mask in blob.
Jeremy Allison [Thu, 20 Sep 2012 19:32:10 +0000 (12:32 -0700)]
Fix bug #9189 - SMB2 Create doesn't return correct MAX ACCESS access mask in blob.

If we aren't already granted DELETE access, check if we have
DELETE_CHILD in the containing directory.

11 years agopackaging/RHEL-CTDB: add "BUILD_GPFS=no configure.rpm" and "BUILD_GPFS=no makerpms.sh"
Stefan Metzmacher [Mon, 17 Sep 2012 16:15:03 +0000 (18:15 +0200)]
packaging/RHEL-CTDB: add "BUILD_GPFS=no configure.rpm" and "BUILD_GPFS=no makerpms.sh"

metze
(cherry picked from commit 56956910051a8d11b36d125780fde048d29ad604)

The last 4 patches address bug #9198 - backport RHEL-CTDB packaging fixes.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Sep 27 14:27:03 CEST 2012 on sn-devel-104

11 years agopackaging/RHEL-CTDB: try harder to set $RPMVER
Stefan Metzmacher [Mon, 17 Sep 2012 16:15:03 +0000 (18:15 +0200)]
packaging/RHEL-CTDB: try harder to set $RPMVER

metze
(cherry picked from commit 914fc4f265ef9f538fc5077fe0257565b282bd24)

11 years agopackaging/RHEL-CTDB: fix the build
Stefan Metzmacher [Mon, 17 Sep 2012 16:15:03 +0000 (18:15 +0200)]
packaging/RHEL-CTDB: fix the build

metze
(cherry picked from commit 77f281a6d16cd9e7a787de8d954846a840fb03b0)

11 years agosource3/script: fix installman.sh after the last build-manpages-nogit change
Michael Adam [Tue, 18 Sep 2012 00:30:27 +0000 (20:30 -0400)]
source3/script: fix installman.sh after the last build-manpages-nogit change

    commit cfdab79729e8507a7504b0224c60454d3bc40ffc
    Author: Michael Adam <obnox@samba.org>
    Date:   Wed Sep 12 15:46:35 2012 +0200

        release-scripts: let build-manpages-nogit store generated docs under ./bin/docs

        not under ./docs

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 1a945686a6770a0ac17bded73201368f10c65bc9)

11 years agoquota: add supprt for gfs2
Björn Jacke [Tue, 18 Sep 2012 11:57:30 +0000 (13:57 +0200)]
quota: add supprt for gfs2

gfs2 uses the same generic quota interface as xfs and it has the same base
block/quota block size ratio and seems to work nice with the xfs quota module.

(People using gfs should be aware that quota reporting is lagging quite a bit
on gfs.  If you copy a file on a gfs volume the quota values are being updated
with a delay of 30s here with kernel 3.5. This reporting can lead to data
corruption if a client thinks he can write but actually he suddently can't.)
(cherry picked from commit 0b57d1c07520f4995412f224945324fef29f5989)

11 years agos3:smbd: release the share mode lock before calling exit_server() (bug #9191)
Stefan Metzmacher [Fri, 21 Sep 2012 18:36:16 +0000 (20:36 +0200)]
s3:smbd: release the share mode lock before calling exit_server() (bug #9191)

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Sep 21 22:36:57 CEST 2012 on sn-devel-104

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Thu Sep 27 10:41:27 CEST 2012 on sn-devel-104

11 years agodocs: Fix generating idmap manpages.
Andreas Schneider [Thu, 13 Sep 2012 15:52:13 +0000 (17:52 +0200)]
docs: Fix generating idmap manpages.

Signed-off-by: Andreas Schneider <asn@samba.org>
Fix bug #9159 - idmap manpages are not built.

Autobuild-User(v4-0-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-0-test): Sun Sep 23 04:38:19 CEST 2012 on sn-devel-104

11 years agos3: make ldapsam-related functions a smbldaphelper subsystem
Alexander Bokovoy [Thu, 13 Sep 2012 12:40:31 +0000 (15:40 +0300)]
s3: make ldapsam-related functions a smbldaphelper subsystem

Since these functions are used in pdb_ldap and idmap_ldap, and
pdb_ldap might be statically linked to libpdb (default), it is
better to keep them as separate subsystem to avoid polluting libpdb
namespace.

This is first step in refactoring libpdb. Right now I cannot move
these functions into proper libsmbldaphelper as it uses more of
libpdb-included functions and linking pdb_ldap against libsmbldaphelper
library would have created a loop if pdb_ldap is included into libpdb.

Fix bug #9157 - libpdb/pdb_ldap/idmap_ldap build dependencies cleanup.

11 years agoSigh :-(. Removing optimization prematurely is the root of all evil :-(.
Jeremy Allison [Thu, 13 Sep 2012 17:13:21 +0000 (10:13 -0700)]
Sigh :-(. Removing optimization prematurely is the root of all evil :-(.

Sorry for the mistake, but the LastDir singleton cache in vfs_ChDir()
actually plays an important role. When we're processing a stream of
SMB1/SMB2/SMB3 requests we don't want to add a chdir()/getcwd()
system call pair on every request if they're all on the same connection
and dealing with the same base path.

I did some testing with a program that times 1,000,000 chdir()
requests vs. 1,000,000 strcmp requests and it's a penalty of 10x
doing the system calls.

Just because it's old code, doesn't mean it's bad :-(.

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Sep 13 21:31:42 CEST 2012 on sn-devel-104

Fix bug #9161 - We should re-add the vfs_Chdir() cache I removed.

11 years agos3:vfs_gpfs: fix build
Christian Ambach [Sat, 15 Sep 2012 20:57:51 +0000 (22:57 +0200)]
s3:vfs_gpfs: fix build

after recent VFS changes
(cherry picked from commit 7a6182962966e5edb42728c8d0a4d471a69c83d7)

The last 5 patches address bug #162 - Illumos/Solaris Build is Broken using
--with-acl.

11 years agos3: fix the aix acl module
Björn Jacke [Fri, 14 Sep 2012 07:35:53 +0000 (09:35 +0200)]
s3: fix the aix acl module

This was not adopted to the recent VFS acl structure changes.
(cherry picked from commit 35632eec8e3b0dcfecffde814a790cc4f444dd97)

11 years agos3: fix the tru64 acl module
Björn Jacke [Fri, 14 Sep 2012 07:40:07 +0000 (09:40 +0200)]
s3: fix the tru64 acl module

This was not adopted to the recent VFS acl structure changes.
(cherry picked from commit 9222f0f9280485c2751ecfdb96421da25e6e5344)

11 years agos3: fix the hpux acl module
Björn Jacke [Fri, 14 Sep 2012 08:01:33 +0000 (10:01 +0200)]
s3: fix the hpux acl module

This was not adopted to the recent VFS acl structure changes.

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Fri Sep 14 12:23:23 CEST 2012 on sn-devel-104
(cherry picked from commit 1aa281ecb0f45c97d78161fd1308be8655295f1f)

11 years agos3: Fix the vfs_solarisacl module to compile.
Ira Cooper [Fri, 14 Sep 2012 01:32:45 +0000 (01:32 +0000)]
s3: Fix the vfs_solarisacl module to compile.

This got broken with the recent VFS acl structure changes.

11 years agoscript/autobuild.py: add --log-base option
Stefan Metzmacher [Sat, 22 Sep 2012 00:40:19 +0000 (02:40 +0200)]
script/autobuild.py: add --log-base option

metze

Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Sep 22 23:21:59 CEST 2012 on sn-devel-104
(cherry picked from commit f339c1fd91baaff1d727cda1a30b0963423dcb5b)

Autobuild-User(v4-0-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-0-test): Sun Sep 23 02:21:00 CEST 2012 on sn-devel-104

11 years agoscript/autobuild.py: add log_base variable to avoid hardcoded values
Stefan Metzmacher [Sat, 22 Sep 2012 00:34:38 +0000 (02:34 +0200)]
script/autobuild.py: add log_base variable to avoid hardcoded values

metze
(cherry picked from commit 1362bb548c9cb6d3e688ab102bd1d8166d73d95f)

11 years agoscript/autobuild.py: add --branch option
Stefan Metzmacher [Sat, 22 Sep 2012 00:26:10 +0000 (02:26 +0200)]
script/autobuild.py: add --branch option

metze
(cherry picked from commit 23dbf63e2d1bf3a30a2b6563fc9bafde4ca157fb)

11 years agoscript/autobuild.py: use some variables for push_remote and push_branch
Stefan Metzmacher [Sat, 22 Sep 2012 00:18:11 +0000 (02:18 +0200)]
script/autobuild.py: use some variables for push_remote and push_branch

metze
(cherry picked from commit ce22882df7e00b22a735539791806264424033a7)

11 years agoscript/autobuild.py: use some variables for rebase_remote and rebase_branch
Stefan Metzmacher [Fri, 21 Sep 2012 22:23:21 +0000 (00:23 +0200)]
script/autobuild.py: use some variables for rebase_remote and rebase_branch

metze
(cherry picked from commit a68ab0e97e8dedc8298ca6502b1efc6ca2e32d66)

11 years agoVERSION: Release Samba 4.0.0rc1 samba-4.0.0rc1
Michael Adam [Wed, 12 Sep 2012 13:30:24 +0000 (15:30 +0200)]
VERSION: Release Samba 4.0.0rc1

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agoWHATSNEW: prepare release notes for 4.0.0rc1
Michael Adam [Wed, 12 Sep 2012 13:27:48 +0000 (15:27 +0200)]
WHATSNEW: prepare release notes for 4.0.0rc1

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agobuild:dist: call source3/autogen.sh and packaged generated files
Michael Adam [Wed, 12 Sep 2012 15:11:28 +0000 (17:11 +0200)]
build:dist: call source3/autogen.sh and packaged generated files

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agobuild:dist: call build-manpages-nogit for make dist and package generated files
Michael Adam [Wed, 12 Sep 2012 15:10:31 +0000 (17:10 +0200)]
build:dist: call build-manpages-nogit for make dist and package generated files

so that we always have generated manpages under docs/manpages in the release
tarball

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agobuild:dist: extend meaning of DIST_FILES to also recurse into directories
Michael Adam [Wed, 12 Sep 2012 15:06:23 +0000 (17:06 +0200)]
build:dist: extend meaning of DIST_FILES to also recurse into directories

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agobuild:dist: make use of file / distfile more obvious in handling of DIST_FILES in...
Michael Adam [Wed, 12 Sep 2012 21:45:50 +0000 (23:45 +0200)]
build:dist: make use of file / distfile more obvious in handling of DIST_FILES in "make dist"

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agobuild:dist: for snapshot builds, call DIST_DIRS with extend=True
Michael Adam [Wed, 12 Sep 2012 15:04:50 +0000 (17:04 +0200)]
build:dist: for snapshot builds, call DIST_DIRS with extend=True

to allow the distversion file to be an addition to the list

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agobuild:dist: extend samba_dist.DIST_FILES() to take optional parameter extend(=False)
Michael Adam [Wed, 12 Sep 2012 15:02:39 +0000 (17:02 +0200)]
build:dist: extend samba_dist.DIST_FILES() to take optional parameter extend(=False)

This allows to do multpile DIST_FILES() calls that will extend the list
rather than only setting it initially.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agobuild:waf dist: factor out function to add list of files to the tarball
Michael Adam [Wed, 12 Sep 2012 15:01:40 +0000 (17:01 +0200)]
build:waf dist: factor out function to add list of files to the tarball

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

11 years agos3:build: rewrite autogen.sh to be called from any directory
Michael Adam [Wed, 12 Sep 2012 15:48:12 +0000 (17:48 +0200)]
s3:build: rewrite autogen.sh to be called from any directory

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agorelease-scripts: run build-manpages-nogit with bash
Michael Adam [Wed, 12 Sep 2012 15:38:04 +0000 (17:38 +0200)]
release-scripts: run build-manpages-nogit with bash

On debian/ubuntu, the "dash" which is sh, does not
provide pushd/popd...

Signed-off-by: Stefan Metzmacher <metze@samba.org>