Jeremy Allison [Thu, 6 Jul 2006 21:25:29 +0000 (21:25 +0000)]
r16843: Confirm that openX uses the same mapping table as getatr.
Jeremy.
Volker Lendecke [Thu, 6 Jul 2006 20:34:18 +0000 (20:34 +0000)]
r16842: Jeremy, I almost don't dare checking this in.....
Volker
Jelmer Vernooij [Thu, 6 Jul 2006 17:17:35 +0000 (17:17 +0000)]
r16838: Allow compilation by midl. Patch by andrzej.hajda@wp.pl
Andrew Bartlett [Thu, 6 Jul 2006 08:42:43 +0000 (08:42 +0000)]
r16835: Remove RPC-SAMR from the test, until I can clear up the unexplained failure.
Andrew Bartlett
Stefan Metzmacher [Thu, 6 Jul 2006 08:00:24 +0000 (08:00 +0000)]
r16834: split the level's of smb_search_first/smb_search_next and the levels
of smb_search_data
metze
Andrew Bartlett [Thu, 6 Jul 2006 07:40:26 +0000 (07:40 +0000)]
r16833: Add a base DN to more search calls, we need to look for an ID over the
whole tree here.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 07:37:41 +0000 (07:37 +0000)]
r16832: I should be more careful (and test!) when trying to make compilers and
static checkers happy...
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 06:04:06 +0000 (06:04 +0000)]
r16831: Use a valid memory context (found by the IBM checker).
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 05:55:26 +0000 (05:55 +0000)]
r16830: Fix IBM checker and GCC warnings.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 05:51:39 +0000 (05:51 +0000)]
r16829: Fix a number of issues raised by the IBM checker, or gcc warnings.
In particular, this removes one use of the LDB_DN_NULL_FAILED macro,
which was being used on more than DNs, had an embedded goto, and
confused the IBM checker.
In the password_hash code, ensure that sambaAttr is not, before
checking the number of values.
In GENSEC, note that this switch value can't occour. This seems to be
the only way to quiet both the IBM checker and gcc, as well as cope
with possibly invalid inputs.
Andrew Bartlet
Andrew Bartlett [Thu, 6 Jul 2006 05:25:36 +0000 (05:25 +0000)]
r16828: Add RPC-LSA as a test that passes, and remove RAW-ACLs until someone
can fix it.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 05:23:29 +0000 (05:23 +0000)]
r16827: Factor out some code into common samdb functions:
- creation of ForeignSecurityPrincipals
- template duplication code
Rework much of the LSA server to pass the RPC-LSA test. Much of the
server code was untested. In implementing the LSA Accounts feature, I
have opted to have it only create entires when privilages are applied,
and not to delete entries, but to delete the privilages.
We skip some parts of the test, but it is much better than not testing
it at all.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 05:09:14 +0000 (05:09 +0000)]
r16826: Ensure we don't segfault if the remote server fails to set a password
in RPC-SAMR test.
Andrew Bartlett
Andrew Bartlett [Thu, 6 Jul 2006 05:08:30 +0000 (05:08 +0000)]
r16825: Make ldb_sainity_check() set an error string. This makes it much
easier to chase down what modules or application code gets wrong.
Ensure not to leave memory allocated on failure in ldb_search()
Andrew Bartlett
Jelmer Vernooij [Wed, 5 Jul 2006 20:49:50 +0000 (20:49 +0000)]
r16824: Rename Ethereal -> Wireshark (patch from Joerg Mayer)
Stefan Metzmacher [Wed, 5 Jul 2006 06:47:34 +0000 (06:47 +0000)]
r16815: split out search levels which are also used by smb2
metze
Günther Deschner [Tue, 4 Jul 2006 16:42:09 +0000 (16:42 +0000)]
r16801: Adding WERR_DS_DRA_ACCESS_DENIED.
Guenther
Günther Deschner [Tue, 4 Jul 2006 10:25:04 +0000 (10:25 +0000)]
r16796: Fill in dsr_GetMemberships() / dsr_GetMemberships2().
This intersting call is apparently used to construct the user token,
collect memberships from other DSAs and to retrieve (nested) memberships
of a given group.
Torture test to follow (once I cleaned it up).
Guenther
Andrew Bartlett [Tue, 4 Jul 2006 03:32:39 +0000 (03:32 +0000)]
r16795: Fix crash found by Dave Fenwick <djf@samba.org>.
The session_info was not being attached to the connection, so
subsequent checks in the kludge_acl module were looking at free()ed
memory.
Andrew Bartlett
Andrew Bartlett [Tue, 4 Jul 2006 02:46:24 +0000 (02:46 +0000)]
r16794: Make Samba4 pass it's own RPC-SAMR test, at least in part. There are
still a couple of unimplemented functions, but this is far better than
not testing this at all. In particular, this exercises the
password_hash module.
Specific changes:
- Add support for SetDomainInfo
- Add many more info levels to QueryDomainInfo
- Set a domain comment in RPC-SAMR, and verify it is kept
- Refactor QueryUserInfo not to always serach for all attributes
- Add QueryDiplayInfo3 and QueryDomainInfo2 as aliased calls
- Make OemChangePassword2 search under the samdb_base_dn(), so it
finds the user when partitions are active.
- Skip SetSecurity, DisplayIndex, MemberAttributesOfGroup and
'Multiple' alias operations in RPC-SAMR for Samba4
- Add RPC-SAMR as a 'slow' RPC test (it is quite slow)
Andrew Bartlett
Rafal Szczesniak [Mon, 3 Jul 2006 22:35:15 +0000 (22:35 +0000)]
r16791: Typo fix in a comment.
rafal
Simo Sorce [Mon, 3 Jul 2006 15:49:23 +0000 (15:49 +0000)]
r16784: - make some function in ldb static, they not need to be exported anywhere
- fix a bad segfault
Andrew please make test before committing.
Simo.
Stefan Metzmacher [Mon, 3 Jul 2006 08:16:16 +0000 (08:16 +0000)]
r16776: fix typo
metze
Andrew Bartlett [Mon, 3 Jul 2006 06:40:56 +0000 (06:40 +0000)]
r16774: This patch modifies the tdb API to allow the logging function to be used
as part of ldb.
This allows tdb failures to be passed all the way up to Samba's DEBUG
system, which allowed easier debugging.
Unfortunately I had to extend the tdb API, as the logging function
didn't have a context pointer.
I've worked over the 'debug levels' in TDB. Most of them were 0,
which didn't seem right, as some were trace-like messages. We didn't
see any of these previously, except when accessing TDB directly.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 04:00:10 +0000 (04:00 +0000)]
r16773: Fix one more RPC-SAMR test (an alias level), and make it clear that
the unknown value in the samr_GroupInfo structures are the group
attributes.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 03:58:01 +0000 (03:58 +0000)]
r16772: Clarify comment.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 03:57:08 +0000 (03:57 +0000)]
r16771: Add const and some better debug messages.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 03:39:02 +0000 (03:39 +0000)]
r16770: Get closer to having Samba4 pass some of the RPC-SAMR test, by
skipping some checks.
These should be removed, and the code fixed, but currently we are
loosing quality because the test isn't run by default.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 03:37:55 +0000 (03:37 +0000)]
r16769: Working on fixing the RPC-SAMR test against Samba4. This fixes
password changes which only include the LM and NT hash, such as the
original ChangePassword.
It also fixes setting passwords on the BUILTIN domain.
Finally, the msDS-KeyVersionNumber is only incremented if not
explicity set by the modify.
Andrew Bartlett
Andrew Bartlett [Mon, 3 Jul 2006 01:04:14 +0000 (01:04 +0000)]
r16768: Add a simple script to set a user's password. This should grow into a
real smbpasswd command some day.
Andrew Bartlett
Jeremy Allison [Sun, 2 Jul 2006 21:05:19 +0000 (21:05 +0000)]
r16761: Added additional NTSTATUS and DOS error test for "."
This confirms a theory of mine...
Added RAW-SAMBA3BADPATH to selectable options.
Jeremy.
Volker Lendecke [Sun, 2 Jul 2006 17:40:35 +0000 (17:40 +0000)]
r16759: Jeremy, another little error case for you :-)
For the paths with illegal characters we should return ERRDOS:ERRbadpath in
the DOS error case. We return ERRDOS:ERRinvalidname...
Volker
Volker Lendecke [Sun, 2 Jul 2006 08:53:49 +0000 (08:53 +0000)]
r16756: Some machines on the build farms sporadically fail the test
/* Test 21 -- Test removal of file after socket close. */
I think it might be because they are too slow to delete the file.
Jeremy, can you check this test does not change semantics in a way you don't
want it?
Volker
Stefan Metzmacher [Sat, 1 Jul 2006 14:41:01 +0000 (14:41 +0000)]
r16741: add a RPC-LSA-GETUSER test,
which is very useful for analysing a windows machine remotely
with this I found that vista-beta2 doesn't have an 'administrator' account
and mapps any not known user to MACHINENAME\Guest
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:36:04 +0000 (14:36 +0000)]
r16740: just say the directory is empty
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:31:20 +0000 (14:31 +0000)]
r16739: test SMB2-GETINFO SMB2-SETINFO by make test
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:27:49 +0000 (14:27 +0000)]
r16738: vista beta2 use FILE_CLOSED as error for an invalid file handle
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:21:21 +0000 (14:21 +0000)]
r16737: if an error happens report it
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:20:14 +0000 (14:20 +0000)]
r16736: - convert unix times to nttime before sending it to the wire...
- return an error code if an error happens
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:18:20 +0000 (14:18 +0000)]
r16735: vista beta2 reuses the tcp connect where it does the
SMB negprot
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:14:11 +0000 (14:14 +0000)]
r16734: the 2 bytes after the opcode and before the flags,
is no padding...
the following patch is needed for vista beta2 to connect to samba4
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:12:13 +0000 (14:12 +0000)]
r16733: implement SMB2 SetInfo
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:11:00 +0000 (14:11 +0000)]
r16732: use the given macros
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:10:07 +0000 (14:10 +0000)]
r16731: send a better error code, required for vista-beta2 client
metze
Stefan Metzmacher [Sat, 1 Jul 2006 14:04:28 +0000 (14:04 +0000)]
r16730: that is correct...
metze
Stefan Metzmacher [Sat, 1 Jul 2006 07:49:02 +0000 (07:49 +0000)]
r16725: don't ignore errors
metze
Stefan Metzmacher [Sat, 1 Jul 2006 07:47:49 +0000 (07:47 +0000)]
r16724: fix typo...
metze
Stefan Metzmacher [Fri, 30 Jun 2006 21:51:47 +0000 (21:51 +0000)]
r16716: patch from Bjoern Jacke to fix compiler warnings on AIX
metze
Stefan Metzmacher [Fri, 30 Jun 2006 11:07:47 +0000 (11:07 +0000)]
r16708: the packet format of SMB2 SessionSetup has changed,
there're 8 more unknown bytes...
Note:
- vista-CTP also support this as a server,
but uses the old format as client
- but vista-beta2 only uses and accept the new format
metze
Stefan Metzmacher [Fri, 30 Jun 2006 08:19:44 +0000 (08:19 +0000)]
r16707: - test attrib = 0 in BASIC_INFO
- return an error when value doesn't match the expected value!
metze
Stefan Metzmacher [Fri, 30 Jun 2006 08:16:59 +0000 (08:16 +0000)]
r16706: for RAW_SFILEINFO_SETATTR attrib == 0 means set it to FILE_ATTRIB_NORMAL
and attrib == FILE_ATTRIB_NORMAL means no change...
but for RAW_SFILEINFO_BASIC_INFORMATION attrib == 0 means no change
metze
Stefan Metzmacher [Thu, 29 Jun 2006 23:11:07 +0000 (23:11 +0000)]
r16705: fix a bug found by valgrind...
as we setup the 1 padding byte for non present dynamic part,
we need to overwrite it when we're getting a real dynamic part,
so we need to remove the buf->size +=1 when we do the first
push to the dynamic part (when buf->dynamic is still but->body + buf->body_fixed)
metze
Stefan Metzmacher [Thu, 29 Jun 2006 22:16:58 +0000 (22:16 +0000)]
r16699: the layout of SMB2 Read and Write is identical...
so we know that the 9th bytes is just uninitialized padding
metze
Rafal Szczesniak [Thu, 29 Jun 2006 20:34:45 +0000 (20:34 +0000)]
r16694: Store lsa rpc pipe pointer in a right place.
rafal
Rafal Szczesniak [Thu, 29 Jun 2006 20:26:11 +0000 (20:26 +0000)]
r16693: Name type should be passed further down the lookup engine instead
of assuming only PDC name type. Also, fix the comment.
rafal
Rafal Szczesniak [Thu, 29 Jun 2006 20:23:42 +0000 (20:23 +0000)]
r16692: More comments and further code in set_user_changes routine.
rafal
Stefan Metzmacher [Thu, 29 Jun 2006 19:16:13 +0000 (19:16 +0000)]
r16691: we should only look at rdata.data.length when we're in ndr_push mode
metze
Stefan Metzmacher [Thu, 29 Jun 2006 18:56:09 +0000 (18:56 +0000)]
r16690: - fix bug 3896
- we didn't pushed the wins wack reply correctly to the wire,
as NBT_QTYPE_NETBIOS is used and setting rdata.data.data was useless...
metze
Stefan Metzmacher [Thu, 29 Jun 2006 14:00:57 +0000 (14:00 +0000)]
r16672: we don't need this twice:-)
metze
Stefan Metzmacher [Thu, 29 Jun 2006 12:39:41 +0000 (12:39 +0000)]
r16671: allow usage of smbsrv_pull_passthru_sfileinfo() without,
a smbsrv_request given...
the RENAME level is not supported in this mode, but that will be fixed later
metze
Stefan Metzmacher [Thu, 29 Jun 2006 11:17:37 +0000 (11:17 +0000)]
r16670: try to match the vista error codes a bit more
metze
Stefan Metzmacher [Thu, 29 Jun 2006 11:08:27 +0000 (11:08 +0000)]
r16669: this calls don't expect any valid error codes than NT_STATUS_OK
metze
Stefan Metzmacher [Thu, 29 Jun 2006 07:03:09 +0000 (07:03 +0000)]
r16668: test setting of security descriptors vis smb2 setinfo
metze
Stefan Metzmacher [Thu, 29 Jun 2006 07:02:14 +0000 (07:02 +0000)]
r16667: - use ndr_pull_struct_blob() to make the RAW_FILEINFO_SEC_DESC pull code
simpler
- use ndr_push_struct_blob() for RAW_SFILEINFO_SEC_DESC
metze
Stefan Metzmacher [Thu, 29 Jun 2006 06:53:44 +0000 (06:53 +0000)]
r16666: implement setting of security_descriptors via SMB2 SetInfo
metze
Volker Lendecke [Wed, 28 Jun 2006 22:09:03 +0000 (22:09 +0000)]
r16657: Test Jerry's iTunes bug, along with some more error conditions
Volker
Stefan Metzmacher [Wed, 28 Jun 2006 15:08:54 +0000 (15:08 +0000)]
r16621: split out passthru levels of setfileinfo
metze
Rafal Szczesniak [Tue, 27 Jun 2006 22:16:36 +0000 (22:16 +0000)]
r16573: Fixes in comments.
rafal
Rafal Szczesniak [Tue, 27 Jun 2006 20:46:23 +0000 (20:46 +0000)]
r16572: More comments and simple refactoring of one condition.
rafal
Stefan Metzmacher [Tue, 27 Jun 2006 17:58:57 +0000 (17:58 +0000)]
r16571: - make push/pull_ascii()/_ucs() functions static,
callers should use push/pull_string() functions with STR_ASCII or STR_UNICODE
- make the push/pull_ascii/ucs2/utf8_talloc() functions complete
(they should be reduced to pull/push_string_talloc() later...)
metze
Stefan Metzmacher [Tue, 27 Jun 2006 17:55:02 +0000 (17:55 +0000)]
r16569: - use push_string()
metze
Stefan Metzmacher [Tue, 27 Jun 2006 17:46:57 +0000 (17:46 +0000)]
r16568: add parsing code for SMB2 SetInfo
metze
Stefan Metzmacher [Tue, 27 Jun 2006 17:16:14 +0000 (17:16 +0000)]
r16566: add pull function for a site32/offset32 blob
metze
Stefan Metzmacher [Tue, 27 Jun 2006 11:07:55 +0000 (11:07 +0000)]
r16561: - create version.h relative to srcdir
- let version.h depend on VERSION
- add a rule to manualy regenerate version.h
e.g. after a svn up
metze
Stefan Metzmacher [Tue, 27 Jun 2006 10:55:19 +0000 (10:55 +0000)]
r16560: print out the correct value
metze
James Peach [Tue, 27 Jun 2006 06:24:43 +0000 (06:24 +0000)]
r16558: Add make rule to generate version.h. Metze, can you please review?
James Peach [Tue, 27 Jun 2006 06:17:11 +0000 (06:17 +0000)]
r16557: Silently succeed when torture_register_suite is passed NULL.
James Peach [Tue, 27 Jun 2006 05:49:09 +0000 (05:49 +0000)]
r16556: Add mkdtemp to libreplace. This is apparantly available on Linux
and BSD systems, but it's not everywhere.
Rafal Szczesniak [Mon, 26 Jun 2006 21:21:59 +0000 (21:21 +0000)]
r16533: Perform a cleanup after testing. Also, add changed name argument.
This test currently triggers internal corruption in ldb database,
according to status code returned. I'm investigating win servers
behaviour here.
rafal
Rafal Szczesniak [Mon, 26 Jun 2006 21:19:41 +0000 (21:19 +0000)]
r16532: Tell username from account name (source from target, when
changing).
rafal
Rafal Szczesniak [Mon, 26 Jun 2006 21:18:45 +0000 (21:18 +0000)]
r16531: Add a function preparing argument for modify user routine.
rafal
Rafal Szczesniak [Mon, 26 Jun 2006 21:17:31 +0000 (21:17 +0000)]
r16530: Send monitor messages only after successful receiving result of a stage.
rafal
Jelmer Vernooij [Mon, 26 Jun 2006 20:32:22 +0000 (20:32 +0000)]
r16529: Fix type.
Jelmer Vernooij [Mon, 26 Jun 2006 20:09:35 +0000 (20:09 +0000)]
r16527: Add target argument for smbtorture.
Remove duplicate unc path separator conversion.
Add prefix for tempdirs.
Jelmer Vernooij [Mon, 26 Jun 2006 19:30:00 +0000 (19:30 +0000)]
r16526: Add torture_setup_server() with test.
Jelmer Vernooij [Mon, 26 Jun 2006 19:29:43 +0000 (19:29 +0000)]
r16525: Move selftest-specific code back to selftest.
Jelmer Vernooij [Mon, 26 Jun 2006 19:23:21 +0000 (19:23 +0000)]
r16524: Fix double evaluation.
Stefan Metzmacher [Mon, 26 Jun 2006 18:31:39 +0000 (18:31 +0000)]
r16523: pass spoolss_XcvData calls to the ntptr backends...
I wrote this code last year and found it in a working tree...
metze
Jelmer Vernooij [Mon, 26 Jun 2006 17:43:39 +0000 (17:43 +0000)]
r16522: Move code to create the test data out of selftest.sh.
Stefan Metzmacher [Mon, 26 Jun 2006 15:24:10 +0000 (15:24 +0000)]
r16520: move smb2srv_break_recv back to fileio.c
metze
Jelmer Vernooij [Mon, 26 Jun 2006 11:33:37 +0000 (11:33 +0000)]
r16518: Split up torture_util.c in smb and non-smb specific parts.
Add torture_temp_dir() function, with test.
Jelmer Vernooij [Mon, 26 Jun 2006 11:29:48 +0000 (11:29 +0000)]
r16517: Get rid of pointless safe_free() (not SAFE_FREE()!) function.
Jelmer Vernooij [Mon, 26 Jun 2006 11:23:06 +0000 (11:23 +0000)]
r16516: Get rid of file_exists() as there already is a file_exist().
Jelmer Vernooij [Sun, 25 Jun 2006 22:42:12 +0000 (22:42 +0000)]
r16514: Fix build (not run!) of --enable-dso.
Andrew Bartlett [Fri, 23 Jun 2006 21:05:45 +0000 (21:05 +0000)]
r16489: Because the torture/ui.h file isn't automaticly generated, the
prototypes in it need to use the PRINTF_ATTRIBUTE() macro, rather than
_PRINTF_ATTRIBUTE() (which becomes PRINTF_ATTRIBUTE() only in proto
files, but not C files).
This found a number of missing descriptions in the LOCAL-SOCKET test.
Andrew Bartlett
Rafal Szczesniak [Thu, 22 Jun 2006 21:29:21 +0000 (21:29 +0000)]
r16476: Error in composite functions implemented the 'old way' (single event handler,
no continue functions) need to report an error by means of state only.
composite_error calls event handler function which frees the context and
state structure. This fixes a segfault in some cases (caught it on modifyuser
test).
rafal
Stefan Metzmacher [Thu, 22 Jun 2006 17:50:02 +0000 (17:50 +0000)]
r16469: do some smb2 tests
metze
Stefan Metzmacher [Thu, 22 Jun 2006 17:36:06 +0000 (17:36 +0000)]
r16468: implement SMB2_ALL_INFORMATION in the posix backend
metze
Stefan Metzmacher [Thu, 22 Jun 2006 17:35:04 +0000 (17:35 +0000)]
r16467: implement SMB2 GetInfo server code
metze
Stefan Metzmacher [Thu, 22 Jun 2006 17:33:56 +0000 (17:33 +0000)]
r16466: for SMB2_ALL_EAS it's not valid for the ntvfs backends to return
0 eas, they should return an error:
NO_EAS_ON_FILE or NO_MORE_EAS
metze